Browse Source

Don't reuse shared message instance (#7290)

* Don't reuse shared message instance

I believe the specs forbid reusing the same instance for json serialization. It's also wrong code-wise since concurrent requests could assign different strings to the same instance.

* Update Message.java
Sébastien Ros 3 years ago
parent
commit
45b9784d6a

+ 1 - 3
frameworks/Java/redkale/src/main/java/org/redkalex/benchmark/Message.java

@@ -16,8 +16,6 @@ import org.redkale.util.Bean;
 @Bean
 public final class Message {
 
-    private static final Message instance = new Message();
-
     @ConvertSmallString
     private String message;
 
@@ -29,7 +27,7 @@ public final class Message {
     }
 
     public static Message create(String str) {
-        instance.message = str;
+        Message instance = new Message(str);
         return instance;
     }