Browse Source

Use map instead of side-effecting each for Ruby benchmarks

Abe Voelker 12 years ago
parent
commit
5d7e843f38
2 changed files with 6 additions and 8 deletions
  1. 3 4
      rails/app/controllers/hello_world_controller.rb
  2. 3 4
      sinatra/hello_world.rb

+ 3 - 4
rails/app/controllers/hello_world_controller.rb

@@ -4,13 +4,12 @@ class HelloWorldController < ApplicationController
   end
   end
 
 
   def db
   def db
-    queries = params[:queries] || 1
+    queries = (params[:queries] || 1).to_i
 
 
-    results = []
-    (1..queries.to_i).each do
+    results = (1..queries).map do
       # get a random row from the database, which we know has 10000
       # get a random row from the database, which we know has 10000
       # rows with ids 1 - 10000
       # rows with ids 1 - 10000
-      results << World.find(Random.rand(10000) + 1)
+      World.find(Random.rand(10000) + 1)
     end
     end
     render :json => results
     render :json => results
   end
   end

+ 3 - 4
sinatra/hello_world.rb

@@ -21,11 +21,10 @@ get '/json' do
 end
 end
 
 
 get '/db' do
 get '/db' do
-  queries = params[:queries] || 1
+  queries = (params[:queries] || 1).to_i
 
 
-  results = []
-  (1..queries.to_i).each do
-    results << World.find(Random.rand(10000) + 1)
+  results = (1..queries).map do
+    World.find(Random.rand(10000) + 1)
   end
   end
   
   
   results.to_json
   results.to_json