FixRunTests fixes a bug with truthy strings

Essentially, the bug was that the config reader would read in
the benchmark.cfg file as a string->string dictionary, and then
we would test the truthiness of the values. This ends up being
basically a `if bool("False"):` which evaluates to True.

Nothing can be set to `False` in the benchmark.cfg, so I ended
up commenting out those lines and setting their values to True
instead. This will imply that they are defaulted to False and
you should only uncomment them if you need to set them to True.

benchmark.cfg.example

@@ -12,16 +12,15 @@ exclude=None
 install=server
 install_error_action=continue
 install_strategy=unified
-install_only=False
-list_test_metadata=False
-list_tests=False
+#install_only=True
+#list_test_metadata=True
+#list_tests=True
 concurrency_levels=[8, 16, 32, 64, 128, 256]
 query_levels=[1, 5,10,15,20]
 threads=8
 mode=benchmark
 name=ec2
 os=linux
-parse=None
 password_prompt=False
 server_host=localhost
 sleep=60

toolset/run-tests.py

@@ -136,15 +136,15 @@ def main(argv=None):
     parser.add_argument('--install-strategy', choices=['unified', 'pertest'], default='unified', 
         help='''Affects `--install server`: With unified, all server software is installed into a single directory. 
         With pertest each test gets its own installs directory, but installation takes longer''')
-    parser.add_argument('--install-only', action='store_true', default=False, help='Do not run benchmark or verification, just install and exit')
+    parser.add_argument('--install-only', default=False, type=bool, help='Do not run benchmark or verification, just install and exit')
 
     # Test options
     parser.add_argument('--test', nargs='+', help='names of tests to run')
     parser.add_argument('--exclude', nargs='+', help='names of tests to exclude')
     parser.add_argument('--type', choices=['all', 'json', 'db', 'query', 'fortune', 'update', 'plaintext'], default='all', help='which type of test to run')
     parser.add_argument('-m', '--mode', choices=['benchmark', 'verify'], default='benchmark', help='verify mode will only start up the tests, curl the urls and shutdown')
-    parser.add_argument('--list-tests', action='store_true', default=False, help='lists all the known tests that can run')
-    parser.add_argument('--list-test-metadata', action='store_true', default=False, help='writes all the test metadata as a JSON file in the results directory')
+    parser.add_argument('--list-tests', default=False, type=bool, help='lists all the known tests that can run')
+    parser.add_argument('--list-test-metadata', default=False, type=bool, help='writes all the test metadata as a JSON file in the results directory')
     parser.add_argument('--name', default="ec2", help='The name to give this test. Results will be placed in a folder using this name.')
     parser.add_argument('--os', choices=['linux', 'windows'], default='linux', help='The operating system of the application/framework server (the one running' +
                         'this binary')
@@ -159,7 +159,7 @@ def main(argv=None):
 
     # Misc Options
     parser.add_argument('--parse', help='Parses the results of the given timestamp and merges that with the latest results')
-    parser.add_argument('-v', '--verbose', action='store_true', default=False, help='Causes the configuration to print before any other commands are executed.')
+    parser.add_argument('-v', '--verbose', default=False, type=bool, help='Causes the configuration to print before any other commands are executed.')
     parser.set_defaults(**defaults) # Must do this after add, or each option's default will override the configuration file default
     args = parser.parse_args(remaining_argv)