Fix FaF framework pipelining issue (#6523)

* add faf framework

* add faf framework

* clean up code and slight reorg

* add HTTP methods and cleanup

* converted to a library format, updated docker to point to a tag, generally simplified

* simplified README.md

* fix pipelining issue

* fix release settings in Cargo.toml

* fix release settings in Cargo.toml

frameworks/Rust/faf/Cargo.toml

@@ -15,4 +15,3 @@ overflow-checks = false
 [dependencies]
 mimalloc = { version = "*", default-features = false }
 faf = { git = "https://github.com/errantmind/faf" }
-#faf = { path = "/home/errant/dev/projects/faf-epoll" }

frameworks/Rust/faf/src/main.rs

@@ -1,3 +1,5 @@
+#![feature(core_intrinsics)]
+
 #[global_allocator]
 static GLOBAL: mimalloc::MiMalloc = mimalloc::MiMalloc;
 
@@ -6,11 +8,12 @@ use faf::const_config::*;
 use faf::const_http::*;
 use faf::extern_http_date;
 use faf::util::{const_len, memcmp};
+use std::intrinsics::likely;
 
 const ROUTE_PLAINTEXT: &[u8] = b"/p";
 const ROUTE_PLAINTEXT_LEN: usize = const_len(ROUTE_PLAINTEXT);
-const ROUTE_JSON: &[u8] = b"/j";
-const ROUTE_JSON_LEN: usize = const_len(ROUTE_JSON);
+// const ROUTE_JSON: &[u8] = b"/j";
+// const ROUTE_JSON_LEN: usize = const_len(ROUTE_JSON);
 
 const TEXT_PLAIN_CONTENT_TYPE: &[u8] = b"Content-Type: text/plain";
 const CONTENT_LENGTH: &[u8] = b"Content-Length: ";
@@ -40,55 +43,53 @@ fn cb(
    path_len: usize,
    _headers: &[faf::phr_header; MAX_HEADERS_TO_PARSE],
    _num_headers: usize,
-   response_buffer: &mut [u8; REQ_RES_BUFF_SIZE],
+   response_buffer: *mut u8,
 ) -> usize {
-   if method_len < GET_LEN || path_len < ROUTE_PLAINTEXT_LEN {
-      return 0;
-   }
    unsafe {
-      if memcmp(GET.as_ptr() as *const i8, method, GET_LEN) == 0 {
-         // For performance purposes, this will successfully match '/p' to '/plaintext' and '/pickle'. Use with caution
-         if memcmp(ROUTE_PLAINTEXT.as_ptr() as *const i8, path, ROUTE_PLAINTEXT_LEN) == 0 {
-            let mut date_buff = crate::extern_http_date::get_buff_with_date();
-            extern_http_date::get_http_date(&mut date_buff);
-            std::ptr::copy_nonoverlapping(PLAINTEXT_BASE.as_ptr(), response_buffer.as_mut_ptr(), PLAINTEXT_BASE_LEN);
-            std::ptr::copy_nonoverlapping(
-               date_buff.as_ptr(),
-               response_buffer.as_mut_ptr().add(PLAINTEXT_BASE_LEN),
-               DATE_LEN,
-            );
-            std::ptr::copy_nonoverlapping(
-               CRLFCRLF.as_ptr(),
-               response_buffer.as_mut_ptr().add(PLAINTEXT_BASE_LEN + DATE_LEN),
-               CRLFCRLF_LEN,
-            );
-            std::ptr::copy_nonoverlapping(
-               PLAINTEXT_BODY.as_ptr(),
-               response_buffer.as_mut_ptr().add(PLAINTEXT_BASE_LEN + DATE_LEN + CRLFCRLF_LEN),
-               PLAINTEXT_BODY_LEN,
-            );
+      if likely(method_len >= GET_LEN && path_len >= ROUTE_PLAINTEXT_LEN) {
+         if likely(memcmp(GET.as_ptr() as *const i8, method, GET_LEN) == 0) {
+            // For performance purposes, this will successfully match '/p' to '/plaintext' and '/pickle'. Use with caution
+            if likely(memcmp(ROUTE_PLAINTEXT.as_ptr() as *const i8, path, ROUTE_PLAINTEXT_LEN) == 0) {
+               let mut date_buff = crate::extern_http_date::get_buff_with_date();
+               extern_http_date::get_http_date(&mut date_buff);
+               std::ptr::copy_nonoverlapping(PLAINTEXT_BASE.as_ptr(), response_buffer, PLAINTEXT_BASE_LEN);
+               std::ptr::copy_nonoverlapping(
+                  date_buff.as_ptr(),
+                  response_buffer.add(PLAINTEXT_BASE_LEN),
+                  DATE_LEN,
+               );
+               std::ptr::copy_nonoverlapping(
+                  CRLFCRLF.as_ptr(),
+                  response_buffer.add(PLAINTEXT_BASE_LEN + DATE_LEN),
+                  CRLFCRLF_LEN,
+               );
+               std::ptr::copy_nonoverlapping(
+                  PLAINTEXT_BODY.as_ptr(),
+                  response_buffer.add(PLAINTEXT_BASE_LEN + DATE_LEN + CRLFCRLF_LEN),
+                  PLAINTEXT_BODY_LEN,
+               );
 
-            return PLAINTEXT_BASE_LEN + DATE_LEN + CRLFCRLF_LEN + PLAINTEXT_BODY_LEN;
-         } else if memcmp(ROUTE_JSON.as_ptr() as *const i8, path, ROUTE_JSON_LEN) == 0 {
+               PLAINTEXT_BASE_LEN + DATE_LEN + CRLFCRLF_LEN + PLAINTEXT_BODY_LEN
+            } else {
+               std::ptr::copy_nonoverlapping(
+                  HTTP_404_NOTFOUND.as_ptr(),
+                  response_buffer,
+                  HTTP_404_NOTFOUND_LEN,
+               );
+               HTTP_404_NOTFOUND_LEN
+            }
          } else {
             std::ptr::copy_nonoverlapping(
-               HTTP_404_NOTFOUND.as_ptr(),
-               response_buffer.as_mut_ptr(),
-               HTTP_404_NOTFOUND_LEN,
+               HTTP_405_NOTALLOWED.as_ptr(),
+               response_buffer,
+               HTTP_405_NOTALLOWED_LEN,
             );
-            return HTTP_404_NOTFOUND_LEN;
+            HTTP_405_NOTALLOWED_LEN
          }
       } else {
-         std::ptr::copy_nonoverlapping(
-            HTTP_405_NOTALLOWED.as_ptr(),
-            response_buffer.as_mut_ptr(),
-            HTTP_405_NOTALLOWED_LEN,
-         );
-         return HTTP_405_NOTALLOWED_LEN;
+         0
       }
-   };
-
-   0
+   }
 }
 
 #[inline]