Browse Source

removed project unloaded event from client web view editor since it will never be called. All of the editors will be shut down before they have a chance to do anything.

Shaddock Heath 9 years ago
parent
commit
265df4299e

+ 0 - 6
Data/AtomicEditor/CodeEditor/Editor.html

@@ -55,12 +55,6 @@
         });
     }
 
-    function HOST_projectUnloaded() {
-        System.import('./source/editorCore/interop').then((module) => {
-            module.default.getInstance().projectUnloaded();
-        });
-    }
-
     function HOST_resourceRenamed(path, newPath) {
         System.import('./source/editorCore/interop').then((module) => {
             module.default.getInstance().resourceRenamed(path, newPath);

+ 0 - 1
Script/AtomicWebViewEditor/clientExtensions/ClientExtensionEventNames.ts

@@ -29,6 +29,5 @@ export default class ClientExtensionEventNames {
     static CodeSavedEvent = "CodeSavedEvent";
     static ResourceRenamedEvent = "ResourceRenamedEvent";
     static ResourceDeletedEvent = "ResourceDeletedEvent";
-    static ProjectUnloadedEvent = "ProjectUnloadedEvent";
     static PreferencesChangedEvent = "PreferencesChangedEvent";
 }

+ 0 - 18
Script/AtomicWebViewEditor/clientExtensions/ClientExtensionServices.ts

@@ -95,7 +95,6 @@ export class WebViewServicesProvider extends ServicesProvider<Editor.ClientExten
         eventDispatcher.subscribeToEvent(ClientExtensionEventNames.CodeLoadedEvent, (ev) => this.codeLoaded(ev));
         eventDispatcher.subscribeToEvent(ClientExtensionEventNames.ConfigureEditorEvent, (ev) => this.configureEditor(ev));
         eventDispatcher.subscribeToEvent(ClientExtensionEventNames.ResourceRenamedEvent, (ev) => this.renameResource(ev));
-        eventDispatcher.subscribeToEvent(ClientExtensionEventNames.ProjectUnloadedEvent, (ev) => this.projectUnloaded());
         eventDispatcher.subscribeToEvent(ClientExtensionEventNames.ResourceDeletedEvent, (ev) => this.deleteResource(ev));
         eventDispatcher.subscribeToEvent(ClientExtensionEventNames.CodeSavedEvent, (ev) => this.saveCode(ev));
         eventDispatcher.subscribeToEvent(ClientExtensionEventNames.PreferencesChangedEvent, (ev) => this.preferencesChanged());
@@ -186,23 +185,6 @@ export class WebViewServicesProvider extends ServicesProvider<Editor.ClientExten
         });
     }
 
-
-    /**
-     * Called when the project is unloaded
-     */
-    projectUnloaded() {
-        this.registeredServices.forEach((service) => {
-            // Notify services that the project has been unloaded
-            try {
-                if (service.projectUnloaded) {
-                    service.projectUnloaded();
-                }
-            } catch (e) {
-                alert(`Extension Error:\n Error detected in extension ${service.name}\n \n ${e.stack}`);
-            }
-        });
-    }
-
     /**
      * Called when preferences changes
      * @param  {Editor.EditorEvents.PreferencesChangedEvent} ev

+ 0 - 16
Script/AtomicWebViewEditor/clientExtensions/languageExtensions/typescript/TypescriptLanguageExtension.ts

@@ -286,22 +286,6 @@ export default class TypescriptLanguageExtension implements Editor.ClientExtensi
         }
     }
 
-    /**
-     * Handle when the project is unloaded so that resources can be freed
-     */
-    projectUnloaded() {
-        if (this.worker) {
-
-            console.log(`${this.name}: received a project unloaded event`);
-
-            const message: WorkerProcessTypes.WorkerProcessMessageData = {
-                command: ClientExtensionEventNames.ProjectUnloadedEvent
-            };
-
-            this.worker.port.postMessage(message);
-        }
-    }
-
     /**
      * Called when the user preferences have been changed (or initially loaded)
      * @return {[type]}

+ 0 - 11
Script/AtomicWebViewEditor/clientExtensions/languageExtensions/typescript/workerprocess/TypescriptLanguageServiceWebWorker.ts

@@ -177,9 +177,6 @@ export default class TypescriptLanguageServiceWebWorker {
                 case ClientExtensionEventNames.ResourceDeletedEvent:
                     this.handleDelete(port, e.data);
                     break;
-                case ClientExtensionEventNames.ProjectUnloadedEvent:
-                    this.handleProjectUnloaded(port);
-                    break;
                 case WorkerProcessTypes.GetAnnotations:
                     this.handleGetAnnotations(port, e.data);
                     break;
@@ -363,12 +360,4 @@ export default class TypescriptLanguageServiceWebWorker {
     handleRename(port: MessagePort, eventData: WorkerProcessTypes.RenameMessageData) {
         this.languageService.renameProjectFile(eventData.path, eventData.newPath);
     }
-
-    /**
-     * Called when the project has been closed
-     * @param  {MessagePort} port
-     */
-    handleProjectUnloaded(port: MessagePort) {
-        this.reset();
-    }
 }

+ 0 - 7
Script/AtomicWebViewEditor/editor/editorCommands.ts

@@ -77,13 +77,6 @@ export function loadCodeIntoEditor(code: string, filename: string, fileExt: stri
 
 }
 
-/**
- * Called when the project is getting unloaded
- */
-export function projectUnloaded() {
-    serviceLocator.sendEvent(ClientExtensionEventNames.ProjectUnloadedEvent, null);
-}
-
 /**
  * Called when a resource is getting renamed
  * @param  {string} path

+ 1 - 7
Script/AtomicWebViewEditor/interop.ts

@@ -183,13 +183,6 @@ export default class HostInteropType {
         });
     }
 
-    /**
-     * Notify that the project has been unloaded
-     */
-    projectUnloaded() {
-        editorCommands.projectUnloaded();
-    }
-
     /**
      * Notify that a resource has been renamed
      * @param  {string} path
@@ -205,6 +198,7 @@ export default class HostInteropType {
      * @param  {string} path
      */
     resourceDeleted(path: string) {
+        console.log(path);
         editorCommands.resourceDeleted(path);
     }
 

+ 0 - 1
Script/AtomicWebViewEditor/typings/WindowExt.d.ts

@@ -28,7 +28,6 @@ interface Window {
     HOST_loadCode: (codeUrl) => void;
     HOST_saveCode: () => void;
 
-    HOST_projectUnloaded: () => void;
     HOST_resourceRenamed: (path: string, newPath: string) => void;
     HOST_resourceDeleted: (path: string) => void;
     HOST_loadPreferences: (path: string) => void;