noConditionalAssignmentRule.js 2.9 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869
  1. "use strict";
  2. var __extends = (this && this.__extends) || function (d, b) {
  3. for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p];
  4. function __() { this.constructor = d; }
  5. d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
  6. };
  7. var ts = require("typescript");
  8. var Lint = require("../lint");
  9. var Rule = (function (_super) {
  10. __extends(Rule, _super);
  11. function Rule() {
  12. _super.apply(this, arguments);
  13. }
  14. Rule.prototype.apply = function (sourceFile) {
  15. var walker = new NoConditionalAssignmentWalker(sourceFile, this.getOptions());
  16. return this.applyWithWalker(walker);
  17. };
  18. Rule.FAILURE_STRING = "assignment in conditional: ";
  19. return Rule;
  20. }(Lint.Rules.AbstractRule));
  21. exports.Rule = Rule;
  22. var NoConditionalAssignmentWalker = (function (_super) {
  23. __extends(NoConditionalAssignmentWalker, _super);
  24. function NoConditionalAssignmentWalker() {
  25. _super.apply(this, arguments);
  26. this.isInConditional = false;
  27. }
  28. NoConditionalAssignmentWalker.prototype.visitIfStatement = function (node) {
  29. this.validateConditionalExpression(node.expression);
  30. _super.prototype.visitIfStatement.call(this, node);
  31. };
  32. NoConditionalAssignmentWalker.prototype.visitWhileStatement = function (node) {
  33. this.validateConditionalExpression(node.expression);
  34. _super.prototype.visitWhileStatement.call(this, node);
  35. };
  36. NoConditionalAssignmentWalker.prototype.visitDoStatement = function (node) {
  37. this.validateConditionalExpression(node.expression);
  38. _super.prototype.visitWhileStatement.call(this, node);
  39. };
  40. NoConditionalAssignmentWalker.prototype.visitForStatement = function (node) {
  41. if (node.condition != null) {
  42. this.validateConditionalExpression(node.condition);
  43. }
  44. _super.prototype.visitForStatement.call(this, node);
  45. };
  46. NoConditionalAssignmentWalker.prototype.visitBinaryExpression = function (expression) {
  47. if (this.isInConditional) {
  48. this.checkForAssignment(expression);
  49. }
  50. _super.prototype.visitBinaryExpression.call(this, expression);
  51. };
  52. NoConditionalAssignmentWalker.prototype.validateConditionalExpression = function (expression) {
  53. this.isInConditional = true;
  54. if (expression.kind === ts.SyntaxKind.BinaryExpression) {
  55. this.checkForAssignment(expression);
  56. }
  57. this.walkChildren(expression);
  58. this.isInConditional = false;
  59. };
  60. NoConditionalAssignmentWalker.prototype.checkForAssignment = function (expression) {
  61. if (isAssignmentToken(expression.operatorToken)) {
  62. this.addFailure(this.createFailure(expression.getStart(), expression.getWidth(), Rule.FAILURE_STRING));
  63. }
  64. };
  65. return NoConditionalAssignmentWalker;
  66. }(Lint.RuleWalker));
  67. function isAssignmentToken(token) {
  68. return token.kind >= ts.SyntaxKind.FirstAssignment && token.kind <= ts.SyntaxKind.LastAssignment;
  69. }