Browse Source

Fixed an issue where removing a light would incorrectly remove a renderable

Marko Pintera 10 years ago
parent
commit
62f531ad05
2 changed files with 6 additions and 8 deletions
  1. 2 3
      RenderBeast/Source/BsRenderBeast.cpp
  2. 4 5
      TODO.txt

+ 2 - 3
RenderBeast/Source/BsRenderBeast.cpp

@@ -234,9 +234,8 @@ namespace BansheeEngine
 		}
 		}
 
 
 		// Last element is the one we want to erase
 		// Last element is the one we want to erase
-		mRenderables.erase(mRenderables.end() - 1);
-		mWorldBounds.erase(mWorldBounds.end() - 1);
-		mWorldTransforms.erase(mWorldTransforms.end() - 1);
+		mLights.erase(mLights.end() - 1);
+		mLightWorldBounds.erase(mLightWorldBounds.end() - 1);
 	}
 	}
 
 
 	void RenderBeast::_notifyCameraAdded(const CameraHandlerCore* camera)
 	void RenderBeast::_notifyCameraAdded(const CameraHandlerCore* camera)

+ 4 - 5
TODO.txt

@@ -53,12 +53,10 @@ Code quality improvements:
 Polish
 Polish
 
 
 Test:
 Test:
- - If level load works by doing main menu -> Load
- - If level prefab instantiation works by dragging it from project to scene
- - Loaded scene doesn't display the mesh
-   - Presumably this is because we construct that mesh manually without persisting its resources (it should work if level is saved and loaded during the same run)
+ - Saving a scene seems to create another (unselectable) copy of the dragon mesh
+ - Loading a saved level doesn't seem to persist scene object positions
  - Loaded scene test component has empty values
  - Loaded scene test component has empty values
- - Finish up ScriptScene.Load - it doesn't work when given relative paths
+ - Loading a scene multiple times causes an exception when updating Renderables in scene manager
 
 
 Ribek use:
 Ribek use:
  - Hook up color picker to guicolor field
  - Hook up color picker to guicolor field
@@ -131,6 +129,7 @@ Finalizing:
   - There should be a CmdRecordSO equivalent for resources (probably)
   - There should be a CmdRecordSO equivalent for resources (probably)
   - Add commands for breaking or reverting a scene object 
   - Add commands for breaking or reverting a scene object 
   - Test & finalize undo/redo system
   - Test & finalize undo/redo system
+  - When opening editor load last open scene
 
 
 ----------------------------------------------------------------------
 ----------------------------------------------------------------------
 Build system
 Build system