Fixed constant unnecessary GUI updates

Fixed C# inspectable objects getting created and immediately updated

BansheeEditor/Source/BsMainEditorWindow.cpp

@@ -79,8 +79,8 @@ namespace BansheeEngine
 		AABox dbgBox(Vector3(-300, -200, 1000), Vector3(300, 300, 1500));
 		//DrawHelper3D::instance().drawAABox(sceneCamera, dbgBox, Color::Green, 250.0f);
 
-		mProfilerOverlay = mSceneObject->addComponent<ProfilerOverlay>(sceneCamera->getViewport());
-		mProfilerOverlay->show(ProfilerOverlayType::CPUSamples);
+		//mProfilerOverlay = mSceneObject->addComponent<ProfilerOverlay>(sceneCamera->getViewport());
+		//mProfilerOverlay->show(ProfilerOverlayType::CPUSamples);
 
 		TestSuitePtr testSuite = TestSuite::create<EditorTestSuite>();
 		testSuite->run(ExceptionTestOutput());

BansheeEngine/Include/BsGUIElementBase.h

@@ -167,14 +167,14 @@ namespace BansheeEngine
 		 *
 		 * @note	Internal method.
 		 */
-		bool _isContentDirty() const;
+		virtual bool _isContentDirty() const;
 
 		/**
 		 * @brief	Returns true if mesh has changed and fillBuffers needs to be called.
 		 *
 		 * @note	Internal method.
 		 */
-		bool _isMeshDirty() const; 
+		virtual bool _isMeshDirty() const; 
 
 		/**
 		 * @brief	Returns true if element is disabled and won't be visible or interactable.

BansheeEngine/Include/BsGUISpace.h

@@ -43,6 +43,16 @@ namespace BansheeEngine
 		 */
 		virtual Vector2I _calculateOptimalLayoutSize() const { return _getOptimalSize(); }
 
+		/**
+		 * @copydoc	GUIElementBase::_isContentDirty
+		 */
+		virtual bool _isContentDirty() const { return false; }
+
+		/**
+		 * @copydoc	GUIElementBase::_isMeshDirty
+		 */
+		virtual bool _isMeshDirty() const { return false; }
+
 		/**
 		 * @copydoc	GUIElementBase::_getPadding
 		 */
@@ -90,6 +100,16 @@ namespace BansheeEngine
 		 */
 		virtual Vector2I _calculateOptimalLayoutSize() const { return _getOptimalSize(); }
 
+		/**
+		 * @copydoc	GUIElementBase::_isContentDirty
+		 */
+		virtual bool _isContentDirty() const { return false; }
+
+		/**
+		 * @copydoc	GUIElementBase::_isMeshDirty
+		 */
+		virtual bool _isMeshDirty() const { return false; }
+
 		/**
 		 * @copydoc	GUIElementBase::_getPadding
 		 */

BansheeEngine/Source/BsGUIElement.cpp

@@ -15,10 +15,7 @@ namespace BansheeEngine
 	}
 
 	GUIElement::~GUIElement()
-	{
-		if(mParentElement != nullptr)
-			mParentElement->_unregisterChildElement(this);
-	}
+	{ }
 
 	void GUIElement::updateRenderElements()
 	{
@@ -301,6 +298,9 @@ namespace BansheeEngine
 		if(element->mParentWidget != nullptr)
 			element->mParentWidget->unregisterElement(element);
 
+		if (element->mParentElement != nullptr)
+			element->mParentElement->_unregisterChildElement(element);
+
 		element->mIsDestroyed = true;
 
 		GUIManager::instance().queueForDestroy(element);

BansheeEngine/Source/BsGUIElementBase.cpp

@@ -15,12 +15,12 @@ namespace BansheeEngine
 
 	GUIElementBase::~GUIElementBase()
 	{
-		for (auto& child : mChildren)
+		Vector<GUIElementBase*> childCopy = mChildren;
+		for (auto& child : childCopy)
 		{
 			if (child->_getType() == GUIElementBase::Type::Element)
 			{
 				GUIElement* element = static_cast<GUIElement*>(child);
-				element->_setParent(nullptr);
 				GUIElement::destroy(element);
 			}
 			else

MBansheeEditor/Inspector/InspectableArray.cs

@@ -51,7 +51,7 @@ namespace BansheeEditor
 
         private const int IndentAmount = 15;
 
-        private object oldPropertyValue; // TODO - This will unnecessarily hold references to the object
+        private object propertyValue; // TODO - This will unnecessarily hold references to the object
         private int numArrayElements;
 
         private List<EntryRow> rows = new List<EntryRow>();
@@ -71,12 +71,8 @@ namespace BansheeEditor
                 return true;
 
             object newPropertyValue = property.GetValue<object>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             if (newPropertyValue != null)
             {
@@ -103,7 +99,8 @@ namespace BansheeEditor
 
             layout.DestroyElements();
 
-            if (property.GetValue<object>() == null)
+            propertyValue = property.GetValue<object>();
+            if (propertyValue == null)
             {
                 GUILayoutX guiChildLayout = layout.AddLayoutX(layoutIndex);
 

MBansheeEditor/Inspector/InspectableBool.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableBool : InspectableObjectBase
     {
-        private bool oldPropertyValue;
+        private bool propertyValue;
         private GUIToggleField guiField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             bool newPropertyValue = property.GetValue<bool>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -55,8 +51,9 @@ namespace BansheeEditor
             if (!isInitialized)
                 Initialize(layoutIndex);
 
+            propertyValue = property.GetValue<bool>();
             if (guiField != null)
-                guiField.Value = property.GetValue<bool>();
+                guiField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(bool newValue)

MBansheeEditor/Inspector/InspectableColor.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableColor : InspectableObjectBase
     {
-        private Color oldPropertyValue;
+        private Color propertyValue;
         private GUIColorField guiField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             Color newPropertyValue = property.GetValue<Color>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -57,8 +53,9 @@ namespace BansheeEditor
 
             // TODO - Skip update if it currently has input focus so user can modify the value in peace
 
+            propertyValue = property.GetValue<Color>();
             if (guiField != null)
-                guiField.Value = property.GetValue<Color>();
+                guiField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(Color newValue)

MBansheeEditor/Inspector/InspectableFloat.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableFloat : InspectableObjectBase
     {
-        private float oldPropertyValue;
+        private float propertyValue;
         private GUIFloatField guiFloatField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             float newPropertyValue = property.GetValue<float>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -57,8 +53,9 @@ namespace BansheeEditor
 
             // TODO - Skip update if it currently has input focus so user can modify the value in peace
 
+            propertyValue = property.GetValue<float>();
             if (guiFloatField != null)
-                guiFloatField.Value = property.GetValue<float>();
+                guiFloatField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(float newValue)

MBansheeEditor/Inspector/InspectableGameObjectRef.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableGameObjectRef : InspectableObjectBase
     {
-        private GameObject oldPropertyValue;
+        private GameObject propertyValue;
         private GUIGameObjectField guiField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             GameObject newPropertyValue = property.GetValue<GameObject>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -55,8 +51,9 @@ namespace BansheeEditor
             if (!isInitialized)
                 Initialize(layoutIndex);
 
+            propertyValue = property.GetValue<GameObject>();
             if (guiField != null)
-                guiField.Value = property.GetValue<GameObject>();
+                guiField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(GameObject newValue)

MBansheeEditor/Inspector/InspectableInt.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableInt : InspectableObjectBase
     {
-        private int oldPropertyValue;
+        private int propertyValue;
         private GUIIntField guiIntField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             int newPropertyValue = property.GetValue<int>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -57,8 +53,9 @@ namespace BansheeEditor
 
             // TODO - Skip update if it currently has input focus so user can modify the value in peace
 
+            propertyValue = property.GetValue<int>();
             if(guiIntField != null)
-                guiIntField.Value = property.GetValue<int>();
+                guiIntField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(int newValue)

MBansheeEditor/Inspector/InspectableList.cs

@@ -51,7 +51,7 @@ namespace BansheeEditor
 
         private const int IndentAmount = 15;
 
-        private object oldPropertyValue; // TODO - This will unnecessarily hold references to the object
+        private object propertyValue; // TODO - This will unnecessarily hold references to the object
         private int numArrayElements;
 
         private GUIIntField guiSizeField;
@@ -71,12 +71,8 @@ namespace BansheeEditor
                 return true;
 
             object newPropertyValue = property.GetValue<object>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             if (newPropertyValue != null)
             {
@@ -102,7 +98,8 @@ namespace BansheeEditor
 
             rows.Clear();
 
-            if (property.GetValue<object>() == null)
+            propertyValue = property.GetValue<object>();
+            if (propertyValue == null)
             {
                 GUILayoutX guiChildLayout = layout.AddLayoutX(layoutIndex);
 

MBansheeEditor/Inspector/InspectableObject.cs

@@ -11,7 +11,7 @@ namespace BansheeEditor
     {
         private const int IndentAmount = 15;
 
-        private object oldPropertyValue;
+        private object propertyValue;
         private bool isInitialized;
 
         public InspectableObject(string title, InspectableFieldLayout layout, SerializableProperty property)
@@ -26,12 +26,8 @@ namespace BansheeEditor
                 return true;
 
             object newPropertyValue = property.GetValue<object>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -46,7 +42,8 @@ namespace BansheeEditor
 
             layout.DestroyElements();
 
-            if (property.GetValue<object>() == null)
+            propertyValue = property.GetValue<object>();
+            if (propertyValue == null)
             {
                 GUILayoutX guiChildLayout = layout.AddLayoutX(index);
 

MBansheeEditor/Inspector/InspectableResourceRef.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableResourceRef : InspectableObjectBase
     {
-        private Resource oldPropertyValue;
+        private Resource propertyValue;
         private GUIResourceField guiField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             Resource newPropertyValue = property.GetValue<Resource>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -55,8 +51,9 @@ namespace BansheeEditor
             if (!isInitialized)
                 Initialize(layoutIndex);
 
+            propertyValue = property.GetValue<Resource>();
             if (guiField != null)
-                guiField.Value = property.GetValue<Resource>();
+                guiField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(Resource newValue)

MBansheeEditor/Inspector/InspectableString.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableString : InspectableObjectBase
     {
-        private string oldPropertyValue;
+        private string propertyValue;
         private GUITextField guiField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             string newPropertyValue = property.GetValue<string>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -57,8 +53,9 @@ namespace BansheeEditor
 
             // TODO - Skip update if it currently has input focus so user can modify the value in peace
 
+            propertyValue = property.GetValue<string>();
             if (guiField != null)
-                guiField.Value = property.GetValue<string>();
+                guiField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(string newValue)

MBansheeEditor/Inspector/InspectableVector2.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableVector2 : InspectableObjectBase
     {
-        private Vector2 oldPropertyValue;
+        private Vector2 propertyValue;
         private GUIVector2Field guiField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             Vector2 newPropertyValue = property.GetValue<Vector2>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -57,8 +53,9 @@ namespace BansheeEditor
 
             // TODO - Skip update if it currently has input focus so user can modify the value in peace
 
+            propertyValue = property.GetValue<Vector2>();
             if (guiField != null)
-                guiField.Value = property.GetValue<Vector2>();
+                guiField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(Vector2 newValue)

MBansheeEditor/Inspector/InspectableVector3.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableVector3 : InspectableObjectBase
     {
-        private Vector3 oldPropertyValue;
+        private Vector3 propertyValue;
         private GUIVector3Field guiField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             Vector3 newPropertyValue = property.GetValue<Vector3>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -57,8 +53,9 @@ namespace BansheeEditor
 
             // TODO - Skip update if it currently has input focus so user can modify the value in peace
 
+            propertyValue = property.GetValue<Vector3>();
             if (guiField != null)
-                guiField.Value = property.GetValue<Vector3>();
+                guiField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(Vector3 newValue)

MBansheeEditor/Inspector/InspectableVector4.cs

@@ -9,7 +9,7 @@ namespace BansheeEditor
 {
     public class InspectableVector4 : InspectableObjectBase
     {
-        private Vector4 oldPropertyValue;
+        private Vector4 propertyValue;
         private GUIVector4Field guiField;
         private bool isInitialized;
 
@@ -38,12 +38,8 @@ namespace BansheeEditor
                 return true;
 
             Vector4 newPropertyValue = property.GetValue<Vector4>();
-            if (oldPropertyValue != newPropertyValue)
-            {
-                oldPropertyValue = newPropertyValue;
-
+            if (propertyValue != newPropertyValue)
                 return true;
-            }
 
             return base.IsModified();
         }
@@ -57,8 +53,9 @@ namespace BansheeEditor
 
             // TODO - Skip update if it currently has input focus so user can modify the value in peace
 
+            propertyValue = property.GetValue<Vector4>();
             if (guiField != null)
-                guiField.Value = property.GetValue<Vector4>();
+                guiField.Value = propertyValue;
         }
 
         private void OnFieldValueChanged(Vector4 newValue)