Browse Source

Sonar fix: prefer range based for loop (#1151)

Jorrit Rouwe 1 year ago
parent
commit
78af2562cb
2 changed files with 4 additions and 4 deletions
  1. 2 2
      Jolt/Core/Array.h
  2. 2 2
      Jolt/Core/StaticArray.h

+ 2 - 2
Jolt/Core/Array.h

@@ -194,8 +194,8 @@ public:
 		clear();
 		clear();
 		reserve(size_type(inList.size()));
 		reserve(size_type(inList.size()));
 
 
-		for (typename std::initializer_list<T>::iterator i = inList.begin(); i != inList.end(); ++i)
-			::new (&mElements[mSize++]) T(*i);
+		for (const T &v : inList)
+			::new (&mElements[mSize++]) T(v);
 	}
 	}
 
 
 	/// Default constructor
 	/// Default constructor

+ 2 - 2
Jolt/Core/StaticArray.h

@@ -26,8 +26,8 @@ public:
 	explicit			StaticArray(std::initializer_list<T> inList)
 	explicit			StaticArray(std::initializer_list<T> inList)
 	{
 	{
 		JPH_ASSERT(inList.size() <= N);
 		JPH_ASSERT(inList.size() <= N);
-		for (typename std::initializer_list<T>::iterator i = inList.begin(); i != inList.end(); ++i)
-			::new (reinterpret_cast<T *>(&mElements[mSize++])) T(*i);
+		for (const T &v : inList)
+			::new (reinterpret_cast<T *>(&mElements[mSize++])) T(v);
 	}
 	}
 
 
 	/// Copy constructor
 	/// Copy constructor