Browse Source

Sonar fixes

Jorrit Rouwe 8 months ago
parent
commit
7cd420716e

+ 1 - 1
Jolt/ObjectStream/ObjectStreamIn.cpp

@@ -304,7 +304,7 @@ bool ObjectStreamIn::ReadRTTI()
 			for (int idx = 0; idx < rtti->GetAttributeCount(); ++idx)
 			for (int idx = 0; idx < rtti->GetAttributeCount(); ++idx)
 			{
 			{
 				const SerializableAttribute &attr = rtti->GetAttribute(idx);
 				const SerializableAttribute &attr = rtti->GetAttribute(idx);
-				if (strcmp(attr.GetName(), attribute_name.c_str()) == 0)
+				if (attribute_name.compare(attr.GetName()) == 0)
 				{
 				{
 					attribute.mIndex = idx;
 					attribute.mIndex = idx;
 					break;
 					break;

+ 1 - 1
Jolt/Physics/Collision/Shape/BoxShape.cpp

@@ -278,7 +278,7 @@ void BoxShape::CollideSoftBodyVertices(Mat44Arg inCenterOfMassTransform, Vec3Arg
 
 
 void BoxShape::GetTrianglesStart(GetTrianglesContext &ioContext, const AABox &inBox, Vec3Arg inPositionCOM, QuatArg inRotation, Vec3Arg inScale) const
 void BoxShape::GetTrianglesStart(GetTrianglesContext &ioContext, const AABox &inBox, Vec3Arg inPositionCOM, QuatArg inRotation, Vec3Arg inScale) const
 {
 {
-	new (&ioContext) GetTrianglesContextVertexList(inPositionCOM, inRotation, inScale, Mat44::sScale(mHalfExtent), sUnitBoxTriangles, sizeof(sUnitBoxTriangles) / sizeof(Vec3), GetMaterial());
+	new (&ioContext) GetTrianglesContextVertexList(inPositionCOM, inRotation, inScale, Mat44::sScale(mHalfExtent), sUnitBoxTriangles, std::size(sUnitBoxTriangles), GetMaterial());
 }
 }
 
 
 int BoxShape::GetTrianglesNext(GetTrianglesContext &ioContext, int inMaxTrianglesRequested, Float3 *outTriangleVertices, const PhysicsMaterial **outMaterials) const
 int BoxShape::GetTrianglesNext(GetTrianglesContext &ioContext, int inMaxTrianglesRequested, Float3 *outTriangleVertices, const PhysicsMaterial **outMaterials) const

+ 1 - 1
Jolt/Physics/Collision/Shape/HeightFieldShape.cpp

@@ -1710,7 +1710,7 @@ public:
 	JPH_INLINE explicit			DecodingContext(const HeightFieldShape *inShape) :
 	JPH_INLINE explicit			DecodingContext(const HeightFieldShape *inShape) :
 		mShape(inShape)
 		mShape(inShape)
 	{
 	{
-		static_assert(sizeof(sGridOffsets) / sizeof(uint) == cNumBitsXY + 1, "Offsets array is not long enough");
+		static_assert(std::size(sGridOffsets) == cNumBitsXY + 1, "Offsets array is not long enough");
 
 
 		// Construct root stack entry
 		// Construct root stack entry
 		mPropertiesStack[0] = 0; // level: 0, x: 0, y: 0
 		mPropertiesStack[0] = 0; // level: 0, x: 0, y: 0