Adding unit tests to get more coverage

UnitTests/Math/DMat44Tests.cpp

@@ -7,6 +7,16 @@
 
 TEST_SUITE("DMat44Tests")
 {
+	TEST_CASE("TestDMat44Zero")
+	{
+		DMat44 zero = DMat44::sZero();
+
+		CHECK(zero.GetAxisX() == Vec3::sZero());
+		CHECK(zero.GetAxisY() == Vec3::sZero());
+		CHECK(zero.GetAxisZ() == Vec3::sZero());
+		CHECK(zero.GetTranslation() == DVec3::sZero());
+	}
+
 	TEST_CASE("TestDMat44Identity")
 	{
 		DMat44 identity = DMat44::sIdentity();
@@ -42,6 +52,15 @@ TEST_SUITE("DMat44Tests")
 		CHECK(mat.GetRotation() == Mat44(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(0, 0, 0, 1)));
 	}
 
+	TEST_CASE("TestMat44SetRotation")
+	{
+		DMat44 mat(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), DVec3(13, 14, 15));
+		Mat44 mat2(Vec4(17, 18, 19, 20), Vec4(21, 22, 23, 24), Vec4(25, 26, 27, 28), Vec4(29, 30, 31, 32));
+
+		mat.SetRotation(mat2);
+		CHECK(mat == DMat44(Vec4(17, 18, 19, 20), Vec4(21, 22, 23, 24), Vec4(25, 26, 27, 28), DVec3(13, 14, 15)));
+	}
+
 	TEST_CASE("TestDMat44MultiplyMat44")
 	{
 		DMat44 mat(Vec4(1, 2, 3, 0), Vec4(5, 6, 7, 0), Vec4(9, 10, 11, 0), DVec3(13, 14, 15));

UnitTests/Math/Mat44Tests.cpp

@@ -7,6 +7,24 @@
 
 TEST_SUITE("Mat44Tests")
 {
+	TEST_CASE("TestMat44Zero")
+	{
+		Mat44 zero = Mat44::sZero();
+
+		for (int row = 0; row < 4; ++row)
+			for (int col = 0; col < 4; ++col)
+				CHECK(zero(row, col) == 0.0f);
+	}
+
+	TEST_CASE("TestMat44NaN")
+	{
+		Mat44 nan = Mat44::sNaN();
+
+		for (int row = 0; row < 4; ++row)
+			for (int col = 0; col < 4; ++col)
+				CHECK(isnan(nan(row, col)));
+	}
+
 	TEST_CASE("TestMat44Identity")
 	{
 		Mat44 identity = Mat44::sIdentity();
@@ -64,6 +82,31 @@ TEST_SUITE("Mat44Tests")
 		CHECK(mat2(1, 3) == 14.0f);
 		CHECK(mat2(2, 3) == 15.0f);
 		CHECK(mat2(3, 3) == 16.0f);
+
+		// Check equal
+		CHECK(mat == mat2);
+		CHECK(!(mat != mat2));
+
+		// Make unequal
+		mat(3, 3) = 1;
+
+		// Check non-equal
+		CHECK(!(mat == mat2));
+		CHECK(mat != mat2);
+	}
+
+	TEST_CASE("TestMat44IsClose")
+	{
+		Mat44 mat = Mat44::sIdentity();
+		Mat44 mat2(mat);
+
+		CHECK(mat.IsClose(mat2, Square(0.1f)));
+
+		mat2(0, 1) = 0.09f;
+		CHECK(mat.IsClose(mat2, Square(0.1f)));
+
+		mat2(0, 1) = 0.11f;
+		CHECK(!mat.IsClose(mat2, Square(0.1f)));
 	}
 
 	TEST_CASE("TestMat44Translation")
@@ -77,6 +120,21 @@ TEST_SUITE("Mat44Tests")
 		CHECK(Mat44::sScale(Vec3(2, 3, 4)) == Mat44(Vec4(2, 0, 0, 0), Vec4(0, 3, 0, 0), Vec4(0, 0, 4, 0), Vec4(0, 0, 0, 1)));
 	}
 
+	TEST_CASE("TestMat44Rotation")
+	{
+		Mat44 mat(Vec4(1, 2, 3, 0), Vec4(5, 6, 7, 0), Vec4(9, 10, 11, 0), Vec4(13, 14, 15, 16));
+		CHECK(mat.GetRotation() == Mat44(Vec4(1, 2, 3, 0), Vec4(5, 6, 7, 0), Vec4(9, 10, 11, 0), Vec4(0, 0, 0, 1)));
+	}
+
+	TEST_CASE("TestMat44SetRotation")
+	{
+		Mat44 mat(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(13, 14, 15, 16));
+		Mat44 mat2(Vec4(17, 18, 19, 20), Vec4(21, 22, 23, 24), Vec4(25, 26, 27, 28), Vec4(29, 30, 31, 32));
+
+		mat.SetRotation(mat2);
+		CHECK(mat == Mat44(Vec4(17, 18, 19, 20), Vec4(21, 22, 23, 24), Vec4(25, 26, 27, 28), Vec4(13, 14, 15, 16)));
+	}
+
 	TEST_CASE("TestMat44RotationSafe")
 	{
 		Mat44 mat(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(13, 14, 15, 16));
@@ -114,6 +172,13 @@ TEST_SUITE("Mat44Tests")
 		CHECK(mat2 == mat);
 	}
 
+	TEST_CASE("TestMat44LoadAligned")
+	{
+		alignas(16) float values[16] = { 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16 };
+		Mat44 mat = Mat44::sLoadFloat4x4Aligned((const Float4 *)values);
+		CHECK(mat == Mat44(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(13, 14, 15, 16)));
+	}
+
 	TEST_CASE("TestMat44MultiplyMat44")
 	{
 		Mat44 mat(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(13, 14, 15, 16));
@@ -123,6 +188,35 @@ TEST_SUITE("Mat44Tests")
 		CHECK(result == Mat44(Vec4(538, 612, 686, 760), Vec4(650, 740, 830, 920), Vec4(762, 868, 974, 1080), Vec4(874, 996, 1118, 1240)));
 	}
 
+	TEST_CASE("TestMat44Add")
+	{
+		Mat44 mat(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(13, 14, 15, 16));
+		Mat44 mat2(Vec4(17, 18, 19, 20), Vec4(21, 22, 23, 24), Vec4(25, 26, 27, 28), Vec4(29, 30, 31, 32));
+
+		Mat44 result = mat + mat2;
+		CHECK(result == Mat44(Vec4(18, 20, 22, 24), Vec4(26, 28, 30, 32), Vec4(34, 36, 38, 40), Vec4(42, 44, 46, 48)));
+
+		mat += mat2;
+		CHECK(mat == Mat44(Vec4(18, 20, 22, 24), Vec4(26, 28, 30, 32), Vec4(34, 36, 38, 40), Vec4(42, 44, 46, 48)));
+	}
+
+	TEST_CASE("TestMat44Sub")
+	{
+		Mat44 mat(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(13, 14, 15, 16));
+		Mat44 mat2(Vec4(32, 31, 30, 29), Vec4(28, 27, 26, 25), Vec4(24, 23, 22, 21), Vec4(20, 19, 18, 17));
+
+		Mat44 result = mat - mat2;
+		CHECK(result == Mat44(Vec4(-31, -29, -27, -25), Vec4(-23, -21, -19, -17), Vec4(-15, -13, -11, -9), Vec4(-7, -5, -3, -1)));
+	}
+
+	TEST_CASE("TestMat44Negate")
+	{
+		Mat44 mat(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(13, 14, 15, 16));
+
+		Mat44 result = -mat;
+		CHECK(result == Mat44(Vec4(-1, -2, -3, -4), Vec4(-5, -6, -7, -8), Vec4(-9, -10, -11, -12), Vec4(-13, -14, -15, -16)));
+	}
+
 	TEST_CASE("TestMat44MultiplyVec3")
 	{
 		Mat44 mat(Vec4(1, 2, 3, 4), Vec4(5, 6, 7, 8), Vec4(9, 10, 11, 12), Vec4(13, 14, 15, 16));
@@ -347,6 +441,21 @@ TEST_SUITE("Mat44Tests")
 		CHECK_APPROX_EQUAL(m1, m2);
 	}
 
+	TEST_CASE("TestMat44Decompose")
+	{
+		Mat44 rotation = Mat44::sRotationX(0.1f * JPH_PI) * Mat44::sRotationZ(0.2f * JPH_PI);
+		Vec3 scale = Vec3(-1, 2, 3);
+		Mat44 mat = rotation * Mat44::sScale(scale);
+		CHECK(mat.GetDeterminant3x3() < 0); // Left handed
+
+		Vec3 new_scale;
+		Mat44 new_rotation = mat.Decompose(new_scale);
+		CHECK(new_rotation.GetDeterminant3x3() > 0); // Right handed
+
+		Mat44 mat2 = new_rotation * Mat44::sScale(new_scale);
+		CHECK(mat.IsClose(mat2));
+	}
+
 	TEST_CASE("TestMat44PrePostScaled")
 	{
 		Mat44 m(Vec4(2, 3, 4, 0), Vec4(5, 6, 7, 0), Vec4(8, 9, 10, 0), Vec4(11, 12, 13, 1));

UnitTests/Math/MatrixTests.cpp

@@ -7,6 +7,27 @@
 
 TEST_SUITE("MatrixTests")
 {
+	TEST_CASE("TestMatrixEquals")
+	{
+		Matrix<3, 5> m1 = Matrix<3, 5>::sZero();
+		Matrix<3, 5> m2 = Matrix<3, 5>::sZero();
+		Matrix<3, 5> m3 = Matrix<3, 5>::sIdentity();
+
+		CHECK(m1 == m2);
+		CHECK(!(m1 != m2));
+		CHECK(m1 != m3);
+		CHECK(!(m1 == m3));
+	}
+
+	TEST_CASE("TestMatrixStream")
+	{
+		Matrix<3, 5> m1 = Matrix<3, 5>::sIdentity();
+
+		std::stringstream ss;
+		ss << m1;
+		CHECK(ss.str() == "[1, 0, 0], [0, 1, 0], [0, 0, 1], [0, 0, 0], [0, 0, 0]");
+	}
+
 	TEST_CASE("TestMatrixZero")
 	{
 		Matrix<3, 5> m = Matrix<3, 5>::sZero();
@@ -69,6 +90,11 @@ TEST_SUITE("MatrixTests")
 		CHECK(inverse.SetInversed(mat));
 		Matrix<4, 4> identity = mat * inverse;
 		CHECK(identity == Matrix<4, 4>::sIdentity());
+
+		// Make non-invertible
+		mat(1, 0) = 0;
+		mat(3, 0) = 0;
+		CHECK(!inverse.SetInversed(mat));
 	}
 
 	TEST_CASE("TestMatrix22Inversed")
@@ -83,5 +109,10 @@ TEST_SUITE("MatrixTests")
 		CHECK(inverse.SetInversed(mat));
 		Matrix<2, 2> identity = mat * inverse;
 		CHECK(identity == Matrix<2, 2>::sIdentity());
+
+		// Make non-invertible
+		mat(0, 0) = 0;
+		mat(1, 0) = 0;
+		CHECK(!inverse.SetInversed(mat));
 	}
 }

UnitTests/Math/QuatTests.cpp

@@ -9,6 +9,20 @@
 
 TEST_SUITE("QuatTests")
 {
+	TEST_CASE("TestQuatSetXYZW")
+	{
+		Quat q(0, 0, 0, 0);
+		CHECK(q == Quat(0, 0, 0, 0));
+		q.SetX(1);
+		q.SetY(2);
+		q.SetZ(3);
+		q.SetW(4);
+		CHECK(q == Quat(1, 2, 3, 4));
+
+		q.Set(4, 3, 2, 1);
+		CHECK(q == Quat(4, 3, 2, 1));
+	}
+
 	TEST_CASE("TestQuatEqual")
 	{
 		CHECK(Quat(1, 2, 3, 4) == Quat(1, 2, 3, 4));

UnitTests/Math/Vec3Tests.cpp

@@ -84,6 +84,7 @@ TEST_SUITE("Vec3Tests")
 	{
 		Vec3 v1(1, 5, 3);
 		Vec3 v2(4, 2, 6);
+		Vec3 v3(6, 4, 2);
 
 		CHECK(Vec3::sMin(v1, v2) == Vec3(1, 2, 3));
 		CHECK(Vec3::sMax(v1, v2) == Vec3(4, 5, 6));
@@ -97,6 +98,8 @@ TEST_SUITE("Vec3Tests")
 		CHECK(v1.GetHighestComponentIndex() == 1);
 		CHECK(v2.GetLowestComponentIndex() == 1);
 		CHECK(v2.GetHighestComponentIndex() == 2);
+		CHECK(v3.GetLowestComponentIndex() == 2);
+		CHECK(v3.GetHighestComponentIndex() == 0);
 	}
 
 	TEST_CASE("TestVec3Clamp")

UnitTests/Math/VectorTests.cpp

@@ -7,6 +7,41 @@
 
 TEST_SUITE("VectorTests")
 {
+	TEST_CASE("TestVectorEquals")
+	{
+		Vector<3> v1;
+		v1[0] = 1;
+		v1[1] = 2;
+		v1[2] = 3;
+
+		Vector<3> v2;
+		v2[0] = 1;
+		v2[1] = 2;
+		v2[2] = 3;
+
+		Vector<3> v3;
+		v3[0] = 1;
+		v3[1] = 5;
+		v3[2] = 3;
+
+		CHECK(v1 == v2);
+		CHECK(!(v1 != v2));
+		CHECK(v1 != v3);
+		CHECK(!(v1 == v3));
+	}
+
+	TEST_CASE("TestVectorStream")
+	{
+		Vector<3> v1;
+		v1[0] = 1;
+		v1[1] = 2;
+		v1[2] = 3;
+
+		std::stringstream ss;
+		ss << v1;
+		CHECK(ss.str() == "[1, 2, 3]");
+	}
+
 	TEST_CASE("TestVectorMultiplyFloat")
 	{
 		Vector<5> v;