Browse Source

XMLNodeHandlerTabSet: 'tabs' and 'panels' should return null

Michael Ragazzon 6 years ago
parent
commit
dc37c35c0b
1 changed files with 3 additions and 4 deletions
  1. 3 4
      Source/Controls/XMLNodeHandlerTabSet.cpp

+ 3 - 4
Source/Controls/XMLNodeHandlerTabSet.cpp

@@ -113,7 +113,6 @@ Core::Element* XMLNodeHandlerTabSet::ElementStart(Core::XMLParser* parser, const
 
 
 		Core::Element* parent = parser->GetParseFrame()->element;
 		Core::Element* parent = parser->GetParseFrame()->element;
 
 
-		// Attempt to instance the element with the instancer.
 		Core::ElementPtr element = Core::Factory::InstanceElement(parent, name, name, attributes);
 		Core::ElementPtr element = Core::Factory::InstanceElement(parent, name, name, attributes);
 		if (!element)
 		if (!element)
 		{
 		{
@@ -121,9 +120,9 @@ Core::Element* XMLNodeHandlerTabSet::ElementStart(Core::XMLParser* parser, const
 			return nullptr;
 			return nullptr;
 		}
 		}
 
 
-		// Add the element to its parent and remove the initial reference.
-		Core::Element* result = parent->AppendChild(std::move(element));
-		return result;
+		parent->AppendChild(std::move(element));
+
+		return nullptr;
 	}
 	}
 
 
 	return nullptr;
 	return nullptr;