Selaa lähdekoodia

Use explicit conditional checks and update documentation URLs

Co-authored-by: djeada <[email protected]>
copilot-swe-agent[bot] 2 päivää sitten
vanhempi
sitoutus
c27af14362
2 muutettua tiedostoa jossa 3 lisäystä ja 3 poistoa
  1. 1 1
      .github/workflows/windows.yml
  2. 2 2
      docs/WINDOWS_CODE_SIGNING.md

+ 1 - 1
.github/workflows/windows.yml

@@ -124,7 +124,7 @@ jobs:
 
       # Code signing (optional: signs .exe with Authenticode)
       - name: Sign executable
-        if: ${{ secrets.WINDOWS_CERTIFICATE && secrets.WINDOWS_CERTIFICATE_PASSWORD }}
+        if: ${{ secrets.WINDOWS_CERTIFICATE != '' && secrets.WINDOWS_CERTIFICATE_PASSWORD != '' }}
         shell: pwsh
         env:
           CERT_DATA: ${{ secrets.WINDOWS_CERTIFICATE }}

+ 2 - 2
docs/WINDOWS_CODE_SIGNING.md

@@ -145,6 +145,6 @@ Potential improvements for the code signing implementation:
 
 ## References
 
-- [Microsoft SignTool Documentation](https://docs.microsoft.com/en-us/windows/win32/seccrypto/signtool)
-- [Windows Authenticode Documentation](https://docs.microsoft.com/en-us/windows-hardware/drivers/install/authenticode)
+- [Microsoft SignTool Documentation](https://learn.microsoft.com/en-us/windows/win32/seccrypto/signtool)
+- [Windows Authenticode Documentation](https://learn.microsoft.com/en-us/windows-hardware/drivers/install/authenticode)
 - [GitHub Actions Encrypted Secrets](https://docs.github.com/en/actions/security-guides/encrypted-secrets)