Browse Source

Fix some broken TRACEs and a tiny reorder in a few ifs.

Adam Ierymenko 9 năm trước cách đây
mục cha
commit
284e5d83b5
2 tập tin đã thay đổi với 5 bổ sung5 xóa
  1. 3 3
      node/Peer.cpp
  2. 2 2
      node/Switch.hpp

+ 3 - 3
node/Peer.cpp

@@ -386,7 +386,7 @@ bool Peer::validateAndSetNetworkMembershipCertificate(uint64_t nwid,const Certif
 
 	// Check signature, log and return if cert is invalid
 	if (com.signedBy() != Network::controllerFor(nwid)) {
-		TRACE("rejected network membership certificate for %.16llx signed by %s: signer not a controller of this network",(unsigned long long)_id,com.signedBy().toString().c_str());
+		TRACE("rejected network membership certificate for %.16llx signed by %s: signer not a controller of this network",(unsigned long long)nwid,com.signedBy().toString().c_str());
 		return false; // invalid signer
 	}
 
@@ -395,7 +395,7 @@ bool Peer::validateAndSetNetworkMembershipCertificate(uint64_t nwid,const Certif
 		// We are the controller: RR->identity.address() == controller() == cert.signedBy()
 		// So, verify that we signed th cert ourself
 		if (!com.verify(RR->identity)) {
-			TRACE("rejected network membership certificate for %.16llx self signed by %s: signature check failed",(unsigned long long)_id,com.signedBy().toString().c_str());
+			TRACE("rejected network membership certificate for %.16llx self signed by %s: signature check failed",(unsigned long long)nwid,com.signedBy().toString().c_str());
 			return false; // invalid signature
 		}
 
@@ -411,7 +411,7 @@ bool Peer::validateAndSetNetworkMembershipCertificate(uint64_t nwid,const Certif
 		}
 
 		if (!com.verify(signer->identity())) {
-			TRACE("rejected network membership certificate for %.16llx signed by %s: signature check failed",(unsigned long long)_id,com.signedBy().toString().c_str());
+			TRACE("rejected network membership certificate for %.16llx signed by %s: signature check failed",(unsigned long long)nwid,com.signedBy().toString().c_str());
 			return false; // invalid signature
 		}
 	}

+ 2 - 2
node/Switch.hpp

@@ -191,10 +191,10 @@ private:
 		unsigned long i = ZT_RX_QUEUE_SIZE;
 		while (i) {
 			rq = &(_rxQueue[--i]);
-			if (rq->timestamp < oldest->timestamp)
-				oldest = rq;
 			if ((rq->packetId == packetId)&&(rq->timestamp))
 				return rq;
+			if (rq->timestamp < oldest->timestamp)
+				oldest = rq;
 		}
 		return oldest;
 	}