فهرست منبع

Fix warning: suggest braces around initialization of subobject

Brenton Bostick 2 سال پیش
والد
کامیت
9ac2cfe611
1فایلهای تغییر یافته به همراه20 افزوده شده و 1 حذف شده
  1. 20 1
      java/jni/com_zerotierone_sdk_Node.cpp

+ 20 - 1
java/jni/com_zerotierone_sdk_Node.cpp

@@ -573,7 +573,26 @@ namespace {
             return true;
         }
 
-        struct sockaddr_storage nullAddress = {0};
+        //
+        // was:
+        // struct sockaddr_storage nullAddress = {0};
+        //
+        // but was getting this warning:
+        // warning: suggest braces around initialization of subobject
+        //
+        // when building ZeroTierOne
+        //
+        struct sockaddr_storage nullAddress;
+
+        //
+        // It is possible to assume knowledge about internals of sockaddr_storage and construct
+        // correct 0-initializer, but it is simpler to just treat sockaddr_storage as opaque and
+        // use memset here to fill with 0
+        //
+        // This is also done in InetAddress.hpp for InetAddress
+        //
+        memset(&nullAddress, 0, sizeof(sockaddr_storage));
+
         jobject remoteAddressObj = NULL;
 
         if(memcmp(remoteAddress, &nullAddress, sizeof(sockaddr_storage)) != 0)