Browse Source

Clean iddb.d periodically.

Adam Ierymenko 8 years ago
parent
commit
9c1a9f984b
3 changed files with 66 additions and 0 deletions
  1. 46 0
      osdep/OSUtils.cpp
  2. 10 0
      osdep/OSUtils.hpp
  3. 10 0
      service/OneService.cpp

+ 46 - 0
osdep/OSUtils.cpp

@@ -145,6 +145,52 @@ std::map<std::string,char> OSUtils::listDirectoryFull(const char *path)
 	return r;
 }
 
+long OSUtils::cleanDirectory(const char *path,const uint64_t olderThan)
+{
+	long cleaned = 0;
+
+#ifdef __WINDOWS__
+	HANDLE hFind;
+	WIN32_FIND_DATAA ffd;
+	if ((hFind = FindFirstFileA((std::string(path) + "\\*").c_str(),&ffd)) != INVALID_HANDLE_VALUE) {
+		do {
+			if ((strcmp(ffd.cFileName,"."))&&(strcmp(ffd.cFileName,".."))) {
+			}
+		} while (FindNextFileA(hFind,&ffd));
+		FindClose(hFind);
+	}
+#else
+	struct dirent de;
+	struct dirent *dptr;
+	struct stat st;
+	char tmp[4096];
+	DIR *d = opendir(path);
+	if (!d)
+		return -1;
+	dptr = (struct dirent *)0;
+	for(;;) {
+		if (readdir_r(d,&de,&dptr))
+			break;
+		if (dptr) {
+			if ((strcmp(dptr->d_name,"."))&&(strcmp(dptr->d_name,".."))&&(dptr->d_type == DT_REG)) {
+				Utils::snprintf(tmp,sizeof(tmp),"%s/%s",path,dptr->d_name);
+				if (stat(tmp,&st) == 0) {
+					uint64_t mt = (uint64_t)(st.st_mtime);
+					if ((mt > 0)&&((mt * 1000) < olderThan)) {
+						printf("%s\n",tmp);
+						if (unlink(tmp) == 0)
+							++cleaned;
+					}
+				}
+			}
+		} else break;
+	}
+	closedir(d);
+#endif
+
+	return cleaned;
+}
+
 bool OSUtils::rmDashRf(const char *path)
 {
 #ifdef __WINDOWS__

+ 10 - 0
osdep/OSUtils.hpp

@@ -119,6 +119,16 @@ public:
 	 */
 	static std::map<std::string,char> listDirectoryFull(const char *path);
 
+	/**
+	 * Clean a directory of files whose last modified time is older than this
+	 *
+	 * This ignores directories, symbolic links, and other special files.
+	 *
+	 * @param olderThan Last modified older than timestamp (ms since epoch)
+	 * @return Number of cleaned files or negative on fatal error
+	 */
+	static long cleanDirectory(const char *path,const uint64_t olderThan);
+
 	/**
 	 * Delete a directory and all its files and subdirectories recursively
 	 *

+ 10 - 0
service/OneService.cpp

@@ -147,6 +147,9 @@ namespace ZeroTier { typedef BSDEthernetTap EthernetTap; }
 // How often to check for local interface addresses
 #define ZT_LOCAL_INTERFACE_CHECK_INTERVAL 60000
 
+// Clean files from iddb.d that are older than this (60 days)
+#define ZT_IDDB_CLEANUP_AGE 5184000000ULL
+
 namespace ZeroTier {
 
 namespace {
@@ -826,6 +829,7 @@ public:
 			uint64_t lastBindRefresh = 0;
 			uint64_t lastUpdateCheck = clockShouldBe;
 			uint64_t lastLocalInterfaceAddressCheck = (clockShouldBe - ZT_LOCAL_INTERFACE_CHECK_INTERVAL) + 15000; // do this in 15s to give portmapper time to configure and other things time to settle
+			uint64_t lastCleanedIddb = 0;
 			for(;;) {
 				_run_m.lock();
 				if (!_run) {
@@ -840,6 +844,12 @@ public:
 
 				const uint64_t now = OSUtils::now();
 
+				// Clean iddb.d on start and every 24 hours
+				if ((now - lastCleanedIddb) > 86400000) {
+					lastCleanedIddb = now;
+					OSUtils::cleanDirectory((_homePath + ZT_PATH_SEPARATOR_S "iddb.d").c_str(),now - ZT_IDDB_CLEANUP_AGE);
+				}
+
 				// Attempt to detect sleep/wake events by detecting delay overruns
 				bool restarted = false;
 				if ((now > clockShouldBe)&&((now - clockShouldBe) > 10000)) {