GitHub issue #242 -- crappy uPnP protocol demands infinite lease time or else

osdep/UPNPClient.cpp

@@ -115,7 +115,7 @@ public:
 								Utils::snprintf(outport,sizeof(outport),"%u",tryPort);
 
 								int mapResult = 0;
-								if ((mapResult = UPNP_AddPortMapping(urls.controlURL,data.first.servicetype,outport,inport,lanaddr,"ZeroTier","UDP",(const char *)0,ZT_UPNP_LEASE_DURATION)) == UPNPCOMMAND_SUCCESS) {
+								if ((mapResult = UPNP_AddPortMapping(urls.controlURL,data.first.servicetype,outport,inport,lanaddr,"ZeroTier","UDP",(const char *)0,"0")) == UPNPCOMMAND_SUCCESS) {
 	#ifdef ZT_UPNP_TRACE
 									fprintf(stderr,"UPNPClient: reserved external port: %s"ZT_EOL_S,outport);
 	#endif

osdep/UPNPClient.hpp

@@ -42,11 +42,6 @@
  */
 #define ZT_UPNP_CLIENT_REFRESH_DELAY 600000
 
-/**
- * UPNP lease duration in seconds (as string)
- */
-#define ZT_UPNP_LEASE_DURATION "3600"
-
 namespace ZeroTier {
 
 class UPNPClientImpl;