Browse Source

Minor fixes

Panagiotis Christopoulos Charitos 2 years ago
parent
commit
cebb9cb797
3 changed files with 1 additions and 53 deletions
  1. 0 50
      AnKi/Core/App.cpp
  2. 0 2
      AnKi/Core/App.h
  3. 1 1
      AnKi/Gr/Vulkan/GrManagerImpl.cpp

+ 0 - 50
AnKi/Core/App.cpp

@@ -192,8 +192,6 @@ Error App::initInternal()
 	StatsSet::getSingleton().initFromMainThread();
 	Logger::getSingleton().enableVerbosity(g_verboseLogCVar.get());
 
-	setSignalHandlers();
-
 	AllocAlignedCallback allocCb = m_originalAllocCallback;
 	void* allocCbUserData = m_originalAllocUserData;
 	initMemoryCallbacks(allocCb, allocCbUserData);
@@ -559,54 +557,6 @@ void App::initMemoryCallbacks(AllocAlignedCallback& allocCb, void*& allocCbUserD
 	}
 }
 
-void App::setSignalHandlers()
-{
-	auto handler = [](int signum) -> void {
-		const char* name = nullptr;
-		switch(signum)
-		{
-		case SIGABRT:
-			name = "SIGABRT";
-			break;
-		case SIGSEGV:
-			name = "SIGSEGV";
-			break;
-#if ANKI_POSIX
-		case SIGBUS:
-			name = "SIGBUS";
-			break;
-#endif
-		case SIGILL:
-			name = "SIGILL";
-			break;
-		case SIGFPE:
-			name = "SIGFPE";
-			break;
-		}
-
-		if(name)
-			printf("Caught signal %d (%s)\n", signum, name);
-		else
-			printf("Caught signal %d\n", signum);
-
-		U32 count = 0;
-		printf("Backtrace:\n");
-		backtrace([&count](CString symbol) {
-			printf("%.2u: %s\n", count++, symbol.cstr());
-		});
-
-		ANKI_DEBUG_BREAK();
-	};
-
-	signal(SIGSEGV, handler);
-	signal(SIGILL, handler);
-	signal(SIGFPE, handler);
-#if ANKI_POSIX
-	signal(SIGBUS, handler);
-#endif
-	// Ignore for now: signal(SIGABRT, handler);
-}
-
 Bool App::toggleDeveloperConsole()
 {
 	SceneNode& node = SceneGraph::getSingleton().findSceneNode("_DevConsole");

+ 0 - 2
AnKi/Core/App.h

@@ -78,8 +78,6 @@ private:
 
 	Error initDirs();
 	void cleanup();
-
-	void setSignalHandlers();
 };
 
 } // end namespace anki

+ 1 - 1
AnKi/Gr/Vulkan/GrManagerImpl.cpp

@@ -288,7 +288,7 @@ Error GrManagerImpl::initInstance()
 		enabledValidationFeatures.emplaceBack(VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT);
 	}
 
-	if(!g_validationCVar.get())
+	if(g_debugPrintfCVar.get() && !g_validationCVar.get())
 	{
 		disabledValidationFeatures.emplaceBack(VK_VALIDATION_FEATURE_DISABLE_ALL_EXT);
 	}