validate.cpp 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447
  1. // Copyright (c) 2015-2016 The Khronos Group Inc.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. #include "source/val/validate.h"
  15. #include <algorithm>
  16. #include <cassert>
  17. #include <cstdio>
  18. #include <functional>
  19. #include <iterator>
  20. #include <memory>
  21. #include <sstream>
  22. #include <string>
  23. #include <vector>
  24. #include "source/binary.h"
  25. #include "source/diagnostic.h"
  26. #include "source/enum_string_mapping.h"
  27. #include "source/extensions.h"
  28. #include "source/instruction.h"
  29. #include "source/opcode.h"
  30. #include "source/operand.h"
  31. #include "source/spirv_constant.h"
  32. #include "source/spirv_endian.h"
  33. #include "source/spirv_target_env.h"
  34. #include "source/spirv_validator_options.h"
  35. #include "source/val/construct.h"
  36. #include "source/val/function.h"
  37. #include "source/val/instruction.h"
  38. #include "source/val/validation_state.h"
  39. #include "spirv-tools/libspirv.h"
  40. namespace {
  41. // TODO(issue 1950): The validator only returns a single message anyway, so no
  42. // point in generating more than 1 warning.
  43. static uint32_t kDefaultMaxNumOfWarnings = 1;
  44. } // namespace
  45. namespace spvtools {
  46. namespace val {
  47. namespace {
  48. // Parses OpExtension instruction and registers extension.
  49. void RegisterExtension(ValidationState_t& _,
  50. const spv_parsed_instruction_t* inst) {
  51. const std::string extension_str = spvtools::GetExtensionString(inst);
  52. Extension extension;
  53. if (!GetExtensionFromString(extension_str.c_str(), &extension)) {
  54. // The error will be logged in the ProcessInstruction pass.
  55. return;
  56. }
  57. _.RegisterExtension(extension);
  58. }
  59. // Parses the beginning of the module searching for OpExtension instructions.
  60. // Registers extensions if recognized. Returns SPV_REQUESTED_TERMINATION
  61. // once an instruction which is not SpvOpCapability and SpvOpExtension is
  62. // encountered. According to the SPIR-V spec extensions are declared after
  63. // capabilities and before everything else.
  64. spv_result_t ProcessExtensions(void* user_data,
  65. const spv_parsed_instruction_t* inst) {
  66. const SpvOp opcode = static_cast<SpvOp>(inst->opcode);
  67. if (opcode == SpvOpCapability) return SPV_SUCCESS;
  68. if (opcode == SpvOpExtension) {
  69. ValidationState_t& _ = *(reinterpret_cast<ValidationState_t*>(user_data));
  70. RegisterExtension(_, inst);
  71. return SPV_SUCCESS;
  72. }
  73. // OpExtension block is finished, requesting termination.
  74. return SPV_REQUESTED_TERMINATION;
  75. }
  76. spv_result_t ProcessInstruction(void* user_data,
  77. const spv_parsed_instruction_t* inst) {
  78. ValidationState_t& _ = *(reinterpret_cast<ValidationState_t*>(user_data));
  79. auto* instruction = _.AddOrderedInstruction(inst);
  80. _.RegisterDebugInstruction(instruction);
  81. return SPV_SUCCESS;
  82. }
  83. spv_result_t ValidateForwardDecls(ValidationState_t& _) {
  84. if (_.unresolved_forward_id_count() == 0) return SPV_SUCCESS;
  85. std::stringstream ss;
  86. std::vector<uint32_t> ids = _.UnresolvedForwardIds();
  87. std::transform(
  88. std::begin(ids), std::end(ids),
  89. std::ostream_iterator<std::string>(ss, " "),
  90. bind(&ValidationState_t::getIdName, std::ref(_), std::placeholders::_1));
  91. auto id_str = ss.str();
  92. return _.diag(SPV_ERROR_INVALID_ID, nullptr)
  93. << "The following forward referenced IDs have not been defined:\n"
  94. << id_str.substr(0, id_str.size() - 1);
  95. }
  96. // Entry point validation. Based on 2.16.1 (Universal Validation Rules) of the
  97. // SPIRV spec:
  98. // * There is at least one OpEntryPoint instruction, unless the Linkage
  99. // capability is being used.
  100. // * No function can be targeted by both an OpEntryPoint instruction and an
  101. // OpFunctionCall instruction.
  102. //
  103. // Additionally enforces that entry points for Vulkan should not have recursion.
  104. spv_result_t ValidateEntryPoints(ValidationState_t& _) {
  105. _.ComputeFunctionToEntryPointMapping();
  106. _.ComputeRecursiveEntryPoints();
  107. if (_.entry_points().empty() && !_.HasCapability(SpvCapabilityLinkage)) {
  108. return _.diag(SPV_ERROR_INVALID_BINARY, nullptr)
  109. << "No OpEntryPoint instruction was found. This is only allowed if "
  110. "the Linkage capability is being used.";
  111. }
  112. for (const auto& entry_point : _.entry_points()) {
  113. if (_.IsFunctionCallTarget(entry_point)) {
  114. return _.diag(SPV_ERROR_INVALID_BINARY, _.FindDef(entry_point))
  115. << "A function (" << entry_point
  116. << ") may not be targeted by both an OpEntryPoint instruction and "
  117. "an OpFunctionCall instruction.";
  118. }
  119. // For Vulkan, the static function-call graph for an entry point
  120. // must not contain cycles.
  121. if (spvIsVulkanEnv(_.context()->target_env)) {
  122. if (_.recursive_entry_points().find(entry_point) !=
  123. _.recursive_entry_points().end()) {
  124. return _.diag(SPV_ERROR_INVALID_BINARY, _.FindDef(entry_point))
  125. << "Entry points may not have a call graph with cycles.";
  126. }
  127. }
  128. }
  129. return SPV_SUCCESS;
  130. }
  131. spv_result_t ValidateBinaryUsingContextAndValidationState(
  132. const spv_context_t& context, const uint32_t* words, const size_t num_words,
  133. spv_diagnostic* pDiagnostic, ValidationState_t* vstate) {
  134. auto binary = std::unique_ptr<spv_const_binary_t>(
  135. new spv_const_binary_t{words, num_words});
  136. spv_endianness_t endian;
  137. spv_position_t position = {};
  138. if (spvBinaryEndianness(binary.get(), &endian)) {
  139. return DiagnosticStream(position, context.consumer, "",
  140. SPV_ERROR_INVALID_BINARY)
  141. << "Invalid SPIR-V magic number.";
  142. }
  143. spv_header_t header;
  144. if (spvBinaryHeaderGet(binary.get(), endian, &header)) {
  145. return DiagnosticStream(position, context.consumer, "",
  146. SPV_ERROR_INVALID_BINARY)
  147. << "Invalid SPIR-V header.";
  148. }
  149. if (header.version > spvVersionForTargetEnv(context.target_env)) {
  150. return DiagnosticStream(position, context.consumer, "",
  151. SPV_ERROR_WRONG_VERSION)
  152. << "Invalid SPIR-V binary version "
  153. << SPV_SPIRV_VERSION_MAJOR_PART(header.version) << "."
  154. << SPV_SPIRV_VERSION_MINOR_PART(header.version)
  155. << " for target environment "
  156. << spvTargetEnvDescription(context.target_env) << ".";
  157. }
  158. if (header.bound > vstate->options()->universal_limits_.max_id_bound) {
  159. return DiagnosticStream(position, context.consumer, "",
  160. SPV_ERROR_INVALID_BINARY)
  161. << "Invalid SPIR-V. The id bound is larger than the max id bound "
  162. << vstate->options()->universal_limits_.max_id_bound << ".";
  163. }
  164. // Look for OpExtension instructions and register extensions.
  165. // This parse should not produce any error messages. Hijack the context and
  166. // replace the message consumer so that we do not pollute any state in input
  167. // consumer.
  168. spv_context_t hijacked_context = context;
  169. hijacked_context.consumer = [](spv_message_level_t, const char*,
  170. const spv_position_t&, const char*) {};
  171. spvBinaryParse(&hijacked_context, vstate, words, num_words,
  172. /* parsed_header = */ nullptr, ProcessExtensions,
  173. /* diagnostic = */ nullptr);
  174. // Parse the module and perform inline validation checks. These checks do
  175. // not require the the knowledge of the whole module.
  176. if (auto error = spvBinaryParse(&context, vstate, words, num_words,
  177. /*parsed_header =*/nullptr,
  178. ProcessInstruction, pDiagnostic)) {
  179. return error;
  180. }
  181. std::vector<Instruction*> visited_entry_points;
  182. for (auto& instruction : vstate->ordered_instructions()) {
  183. {
  184. // In order to do this work outside of Process Instruction we need to be
  185. // able to, briefly, de-const the instruction.
  186. Instruction* inst = const_cast<Instruction*>(&instruction);
  187. if (inst->opcode() == SpvOpEntryPoint) {
  188. const auto entry_point = inst->GetOperandAs<uint32_t>(1);
  189. const auto execution_model = inst->GetOperandAs<SpvExecutionModel>(0);
  190. const char* str = reinterpret_cast<const char*>(
  191. inst->words().data() + inst->operand(2).offset);
  192. const std::string desc_name(str);
  193. ValidationState_t::EntryPointDescription desc;
  194. desc.name = desc_name;
  195. std::vector<uint32_t> interfaces;
  196. for (size_t j = 3; j < inst->operands().size(); ++j)
  197. desc.interfaces.push_back(inst->word(inst->operand(j).offset));
  198. vstate->RegisterEntryPoint(entry_point, execution_model,
  199. std::move(desc));
  200. if (visited_entry_points.size() > 0) {
  201. for (const Instruction* check_inst : visited_entry_points) {
  202. const auto check_execution_model =
  203. check_inst->GetOperandAs<SpvExecutionModel>(0);
  204. const char* check_str = reinterpret_cast<const char*>(
  205. check_inst->words().data() + inst->operand(2).offset);
  206. const std::string check_name(check_str);
  207. if (desc_name == check_name &&
  208. execution_model == check_execution_model) {
  209. return vstate->diag(SPV_ERROR_INVALID_DATA, inst)
  210. << "2 Entry points cannot share the same name and "
  211. "ExecutionMode.";
  212. }
  213. }
  214. }
  215. visited_entry_points.push_back(inst);
  216. }
  217. if (inst->opcode() == SpvOpFunctionCall) {
  218. if (!vstate->in_function_body()) {
  219. return vstate->diag(SPV_ERROR_INVALID_LAYOUT, &instruction)
  220. << "A FunctionCall must happen within a function body.";
  221. }
  222. const auto called_id = inst->GetOperandAs<uint32_t>(2);
  223. vstate->AddFunctionCallTarget(called_id);
  224. }
  225. if (vstate->in_function_body()) {
  226. inst->set_function(&(vstate->current_function()));
  227. inst->set_block(vstate->current_function().current_block());
  228. if (vstate->in_block() && spvOpcodeIsBlockTerminator(inst->opcode())) {
  229. vstate->current_function().current_block()->set_terminator(inst);
  230. }
  231. }
  232. if (auto error = IdPass(*vstate, inst)) return error;
  233. }
  234. if (auto error = CapabilityPass(*vstate, &instruction)) return error;
  235. if (auto error = ModuleLayoutPass(*vstate, &instruction)) return error;
  236. if (auto error = CfgPass(*vstate, &instruction)) return error;
  237. if (auto error = InstructionPass(*vstate, &instruction)) return error;
  238. // Now that all of the checks are done, update the state.
  239. {
  240. Instruction* inst = const_cast<Instruction*>(&instruction);
  241. vstate->RegisterInstruction(inst);
  242. if (inst->opcode() == SpvOpTypeForwardPointer) {
  243. vstate->RegisterForwardPointer(inst->GetOperandAs<uint32_t>(0));
  244. }
  245. }
  246. }
  247. if (!vstate->has_memory_model_specified())
  248. return vstate->diag(SPV_ERROR_INVALID_LAYOUT, nullptr)
  249. << "Missing required OpMemoryModel instruction.";
  250. if (vstate->in_function_body())
  251. return vstate->diag(SPV_ERROR_INVALID_LAYOUT, nullptr)
  252. << "Missing OpFunctionEnd at end of module.";
  253. // Catch undefined forward references before performing further checks.
  254. if (auto error = ValidateForwardDecls(*vstate)) return error;
  255. // Calculate reachability after all the blocks are parsed, but early that it
  256. // can be relied on in subsequent pases.
  257. ReachabilityPass(*vstate);
  258. // ID usage needs be handled in its own iteration of the instructions,
  259. // between the two others. It depends on the first loop to have been
  260. // finished, so that all instructions have been registered. And the following
  261. // loop depends on all of the usage data being populated. Thus it cannot live
  262. // in either of those iterations.
  263. // It should also live after the forward declaration check, since it will
  264. // have problems with missing forward declarations, but give less useful error
  265. // messages.
  266. for (size_t i = 0; i < vstate->ordered_instructions().size(); ++i) {
  267. auto& instruction = vstate->ordered_instructions()[i];
  268. if (auto error = UpdateIdUse(*vstate, &instruction)) return error;
  269. }
  270. // Validate individual opcodes.
  271. for (size_t i = 0; i < vstate->ordered_instructions().size(); ++i) {
  272. auto& instruction = vstate->ordered_instructions()[i];
  273. // Keep these passes in the order they appear in the SPIR-V specification
  274. // sections to maintain test consistency.
  275. if (auto error = MiscPass(*vstate, &instruction)) return error;
  276. if (auto error = DebugPass(*vstate, &instruction)) return error;
  277. if (auto error = AnnotationPass(*vstate, &instruction)) return error;
  278. if (auto error = ExtensionPass(*vstate, &instruction)) return error;
  279. if (auto error = ModeSettingPass(*vstate, &instruction)) return error;
  280. if (auto error = TypePass(*vstate, &instruction)) return error;
  281. if (auto error = ConstantPass(*vstate, &instruction)) return error;
  282. if (auto error = MemoryPass(*vstate, &instruction)) return error;
  283. if (auto error = FunctionPass(*vstate, &instruction)) return error;
  284. if (auto error = ImagePass(*vstate, &instruction)) return error;
  285. if (auto error = ConversionPass(*vstate, &instruction)) return error;
  286. if (auto error = CompositesPass(*vstate, &instruction)) return error;
  287. if (auto error = ArithmeticsPass(*vstate, &instruction)) return error;
  288. if (auto error = BitwisePass(*vstate, &instruction)) return error;
  289. if (auto error = LogicalsPass(*vstate, &instruction)) return error;
  290. if (auto error = ControlFlowPass(*vstate, &instruction)) return error;
  291. if (auto error = DerivativesPass(*vstate, &instruction)) return error;
  292. if (auto error = AtomicsPass(*vstate, &instruction)) return error;
  293. if (auto error = PrimitivesPass(*vstate, &instruction)) return error;
  294. if (auto error = BarriersPass(*vstate, &instruction)) return error;
  295. // Group
  296. // Device-Side Enqueue
  297. // Pipe
  298. if (auto error = NonUniformPass(*vstate, &instruction)) return error;
  299. if (auto error = LiteralsPass(*vstate, &instruction)) return error;
  300. }
  301. // Validate the preconditions involving adjacent instructions. e.g. SpvOpPhi
  302. // must only be preceeded by SpvOpLabel, SpvOpPhi, or SpvOpLine.
  303. if (auto error = ValidateAdjacency(*vstate)) return error;
  304. if (auto error = ValidateEntryPoints(*vstate)) return error;
  305. // CFG checks are performed after the binary has been parsed
  306. // and the CFGPass has collected information about the control flow
  307. if (auto error = PerformCfgChecks(*vstate)) return error;
  308. if (auto error = CheckIdDefinitionDominateUse(*vstate)) return error;
  309. if (auto error = ValidateDecorations(*vstate)) return error;
  310. if (auto error = ValidateInterfaces(*vstate)) return error;
  311. // TODO(dsinclair): Restructure ValidateBuiltins so we can move into the
  312. // for() above as it loops over all ordered_instructions internally.
  313. if (auto error = ValidateBuiltIns(*vstate)) return error;
  314. // These checks must be performed after individual opcode checks because
  315. // those checks register the limitation checked here.
  316. for (const auto& inst : vstate->ordered_instructions()) {
  317. if (auto error = ValidateExecutionLimitations(*vstate, &inst)) return error;
  318. if (auto error = ValidateSmallTypeUses(*vstate, &inst)) return error;
  319. }
  320. return SPV_SUCCESS;
  321. }
  322. } // namespace
  323. spv_result_t ValidateBinaryAndKeepValidationState(
  324. const spv_const_context context, spv_const_validator_options options,
  325. const uint32_t* words, const size_t num_words, spv_diagnostic* pDiagnostic,
  326. std::unique_ptr<ValidationState_t>* vstate) {
  327. spv_context_t hijack_context = *context;
  328. if (pDiagnostic) {
  329. *pDiagnostic = nullptr;
  330. UseDiagnosticAsMessageConsumer(&hijack_context, pDiagnostic);
  331. }
  332. vstate->reset(new ValidationState_t(&hijack_context, options, words,
  333. num_words, kDefaultMaxNumOfWarnings));
  334. return ValidateBinaryUsingContextAndValidationState(
  335. hijack_context, words, num_words, pDiagnostic, vstate->get());
  336. }
  337. } // namespace val
  338. } // namespace spvtools
  339. spv_result_t spvValidate(const spv_const_context context,
  340. const spv_const_binary binary,
  341. spv_diagnostic* pDiagnostic) {
  342. return spvValidateBinary(context, binary->code, binary->wordCount,
  343. pDiagnostic);
  344. }
  345. spv_result_t spvValidateBinary(const spv_const_context context,
  346. const uint32_t* words, const size_t num_words,
  347. spv_diagnostic* pDiagnostic) {
  348. spv_context_t hijack_context = *context;
  349. if (pDiagnostic) {
  350. *pDiagnostic = nullptr;
  351. spvtools::UseDiagnosticAsMessageConsumer(&hijack_context, pDiagnostic);
  352. }
  353. // This interface is used for default command line options.
  354. spv_validator_options default_options = spvValidatorOptionsCreate();
  355. // Create the ValidationState using the context and default options.
  356. spvtools::val::ValidationState_t vstate(&hijack_context, default_options,
  357. words, num_words,
  358. kDefaultMaxNumOfWarnings);
  359. spv_result_t result =
  360. spvtools::val::ValidateBinaryUsingContextAndValidationState(
  361. hijack_context, words, num_words, pDiagnostic, &vstate);
  362. spvValidatorOptionsDestroy(default_options);
  363. return result;
  364. }
  365. spv_result_t spvValidateWithOptions(const spv_const_context context,
  366. spv_const_validator_options options,
  367. const spv_const_binary binary,
  368. spv_diagnostic* pDiagnostic) {
  369. spv_context_t hijack_context = *context;
  370. if (pDiagnostic) {
  371. *pDiagnostic = nullptr;
  372. spvtools::UseDiagnosticAsMessageConsumer(&hijack_context, pDiagnostic);
  373. }
  374. // Create the ValidationState using the context.
  375. spvtools::val::ValidationState_t vstate(&hijack_context, options,
  376. binary->code, binary->wordCount,
  377. kDefaultMaxNumOfWarnings);
  378. return spvtools::val::ValidateBinaryUsingContextAndValidationState(
  379. hijack_context, binary->code, binary->wordCount, pDiagnostic, &vstate);
  380. }