| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523 |
- // Copyright (c) 2015-2016 The Khronos Group Inc.
- //
- // Licensed under the Apache License, Version 2.0 (the "License");
- // you may not use this file except in compliance with the License.
- // You may obtain a copy of the License at
- //
- // http://www.apache.org/licenses/LICENSE-2.0
- //
- // Unless required by applicable law or agreed to in writing, software
- // distributed under the License is distributed on an "AS IS" BASIS,
- // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- // See the License for the specific language governing permissions and
- // limitations under the License.
- // Performs validation on instructions that appear inside of a SPIR-V block.
- #include <cassert>
- #include <sstream>
- #include <string>
- #include <vector>
- #include "source/enum_set.h"
- #include "source/enum_string_mapping.h"
- #include "source/extensions.h"
- #include "source/opcode.h"
- #include "source/operand.h"
- #include "source/spirv_constant.h"
- #include "source/spirv_target_env.h"
- #include "source/spirv_validator_options.h"
- #include "source/util/string_utils.h"
- #include "source/val/validate.h"
- #include "source/val/validation_state.h"
- namespace spvtools {
- namespace val {
- namespace {
- std::string ToString(const CapabilitySet& capabilities,
- const AssemblyGrammar& grammar) {
- std::stringstream ss;
- for (auto capability : capabilities) {
- spv_operand_desc desc;
- if (SPV_SUCCESS == grammar.lookupOperand(SPV_OPERAND_TYPE_CAPABILITY,
- uint32_t(capability), &desc))
- ss << desc->name << " ";
- else
- ss << uint32_t(capability) << " ";
- }
- return ss.str();
- }
- // Returns capabilities that enable an opcode. An empty result is interpreted
- // as no prohibition of use of the opcode. If the result is non-empty, then
- // the opcode may only be used if at least one of the capabilities is specified
- // by the module.
- CapabilitySet EnablingCapabilitiesForOp(const ValidationState_t& state,
- spv::Op opcode) {
- // Exceptions for SPV_AMD_shader_ballot
- switch (opcode) {
- // Normally these would require Group capability
- case spv::Op::OpGroupIAddNonUniformAMD:
- case spv::Op::OpGroupFAddNonUniformAMD:
- case spv::Op::OpGroupFMinNonUniformAMD:
- case spv::Op::OpGroupUMinNonUniformAMD:
- case spv::Op::OpGroupSMinNonUniformAMD:
- case spv::Op::OpGroupFMaxNonUniformAMD:
- case spv::Op::OpGroupUMaxNonUniformAMD:
- case spv::Op::OpGroupSMaxNonUniformAMD:
- if (state.HasExtension(kSPV_AMD_shader_ballot)) return CapabilitySet();
- break;
- default:
- break;
- }
- // Look it up in the grammar
- spv_opcode_desc opcode_desc = {};
- if (SPV_SUCCESS == state.grammar().lookupOpcode(opcode, &opcode_desc)) {
- return state.grammar().filterCapsAgainstTargetEnv(
- opcode_desc->capabilities, opcode_desc->numCapabilities);
- }
- return CapabilitySet();
- }
- // Returns SPV_SUCCESS if, for the given operand, the target environment
- // satsifies minimum version requirements, or if the module declares an
- // enabling extension for the operand. Otherwise emit a diagnostic and
- // return an error code.
- spv_result_t OperandVersionExtensionCheck(
- ValidationState_t& _, const Instruction* inst, size_t which_operand,
- const spv_operand_desc_t& operand_desc, uint32_t word) {
- const uint32_t module_version = _.version();
- const uint32_t operand_min_version = operand_desc.minVersion;
- const uint32_t operand_last_version = operand_desc.lastVersion;
- const bool reserved = operand_min_version == 0xffffffffu;
- const bool version_satisfied = !reserved &&
- (operand_min_version <= module_version) &&
- (module_version <= operand_last_version);
- if (version_satisfied) {
- return SPV_SUCCESS;
- }
- if (operand_last_version < module_version) {
- return _.diag(SPV_ERROR_WRONG_VERSION, inst)
- << spvtools::utils::CardinalToOrdinal(which_operand)
- << " operand of " << spvOpcodeString(inst->opcode()) << ": operand "
- << operand_desc.name << "(" << word << ") requires SPIR-V version "
- << SPV_SPIRV_VERSION_MAJOR_PART(operand_last_version) << "."
- << SPV_SPIRV_VERSION_MINOR_PART(operand_last_version)
- << " or earlier";
- }
- if (!reserved && operand_desc.numExtensions == 0) {
- return _.diag(SPV_ERROR_WRONG_VERSION, inst)
- << spvtools::utils::CardinalToOrdinal(which_operand)
- << " operand of " << spvOpcodeString(inst->opcode()) << ": operand "
- << operand_desc.name << "(" << word << ") requires SPIR-V version "
- << SPV_SPIRV_VERSION_MAJOR_PART(operand_min_version) << "."
- << SPV_SPIRV_VERSION_MINOR_PART(operand_min_version) << " or later";
- } else {
- ExtensionSet required_extensions(operand_desc.numExtensions,
- operand_desc.extensions);
- if (!_.HasAnyOfExtensions(required_extensions)) {
- return _.diag(SPV_ERROR_MISSING_EXTENSION, inst)
- << spvtools::utils::CardinalToOrdinal(which_operand)
- << " operand of " << spvOpcodeString(inst->opcode())
- << ": operand " << operand_desc.name << "(" << word
- << ") requires one of these extensions: "
- << ExtensionSetToString(required_extensions);
- }
- }
- return SPV_SUCCESS;
- }
- // Returns SPV_SUCCESS if the given operand is enabled by capabilities declared
- // in the module. Otherwise issues an error message and returns
- // SPV_ERROR_INVALID_CAPABILITY.
- spv_result_t CheckRequiredCapabilities(ValidationState_t& state,
- const Instruction* inst,
- size_t which_operand,
- const spv_parsed_operand_t& operand,
- uint32_t word) {
- // Mere mention of PointSize, ClipDistance, or CullDistance in a Builtin
- // decoration does not require the associated capability. The use of such
- // a variable value should trigger the capability requirement, but that's
- // not implemented yet. This rule is independent of target environment.
- // See https://github.com/KhronosGroup/SPIRV-Tools/issues/365
- if (operand.type == SPV_OPERAND_TYPE_BUILT_IN) {
- switch (spv::BuiltIn(word)) {
- case spv::BuiltIn::PointSize:
- case spv::BuiltIn::ClipDistance:
- case spv::BuiltIn::CullDistance:
- return SPV_SUCCESS;
- default:
- break;
- }
- } else if (operand.type == SPV_OPERAND_TYPE_FP_ROUNDING_MODE) {
- // Allow all FP rounding modes if requested
- if (state.features().free_fp_rounding_mode) {
- return SPV_SUCCESS;
- }
- } else if (operand.type == SPV_OPERAND_TYPE_GROUP_OPERATION &&
- state.features().group_ops_reduce_and_scans &&
- (word <= uint32_t(spv::GroupOperation::ExclusiveScan))) {
- // Allow certain group operations if requested.
- return SPV_SUCCESS;
- }
- CapabilitySet enabling_capabilities;
- spv_operand_desc operand_desc = nullptr;
- const auto lookup_result =
- state.grammar().lookupOperand(operand.type, word, &operand_desc);
- if (lookup_result == SPV_SUCCESS) {
- // Allow FPRoundingMode decoration if requested.
- if (operand.type == SPV_OPERAND_TYPE_DECORATION &&
- spv::Decoration(operand_desc->value) ==
- spv::Decoration::FPRoundingMode) {
- if (state.features().free_fp_rounding_mode) return SPV_SUCCESS;
- // Vulkan API requires more capabilities on rounding mode.
- if (spvIsVulkanEnv(state.context()->target_env)) {
- enabling_capabilities.insert(
- spv::Capability::StorageUniformBufferBlock16);
- enabling_capabilities.insert(spv::Capability::StorageUniform16);
- enabling_capabilities.insert(spv::Capability::StoragePushConstant16);
- enabling_capabilities.insert(spv::Capability::StorageInputOutput16);
- }
- } else {
- enabling_capabilities = state.grammar().filterCapsAgainstTargetEnv(
- operand_desc->capabilities, operand_desc->numCapabilities);
- }
- // When encountering an OpCapability instruction, the instruction pass
- // registers a capability with the module *before* checking capabilities.
- // So in the case of an OpCapability instruction, don't bother checking
- // enablement by another capability.
- if (inst->opcode() != spv::Op::OpCapability) {
- const bool enabled_by_cap =
- state.HasAnyOfCapabilities(enabling_capabilities);
- if (!enabling_capabilities.empty() && !enabled_by_cap) {
- return state.diag(SPV_ERROR_INVALID_CAPABILITY, inst)
- << "Operand " << which_operand << " of "
- << spvOpcodeString(inst->opcode())
- << " requires one of these capabilities: "
- << ToString(enabling_capabilities, state.grammar());
- }
- }
- return OperandVersionExtensionCheck(state, inst, which_operand,
- *operand_desc, word);
- }
- return SPV_SUCCESS;
- }
- // Returns SPV_ERROR_INVALID_BINARY and emits a diagnostic if the instruction
- // is explicitly reserved in the SPIR-V core spec. Otherwise return
- // SPV_SUCCESS.
- spv_result_t ReservedCheck(ValidationState_t& _, const Instruction* inst) {
- const spv::Op opcode = inst->opcode();
- switch (opcode) {
- // These instructions are enabled by a capability, but should never
- // be used anyway.
- case spv::Op::OpImageSparseSampleProjImplicitLod:
- case spv::Op::OpImageSparseSampleProjExplicitLod:
- case spv::Op::OpImageSparseSampleProjDrefImplicitLod:
- case spv::Op::OpImageSparseSampleProjDrefExplicitLod: {
- spv_opcode_desc inst_desc;
- _.grammar().lookupOpcode(opcode, &inst_desc);
- return _.diag(SPV_ERROR_INVALID_BINARY, inst)
- << "Invalid Opcode name 'Op" << inst_desc->name << "'";
- }
- default:
- break;
- }
- return SPV_SUCCESS;
- }
- // Returns SPV_ERROR_INVALID_CAPABILITY and emits a diagnostic if the
- // instruction is invalid because the required capability isn't declared
- // in the module.
- spv_result_t CapabilityCheck(ValidationState_t& _, const Instruction* inst) {
- const spv::Op opcode = inst->opcode();
- CapabilitySet opcode_caps = EnablingCapabilitiesForOp(_, opcode);
- if (!_.HasAnyOfCapabilities(opcode_caps)) {
- return _.diag(SPV_ERROR_INVALID_CAPABILITY, inst)
- << "Opcode " << spvOpcodeString(opcode)
- << " requires one of these capabilities: "
- << ToString(opcode_caps, _.grammar());
- }
- for (size_t i = 0; i < inst->operands().size(); ++i) {
- const auto& operand = inst->operand(i);
- const auto word = inst->word(operand.offset);
- if (spvOperandIsConcreteMask(operand.type)) {
- // Check for required capabilities for each bit position of the mask.
- for (uint32_t mask_bit = 0x80000000; mask_bit; mask_bit >>= 1) {
- if (word & mask_bit) {
- spv_result_t status =
- CheckRequiredCapabilities(_, inst, i + 1, operand, mask_bit);
- if (status != SPV_SUCCESS) return status;
- }
- }
- } else if (spvIsIdType(operand.type)) {
- // TODO(dneto): Check the value referenced by this Id, if we can compute
- // it. For now, just punt, to fix issue 248:
- // https://github.com/KhronosGroup/SPIRV-Tools/issues/248
- } else {
- // Check the operand word as a whole.
- spv_result_t status =
- CheckRequiredCapabilities(_, inst, i + 1, operand, word);
- if (status != SPV_SUCCESS) return status;
- }
- }
- return SPV_SUCCESS;
- }
- // Checks that the instruction can be used in this target environment's base
- // version. Assumes that CapabilityCheck has checked direct capability
- // dependencies for the opcode.
- spv_result_t VersionCheck(ValidationState_t& _, const Instruction* inst) {
- const auto opcode = inst->opcode();
- spv_opcode_desc inst_desc;
- const spv_result_t r = _.grammar().lookupOpcode(opcode, &inst_desc);
- assert(r == SPV_SUCCESS);
- (void)r;
- const auto min_version = inst_desc->minVersion;
- const auto last_version = inst_desc->lastVersion;
- const auto module_version = _.version();
- if (last_version < module_version) {
- return _.diag(SPV_ERROR_WRONG_VERSION, inst)
- << spvOpcodeString(opcode) << " requires SPIR-V version "
- << SPV_SPIRV_VERSION_MAJOR_PART(last_version) << "."
- << SPV_SPIRV_VERSION_MINOR_PART(last_version) << " or earlier";
- }
- // OpTerminateInvocation is special because it is enabled by Shader
- // capability, but also requires an extension and/or version check.
- const bool capability_check_is_sufficient =
- inst->opcode() != spv::Op::OpTerminateInvocation;
- if (capability_check_is_sufficient && (inst_desc->numCapabilities > 0u)) {
- // We already checked that the direct capability dependency has been
- // satisfied. We don't need to check any further.
- return SPV_SUCCESS;
- }
- ExtensionSet exts(inst_desc->numExtensions, inst_desc->extensions);
- if (exts.empty()) {
- // If no extensions can enable this instruction, then emit error
- // messages only concerning core SPIR-V versions if errors happen.
- if (min_version == ~0u) {
- return _.diag(SPV_ERROR_WRONG_VERSION, inst)
- << spvOpcodeString(opcode) << " is reserved for future use.";
- }
- if (module_version < min_version) {
- return _.diag(SPV_ERROR_WRONG_VERSION, inst)
- << spvOpcodeString(opcode) << " requires SPIR-V version "
- << SPV_SPIRV_VERSION_MAJOR_PART(min_version) << "."
- << SPV_SPIRV_VERSION_MINOR_PART(min_version) << " at minimum.";
- }
- } else if (!_.HasAnyOfExtensions(exts)) {
- // Otherwise, we only error out when no enabling extensions are
- // registered.
- if (min_version == ~0u) {
- return _.diag(SPV_ERROR_MISSING_EXTENSION, inst)
- << spvOpcodeString(opcode)
- << " requires one of the following extensions: "
- << ExtensionSetToString(exts);
- }
- if (module_version < min_version) {
- return _.diag(SPV_ERROR_WRONG_VERSION, inst)
- << spvOpcodeString(opcode) << " requires SPIR-V version "
- << SPV_SPIRV_VERSION_MAJOR_PART(min_version) << "."
- << SPV_SPIRV_VERSION_MINOR_PART(min_version)
- << " at minimum or one of the following extensions: "
- << ExtensionSetToString(exts);
- }
- }
- return SPV_SUCCESS;
- }
- // Checks that the Resuld <id> is within the valid bound.
- spv_result_t LimitCheckIdBound(ValidationState_t& _, const Instruction* inst) {
- if (inst->id() >= _.getIdBound()) {
- return _.diag(SPV_ERROR_INVALID_BINARY, inst)
- << "Result <id> '" << inst->id()
- << "' must be less than the ID bound '" << _.getIdBound() << "'.";
- }
- return SPV_SUCCESS;
- }
- // Checks that the number of OpTypeStruct members is within the limit.
- spv_result_t LimitCheckStruct(ValidationState_t& _, const Instruction* inst) {
- if (spv::Op::OpTypeStruct != inst->opcode()) {
- return SPV_SUCCESS;
- }
- // Number of members is the number of operands of the instruction minus 1.
- // One operand is the result ID.
- const uint16_t limit =
- static_cast<uint16_t>(_.options()->universal_limits_.max_struct_members);
- if (inst->operands().size() - 1 > limit) {
- return _.diag(SPV_ERROR_INVALID_BINARY, inst)
- << "Number of OpTypeStruct members (" << inst->operands().size() - 1
- << ") has exceeded the limit (" << limit << ").";
- }
- // Section 2.17 of SPIRV Spec specifies that the "Structure Nesting Depth"
- // must be less than or equal to 255.
- // This is interpreted as structures including other structures as
- // members. The code does not follow pointers or look into arrays to see
- // if we reach a structure downstream. The nesting depth of a struct is
- // 1+(largest depth of any member). Scalars are at depth 0.
- uint32_t max_member_depth = 0;
- // Struct members start at word 2 of OpTypeStruct instruction.
- for (size_t word_i = 2; word_i < inst->words().size(); ++word_i) {
- auto member = inst->word(word_i);
- auto memberTypeInstr = _.FindDef(member);
- if (memberTypeInstr && spv::Op::OpTypeStruct == memberTypeInstr->opcode()) {
- max_member_depth = std::max(
- max_member_depth, _.struct_nesting_depth(memberTypeInstr->id()));
- }
- }
- const uint32_t depth_limit = _.options()->universal_limits_.max_struct_depth;
- const uint32_t cur_depth = 1 + max_member_depth;
- _.set_struct_nesting_depth(inst->id(), cur_depth);
- if (cur_depth > depth_limit) {
- return _.diag(SPV_ERROR_INVALID_BINARY, inst)
- << "Structure Nesting Depth may not be larger than " << depth_limit
- << ". Found " << cur_depth << ".";
- }
- return SPV_SUCCESS;
- }
- // Checks that the number of (literal, label) pairs in OpSwitch is within
- // the limit.
- spv_result_t LimitCheckSwitch(ValidationState_t& _, const Instruction* inst) {
- if (spv::Op::OpSwitch == inst->opcode()) {
- // The instruction syntax is as follows:
- // OpSwitch <selector ID> <Default ID> literal label literal label ...
- // literal,label pairs come after the first 2 operands.
- // It is guaranteed at this point that num_operands is an even number.
- size_t num_pairs = (inst->operands().size() - 2) / 2;
- const unsigned int num_pairs_limit =
- _.options()->universal_limits_.max_switch_branches;
- if (num_pairs > num_pairs_limit) {
- return _.diag(SPV_ERROR_INVALID_BINARY, inst)
- << "Number of (literal, label) pairs in OpSwitch (" << num_pairs
- << ") exceeds the limit (" << num_pairs_limit << ").";
- }
- }
- return SPV_SUCCESS;
- }
- // Ensure the number of variables of the given class does not exceed the
- // limit.
- spv_result_t LimitCheckNumVars(ValidationState_t& _, const uint32_t var_id,
- const spv::StorageClass storage_class) {
- if (spv::StorageClass::Function == storage_class) {
- _.registerLocalVariable(var_id);
- const uint32_t num_local_vars_limit =
- _.options()->universal_limits_.max_local_variables;
- if (_.num_local_vars() > num_local_vars_limit) {
- return _.diag(SPV_ERROR_INVALID_BINARY, nullptr)
- << "Number of local variables ('Function' Storage Class) "
- "exceeded the valid limit ("
- << num_local_vars_limit << ").";
- }
- } else {
- _.registerGlobalVariable(var_id);
- const uint32_t num_global_vars_limit =
- _.options()->universal_limits_.max_global_variables;
- if (_.num_global_vars() > num_global_vars_limit) {
- return _.diag(SPV_ERROR_INVALID_BINARY, nullptr)
- << "Number of Global Variables (Storage Class other than "
- "'Function') exceeded the valid limit ("
- << num_global_vars_limit << ").";
- }
- }
- return SPV_SUCCESS;
- }
- // Parses OpExtension instruction and logs warnings if unsuccessful.
- spv_result_t CheckIfKnownExtension(ValidationState_t& _,
- const Instruction* inst) {
- const std::string extension_str = GetExtensionString(&(inst->c_inst()));
- Extension extension;
- if (!GetExtensionFromString(extension_str.c_str(), &extension)) {
- return _.diag(SPV_WARNING, inst)
- << "Found unrecognized extension " << extension_str;
- }
- return SPV_SUCCESS;
- }
- } // namespace
- spv_result_t InstructionPass(ValidationState_t& _, const Instruction* inst) {
- const spv::Op opcode = inst->opcode();
- if (opcode == spv::Op::OpExtension) {
- CheckIfKnownExtension(_, inst);
- } else if (opcode == spv::Op::OpCapability) {
- _.RegisterCapability(inst->GetOperandAs<spv::Capability>(0));
- } else if (opcode == spv::Op::OpMemoryModel) {
- if (_.has_memory_model_specified()) {
- return _.diag(SPV_ERROR_INVALID_LAYOUT, inst)
- << "OpMemoryModel should only be provided once.";
- }
- _.set_addressing_model(inst->GetOperandAs<spv::AddressingModel>(0));
- _.set_memory_model(inst->GetOperandAs<spv::MemoryModel>(1));
- } else if (opcode == spv::Op::OpExecutionMode ||
- opcode == spv::Op::OpExecutionModeId) {
- const uint32_t entry_point = inst->word(1);
- _.RegisterExecutionModeForEntryPoint(entry_point,
- spv::ExecutionMode(inst->word(2)));
- if (inst->GetOperandAs<spv::ExecutionMode>(1) ==
- spv::ExecutionMode::LocalSize ||
- inst->GetOperandAs<spv::ExecutionMode>(1) ==
- spv::ExecutionMode::LocalSizeId) {
- _.RegisterEntryPointLocalSize(entry_point, inst);
- }
- if (inst->GetOperandAs<spv::ExecutionMode>(1) ==
- spv::ExecutionMode::OutputPrimitivesEXT) {
- _.RegisterEntryPointOutputPrimitivesEXT(entry_point, inst);
- }
- } else if (opcode == spv::Op::OpVariable) {
- const auto storage_class = inst->GetOperandAs<spv::StorageClass>(2);
- if (auto error = LimitCheckNumVars(_, inst->id(), storage_class)) {
- return error;
- }
- } else if (opcode == spv::Op::OpSamplerImageAddressingModeNV) {
- if (!_.HasCapability(spv::Capability::BindlessTextureNV)) {
- return _.diag(SPV_ERROR_MISSING_EXTENSION, inst)
- << "OpSamplerImageAddressingModeNV supported only with extension "
- "SPV_NV_bindless_texture";
- }
- uint32_t bitwidth = inst->GetOperandAs<uint32_t>(0);
- if (_.samplerimage_variable_address_mode() != 0) {
- return _.diag(SPV_ERROR_INVALID_LAYOUT, inst)
- << "OpSamplerImageAddressingModeNV should only be provided once";
- }
- if (bitwidth != 32 && bitwidth != 64) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "OpSamplerImageAddressingModeNV bitwidth should be 64 or 32";
- }
- _.set_samplerimage_variable_address_mode(bitwidth);
- }
- if (auto error = ReservedCheck(_, inst)) return error;
- if (auto error = CapabilityCheck(_, inst)) return error;
- if (auto error = LimitCheckIdBound(_, inst)) return error;
- if (auto error = LimitCheckStruct(_, inst)) return error;
- if (auto error = LimitCheckSwitch(_, inst)) return error;
- if (auto error = VersionCheck(_, inst)) return error;
- // All instruction checks have passed.
- return SPV_SUCCESS;
- }
- } // namespace val
- } // namespace spvtools
|