| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368 |
- // Copyright (c) 2022 The Khronos Group Inc.
- //
- // Licensed under the Apache License, Version 2.0 (the "License");
- // you may not use this file except in compliance with the License.
- // You may obtain a copy of the License at
- //
- // http://www.apache.org/licenses/LICENSE-2.0
- //
- // Unless required by applicable law or agreed to in writing, software
- // distributed under the License is distributed on an "AS IS" BASIS,
- // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- // See the License for the specific language governing permissions and
- // limitations under the License.
- // Validates ray query instructions from SPV_KHR_ray_query
- #include "source/opcode.h"
- #include "source/val/instruction.h"
- #include "source/val/validate.h"
- #include "source/val/validation_state.h"
- namespace spvtools {
- namespace val {
- namespace {
- uint32_t GetArrayLength(ValidationState_t& _, const Instruction* array_type) {
- assert(array_type->opcode() == spv::Op::OpTypeArray);
- uint32_t const_int_id = array_type->GetOperandAs<uint32_t>(2U);
- Instruction* array_length_inst = _.FindDef(const_int_id);
- uint32_t array_length = 0;
- if (array_length_inst->opcode() == spv::Op::OpConstant) {
- array_length = array_length_inst->GetOperandAs<uint32_t>(2);
- }
- return array_length;
- }
- spv_result_t ValidateRayQueryPointer(ValidationState_t& _,
- const Instruction* inst,
- uint32_t ray_query_index) {
- const uint32_t ray_query_id = inst->GetOperandAs<uint32_t>(ray_query_index);
- auto variable = _.FindDef(ray_query_id);
- const auto var_opcode = variable->opcode();
- if (!variable || (var_opcode != spv::Op::OpVariable &&
- var_opcode != spv::Op::OpFunctionParameter &&
- var_opcode != spv::Op::OpAccessChain)) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Ray Query must be a memory object declaration";
- }
- auto pointer = _.FindDef(variable->GetOperandAs<uint32_t>(0));
- if (!pointer || pointer->opcode() != spv::Op::OpTypePointer) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Ray Query must be a pointer";
- }
- auto type = _.FindDef(pointer->GetOperandAs<uint32_t>(2));
- if (!type || type->opcode() != spv::Op::OpTypeRayQueryKHR) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Ray Query must be a pointer to OpTypeRayQueryKHR";
- }
- return SPV_SUCCESS;
- }
- spv_result_t ValidateIntersectionId(ValidationState_t& _,
- const Instruction* inst,
- uint32_t intersection_index) {
- const uint32_t intersection_id =
- inst->GetOperandAs<uint32_t>(intersection_index);
- const uint32_t intersection_type = _.GetTypeId(intersection_id);
- const spv::Op intersection_opcode = _.GetIdOpcode(intersection_id);
- if (!_.IsIntScalarType(intersection_type) ||
- _.GetBitWidth(intersection_type) != 32 ||
- !spvOpcodeIsConstant(intersection_opcode)) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Intersection ID to be a constant 32-bit int scalar";
- }
- return SPV_SUCCESS;
- }
- } // namespace
- spv_result_t RayQueryPass(ValidationState_t& _, const Instruction* inst) {
- const spv::Op opcode = inst->opcode();
- const uint32_t result_type = inst->type_id();
- switch (opcode) {
- case spv::Op::OpRayQueryInitializeKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 0)) return error;
- if (_.GetIdOpcode(_.GetOperandTypeId(inst, 1)) !=
- spv::Op::OpTypeAccelerationStructureKHR) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Expected Acceleration Structure to be of type "
- "OpTypeAccelerationStructureKHR";
- }
- const uint32_t ray_flags = _.GetOperandTypeId(inst, 2);
- if (!_.IsIntScalarType(ray_flags) || _.GetBitWidth(ray_flags) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Ray Flags must be a 32-bit int scalar";
- }
- const uint32_t cull_mask = _.GetOperandTypeId(inst, 3);
- if (!_.IsIntScalarType(cull_mask) || _.GetBitWidth(cull_mask) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Cull Mask must be a 32-bit int scalar";
- }
- const uint32_t ray_origin = _.GetOperandTypeId(inst, 4);
- if (!_.IsFloatVectorType(ray_origin) || _.GetDimension(ray_origin) != 3 ||
- _.GetBitWidth(ray_origin) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Ray Origin must be a 32-bit float 3-component vector";
- }
- const uint32_t ray_tmin = _.GetOperandTypeId(inst, 5);
- if (!_.IsFloatScalarType(ray_tmin) || _.GetBitWidth(ray_tmin) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Ray TMin must be a 32-bit float scalar";
- }
- const uint32_t ray_direction = _.GetOperandTypeId(inst, 6);
- if (!_.IsFloatVectorType(ray_direction) ||
- _.GetDimension(ray_direction) != 3 ||
- _.GetBitWidth(ray_direction) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Ray Direction must be a 32-bit float 3-component vector";
- }
- const uint32_t ray_tmax = _.GetOperandTypeId(inst, 7);
- if (!_.IsFloatScalarType(ray_tmax) || _.GetBitWidth(ray_tmax) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Ray TMax must be a 32-bit float scalar";
- }
- break;
- }
- case spv::Op::OpRayQueryTerminateKHR:
- case spv::Op::OpRayQueryConfirmIntersectionKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 0)) return error;
- break;
- }
- case spv::Op::OpRayQueryGenerateIntersectionKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 0)) return error;
- const uint32_t hit_t_id = _.GetOperandTypeId(inst, 1);
- if (!_.IsFloatScalarType(hit_t_id) || _.GetBitWidth(hit_t_id) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Hit T must be a 32-bit float scalar";
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionFrontFaceKHR:
- case spv::Op::OpRayQueryProceedKHR:
- case spv::Op::OpRayQueryGetIntersectionCandidateAABBOpaqueKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (!_.IsBoolScalarType(result_type)) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be bool scalar type";
- }
- if (opcode == spv::Op::OpRayQueryGetIntersectionFrontFaceKHR) {
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionTKHR:
- case spv::Op::OpRayQueryGetRayTMinKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (!_.IsFloatScalarType(result_type) ||
- _.GetBitWidth(result_type) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be 32-bit float scalar type";
- }
- if (opcode == spv::Op::OpRayQueryGetIntersectionTKHR) {
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionTypeKHR:
- case spv::Op::OpRayQueryGetIntersectionInstanceCustomIndexKHR:
- case spv::Op::OpRayQueryGetIntersectionInstanceIdKHR:
- case spv::Op::
- OpRayQueryGetIntersectionInstanceShaderBindingTableRecordOffsetKHR:
- case spv::Op::OpRayQueryGetIntersectionGeometryIndexKHR:
- case spv::Op::OpRayQueryGetIntersectionPrimitiveIndexKHR:
- case spv::Op::OpRayQueryGetRayFlagsKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (!_.IsIntScalarType(result_type) || _.GetBitWidth(result_type) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be 32-bit int scalar type";
- }
- if (opcode != spv::Op::OpRayQueryGetRayFlagsKHR) {
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionObjectRayDirectionKHR:
- case spv::Op::OpRayQueryGetIntersectionObjectRayOriginKHR:
- case spv::Op::OpRayQueryGetWorldRayDirectionKHR:
- case spv::Op::OpRayQueryGetWorldRayOriginKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (!_.IsFloatVectorType(result_type) ||
- _.GetDimension(result_type) != 3 ||
- _.GetBitWidth(result_type) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be 32-bit float 3-component "
- "vector type";
- }
- if (opcode == spv::Op::OpRayQueryGetIntersectionObjectRayDirectionKHR ||
- opcode == spv::Op::OpRayQueryGetIntersectionObjectRayOriginKHR) {
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionBarycentricsKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- if (!_.IsFloatVectorType(result_type) ||
- _.GetDimension(result_type) != 2 ||
- _.GetBitWidth(result_type) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be 32-bit float 2-component "
- "vector type";
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionObjectToWorldKHR:
- case spv::Op::OpRayQueryGetIntersectionWorldToObjectKHR: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- uint32_t num_rows = 0;
- uint32_t num_cols = 0;
- uint32_t col_type = 0;
- uint32_t component_type = 0;
- if (!_.GetMatrixTypeInfo(result_type, &num_rows, &num_cols, &col_type,
- &component_type)) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected matrix type as Result Type";
- }
- if (num_cols != 4) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type matrix to have a Column Count of 4";
- }
- if (!_.IsFloatScalarType(component_type) ||
- _.GetBitWidth(result_type) != 32 || num_rows != 3) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type matrix to have a Column Type of "
- "3-component 32-bit float vectors";
- }
- break;
- }
- case spv::Op::OpRayQueryGetClusterIdNV: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- if (!_.IsIntScalarType(result_type) || _.GetBitWidth(result_type) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be 32-bit int scalar type";
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionSpherePositionNV: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- if (!_.IsFloatVectorType(result_type) ||
- _.GetDimension(result_type) != 3 ||
- _.GetBitWidth(result_type) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be 32-bit float 3-component "
- "vector type";
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionLSSPositionsNV: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- auto result_id = _.FindDef(result_type);
- if ((result_id->opcode() != spv::Op::OpTypeArray) ||
- (GetArrayLength(_, result_id) != 2) ||
- !_.IsFloatVectorType(_.GetComponentType(result_type)) ||
- _.GetDimension(_.GetComponentType(result_type)) != 3) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Expected 2 element array of 32-bit 3 component float point "
- "vector as Result Type: "
- << spvOpcodeString(opcode);
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionLSSRadiiNV: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- if (!_.IsFloatArrayType(result_type) ||
- (GetArrayLength(_, _.FindDef(result_type)) != 2) ||
- !_.IsFloatScalarType(_.GetComponentType(result_type))) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "Expected 32-bit floating point scalar as Result Type: "
- << spvOpcodeString(opcode);
- }
- break;
- }
- case spv::Op::OpRayQueryGetIntersectionSphereRadiusNV:
- case spv::Op::OpRayQueryGetIntersectionLSSHitValueNV: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- if (!_.IsFloatScalarType(result_type) ||
- _.GetBitWidth(result_type) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be 32-bit floating point "
- "scalar type";
- }
- break;
- }
- case spv::Op::OpRayQueryIsSphereHitNV:
- case spv::Op::OpRayQueryIsLSSHitNV: {
- if (auto error = ValidateRayQueryPointer(_, inst, 2)) return error;
- if (auto error = ValidateIntersectionId(_, inst, 3)) return error;
- if (!_.IsBoolScalarType(result_type)) {
- return _.diag(SPV_ERROR_INVALID_DATA, inst)
- << "expected Result Type to be Boolean "
- "scalar type";
- }
- break;
- }
- default:
- break;
- }
- return SPV_SUCCESS;
- }
- } // namespace val
- } // namespace spvtools
|