| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851 |
- // Copyright (c) 2017 Valve Corporation
- // Copyright (c) 2017 LunarG Inc.
- //
- // Licensed under the Apache License, Version 2.0 (the "License");
- // you may not use this file except in compliance with the License.
- // You may obtain a copy of the License at
- //
- // http://www.apache.org/licenses/LICENSE-2.0
- //
- // Unless required by applicable law or agreed to in writing, software
- // distributed under the License is distributed on an "AS IS" BASIS,
- // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- // See the License for the specific language governing permissions and
- // limitations under the License.
- #include <string>
- #include "test/opt/pass_fixture.h"
- #include "test/opt/pass_utils.h"
- namespace spvtools {
- namespace opt {
- namespace {
- using DeadInsertElimTest = PassTest<::testing::Test>;
- TEST_F(DeadInsertElimTest, InsertAfterInsertElim) {
- // With two insertions to the same offset, the first is dead.
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) in float In0;
- // layout (location=1) in float In1;
- // layout (location=2) in vec2 In2;
- // layout (location=0) out vec4 OutColor;
- //
- // void main()
- // {
- // vec2 v = In2;
- // v.x = In0 + In1; // dead
- // v.x = 0.0;
- // OutColor = v.xyxy;
- // }
- const std::string before_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In2 %In0 %In1 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In2 "In2"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %OutColor "OutColor"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_n"
- OpName %_ ""
- OpDecorate %In2 Location 2
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %OutColor Location 0
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- %void = OpTypeVoid
- %11 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %_ptr_Input_v2float = OpTypePointer Input %v2float
- %In2 = OpVariable %_ptr_Input_v2float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In0 = OpVariable %_ptr_Input_float Input
- %In1 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_ptr_Function_float = OpTypePointer Function %float
- %float_0 = OpConstant %float 0
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %int = OpTypeInt 32 1
- %_Globals_ = OpTypeStruct %uint %int
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- )";
- const std::string after_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In2 %In0 %In1 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In2 "In2"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %OutColor "OutColor"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_n"
- OpName %_ ""
- OpDecorate %In2 Location 2
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %OutColor Location 0
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %_ptr_Input_v2float = OpTypePointer Input %v2float
- %In2 = OpVariable %_ptr_Input_v2float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In0 = OpVariable %_ptr_Input_float Input
- %In1 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_ptr_Function_float = OpTypePointer Function %float
- %float_0 = OpConstant %float 0
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %int = OpTypeInt 32 1
- %_Globals_ = OpTypeStruct %uint %int
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- )";
- const std::string before =
- R"(%main = OpFunction %void None %11
- %25 = OpLabel
- %26 = OpLoad %v2float %In2
- %27 = OpLoad %float %In0
- %28 = OpLoad %float %In1
- %29 = OpFAdd %float %27 %28
- %35 = OpCompositeInsert %v2float %29 %26 0
- %37 = OpCompositeInsert %v2float %float_0 %35 0
- %33 = OpVectorShuffle %v4float %37 %37 0 1 0 1
- OpStore %OutColor %33
- OpReturn
- OpFunctionEnd
- )";
- const std::string after =
- R"(%main = OpFunction %void None %10
- %23 = OpLabel
- %24 = OpLoad %v2float %In2
- %29 = OpCompositeInsert %v2float %float_0 %24 0
- %30 = OpVectorShuffle %v4float %29 %29 0 1 0 1
- OpStore %OutColor %30
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndCheck<DeadInsertElimPass>(before_predefs + before,
- after_predefs + after, true, true);
- }
- TEST_F(DeadInsertElimTest, DeadInsertForLinkage) {
- const std::string before =
- R"(OpCapability Shader
- OpCapability Linkage
- OpMemoryModel Logical GLSL450
- OpSource HLSL 630
- OpName %main "main"
- OpName %BaseColor "BaseColor"
- OpName %bb_entry "bb.entry"
- OpName %v "v"
- OpDecorate %main LinkageAttributes "main" Export
- %int = OpTypeInt 32 1
- %int_1 = OpConstant %int 1
- %uint = OpTypeInt 32 0
- %uint_0 = OpConstant %uint 0
- %int_0 = OpConstant %int 0
- %float = OpTypeFloat 32
- %float_0 = OpConstant %float 0
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %14 = OpTypeFunction %v2float %_ptr_Function_v2float
- %_ptr_Function_float = OpTypePointer Function %float
- %main = OpFunction %v2float None %14
- %BaseColor = OpFunctionParameter %_ptr_Function_v2float
- %bb_entry = OpLabel
- %v = OpVariable %_ptr_Function_v2float Function
- %16 = OpLoad %v2float %v
- %17 = OpAccessChain %_ptr_Function_float %BaseColor %int_1
- %18 = OpLoad %float %17
- %19 = OpCompositeInsert %v2float %18 %16 0
- %20 = OpCompositeInsert %v2float %float_0 %19 0
- OpReturnValue %20
- OpFunctionEnd
- )";
- const std::string after =
- R"(OpCapability Shader
- OpCapability Linkage
- OpMemoryModel Logical GLSL450
- OpSource HLSL 630
- OpName %main "main"
- OpName %BaseColor "BaseColor"
- OpName %bb_entry "bb.entry"
- OpName %v "v"
- OpDecorate %main LinkageAttributes "main" Export
- %int = OpTypeInt 32 1
- %uint = OpTypeInt 32 0
- %uint_0 = OpConstant %uint 0
- %int_0 = OpConstant %int 0
- %float = OpTypeFloat 32
- %float_0 = OpConstant %float 0
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %14 = OpTypeFunction %v2float %_ptr_Function_v2float
- %_ptr_Function_float = OpTypePointer Function %float
- %main = OpFunction %v2float None %14
- %BaseColor = OpFunctionParameter %_ptr_Function_v2float
- %bb_entry = OpLabel
- %v = OpVariable %_ptr_Function_v2float Function
- %16 = OpLoad %v2float %v
- %20 = OpCompositeInsert %v2float %float_0 %16 0
- OpReturnValue %20
- OpFunctionEnd
- )";
- SinglePassRunAndCheck<DeadInsertElimPass>(before, after, true, true);
- }
- TEST_F(DeadInsertElimTest, DeadInsertInChainWithPhi) {
- // Dead insert eliminated with phi in insertion chain.
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) in vec4 In0;
- // layout (location=1) in float In1;
- // layout (location=2) in float In2;
- // layout (location=0) out vec4 OutColor;
- //
- // layout(std140, binding = 0 ) uniform _Globals_
- // {
- // bool g_b;
- // };
- //
- // void main()
- // {
- // vec4 v = In0;
- // v.z = In1 + In2;
- // if (g_b) v.w = 1.0;
- // OutColor = vec4(v.x,v.y,0.0,v.w);
- // }
- const std::string before_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %In2 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %11 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_ptr_Function_float = OpTypePointer Function %float
- %_Globals_ = OpTypeStruct %uint
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %_ptr_Uniform_uint = OpTypePointer Uniform %uint
- %bool = OpTypeBool
- %uint_0 = OpConstant %uint 0
- %float_1 = OpConstant %float 1
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %float_0 = OpConstant %float 0
- )";
- const std::string after_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %In2 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_ptr_Function_float = OpTypePointer Function %float
- %_Globals_ = OpTypeStruct %uint
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %_ptr_Uniform_uint = OpTypePointer Uniform %uint
- %bool = OpTypeBool
- %uint_0 = OpConstant %uint 0
- %float_1 = OpConstant %float 1
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %float_0 = OpConstant %float 0
- )";
- const std::string before =
- R"(%main = OpFunction %void None %11
- %31 = OpLabel
- %32 = OpLoad %v4float %In0
- %33 = OpLoad %float %In1
- %34 = OpLoad %float %In2
- %35 = OpFAdd %float %33 %34
- %51 = OpCompositeInsert %v4float %35 %32 2
- %37 = OpAccessChain %_ptr_Uniform_uint %_ %int_0
- %38 = OpLoad %uint %37
- %39 = OpINotEqual %bool %38 %uint_0
- OpSelectionMerge %40 None
- OpBranchConditional %39 %41 %40
- %41 = OpLabel
- %53 = OpCompositeInsert %v4float %float_1 %51 3
- OpBranch %40
- %40 = OpLabel
- %60 = OpPhi %v4float %51 %31 %53 %41
- %55 = OpCompositeExtract %float %60 0
- %57 = OpCompositeExtract %float %60 1
- %59 = OpCompositeExtract %float %60 3
- %49 = OpCompositeConstruct %v4float %55 %57 %float_0 %59
- OpStore %OutColor %49
- OpReturn
- OpFunctionEnd
- )";
- const std::string after =
- R"(%main = OpFunction %void None %10
- %27 = OpLabel
- %28 = OpLoad %v4float %In0
- %33 = OpAccessChain %_ptr_Uniform_uint %_ %int_0
- %34 = OpLoad %uint %33
- %35 = OpINotEqual %bool %34 %uint_0
- OpSelectionMerge %36 None
- OpBranchConditional %35 %37 %36
- %37 = OpLabel
- %38 = OpCompositeInsert %v4float %float_1 %28 3
- OpBranch %36
- %36 = OpLabel
- %39 = OpPhi %v4float %28 %27 %38 %37
- %40 = OpCompositeExtract %float %39 0
- %41 = OpCompositeExtract %float %39 1
- %42 = OpCompositeExtract %float %39 3
- %43 = OpCompositeConstruct %v4float %40 %41 %float_0 %42
- OpStore %OutColor %43
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndCheck<DeadInsertElimPass>(before_predefs + before,
- after_predefs + after, true, true);
- }
- TEST_F(DeadInsertElimTest, DeadInsertTwoPasses) {
- // Dead insert which requires two passes to eliminate
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) in vec4 In0;
- // layout (location=1) in float In1;
- // layout (location=2) in float In2;
- // layout (location=0) out vec4 OutColor;
- //
- // layout(std140, binding = 0 ) uniform _Globals_
- // {
- // bool g_b;
- // bool g_b2;
- // };
- //
- // void main()
- // {
- // vec4 v1, v2;
- // v1 = In0;
- // v1.y = In1 + In2; // dead, second pass
- // if (g_b) v1.x = 1.0;
- // v2.x = v1.x;
- // v2.y = v1.y; // dead, first pass
- // if (g_b2) v2.x = 0.0;
- // OutColor = vec4(v2.x,v2.x,0.0,1.0);
- // }
- const std::string before_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %In2 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_b2"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_Globals_ = OpTypeStruct %uint %uint
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %_ptr_Uniform_uint = OpTypePointer Uniform %uint
- %bool = OpTypeBool
- %uint_0 = OpConstant %uint 0
- %float_1 = OpConstant %float 1
- %int_1 = OpConstant %int 1
- %float_0 = OpConstant %float 0
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %27 = OpUndef %v4float
- )";
- const std::string after_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %In2 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_b2"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_Globals_ = OpTypeStruct %uint %uint
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %_ptr_Uniform_uint = OpTypePointer Uniform %uint
- %bool = OpTypeBool
- %uint_0 = OpConstant %uint 0
- %float_1 = OpConstant %float 1
- %int_1 = OpConstant %int 1
- %float_0 = OpConstant %float 0
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %27 = OpUndef %v4float
- )";
- const std::string before =
- R"(%main = OpFunction %void None %10
- %28 = OpLabel
- %29 = OpLoad %v4float %In0
- %30 = OpLoad %float %In1
- %31 = OpLoad %float %In2
- %32 = OpFAdd %float %30 %31
- %33 = OpCompositeInsert %v4float %32 %29 1
- %34 = OpAccessChain %_ptr_Uniform_uint %_ %int_0
- %35 = OpLoad %uint %34
- %36 = OpINotEqual %bool %35 %uint_0
- OpSelectionMerge %37 None
- OpBranchConditional %36 %38 %37
- %38 = OpLabel
- %39 = OpCompositeInsert %v4float %float_1 %33 0
- OpBranch %37
- %37 = OpLabel
- %40 = OpPhi %v4float %33 %28 %39 %38
- %41 = OpCompositeExtract %float %40 0
- %42 = OpCompositeInsert %v4float %41 %27 0
- %43 = OpCompositeExtract %float %40 1
- %44 = OpCompositeInsert %v4float %43 %42 1
- %45 = OpAccessChain %_ptr_Uniform_uint %_ %int_1
- %46 = OpLoad %uint %45
- %47 = OpINotEqual %bool %46 %uint_0
- OpSelectionMerge %48 None
- OpBranchConditional %47 %49 %48
- %49 = OpLabel
- %50 = OpCompositeInsert %v4float %float_0 %44 0
- OpBranch %48
- %48 = OpLabel
- %51 = OpPhi %v4float %44 %37 %50 %49
- %52 = OpCompositeExtract %float %51 0
- %53 = OpCompositeExtract %float %51 0
- %54 = OpCompositeConstruct %v4float %52 %53 %float_0 %float_1
- OpStore %OutColor %54
- OpReturn
- OpFunctionEnd
- )";
- const std::string after =
- R"(%main = OpFunction %void None %10
- %28 = OpLabel
- %29 = OpLoad %v4float %In0
- %34 = OpAccessChain %_ptr_Uniform_uint %_ %int_0
- %35 = OpLoad %uint %34
- %36 = OpINotEqual %bool %35 %uint_0
- OpSelectionMerge %37 None
- OpBranchConditional %36 %38 %37
- %38 = OpLabel
- %39 = OpCompositeInsert %v4float %float_1 %29 0
- OpBranch %37
- %37 = OpLabel
- %40 = OpPhi %v4float %29 %28 %39 %38
- %41 = OpCompositeExtract %float %40 0
- %42 = OpCompositeInsert %v4float %41 %27 0
- %45 = OpAccessChain %_ptr_Uniform_uint %_ %int_1
- %46 = OpLoad %uint %45
- %47 = OpINotEqual %bool %46 %uint_0
- OpSelectionMerge %48 None
- OpBranchConditional %47 %49 %48
- %49 = OpLabel
- %50 = OpCompositeInsert %v4float %float_0 %42 0
- OpBranch %48
- %48 = OpLabel
- %51 = OpPhi %v4float %42 %37 %50 %49
- %52 = OpCompositeExtract %float %51 0
- %53 = OpCompositeExtract %float %51 0
- %54 = OpCompositeConstruct %v4float %52 %53 %float_0 %float_1
- OpStore %OutColor %54
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndCheck<DeadInsertElimPass>(before_predefs + before,
- after_predefs + after, true, true);
- }
- TEST_F(DeadInsertElimTest, DebugInsertAfterInsertElim) {
- // With two insertions to the same offset, the first is dead.
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) in float In0;
- // layout (location=1) in float In1;
- // layout (location=2) in vec2 In2;
- // layout (location=0) out vec4 OutColor;
- //
- // void main()
- // {
- // vec2 v = In2;
- // v.x = In0 + In1; // dead
- // v.x = 0.0;
- // OutColor = v.xyxy;
- // }
- const std::string text =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- %ext = OpExtInstImport "OpenCL.DebugInfo.100"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In2 %In0 %In1 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- %file_name = OpString "test"
- %float_name = OpString "float"
- %main_name = OpString "main"
- %f_name = OpString "f"
- OpName %main "main"
- OpName %In2 "In2"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %OutColor "OutColor"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_n"
- OpName %_ ""
- OpDecorate %In2 Location 2
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %OutColor Location 0
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- %void = OpTypeVoid
- %11 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %_ptr_Input_v2float = OpTypePointer Input %v2float
- %In2 = OpVariable %_ptr_Input_v2float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In0 = OpVariable %_ptr_Input_float Input
- %In1 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %uint_32 = OpConstant %uint 32
- %_ptr_Function_float = OpTypePointer Function %float
- %float_0 = OpConstant %float 0
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %int = OpTypeInt 32 1
- %_Globals_ = OpTypeStruct %uint %int
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %nullexpr = OpExtInst %void %ext DebugExpression
- %src = OpExtInst %void %ext DebugSource %file_name
- %cu = OpExtInst %void %ext DebugCompilationUnit 1 4 %src HLSL
- %dbg_tf = OpExtInst %void %ext DebugTypeBasic %float_name %uint_32 Float
- %dbg_v2f = OpExtInst %void %ext DebugTypeVector %dbg_tf 2
- %main_ty = OpExtInst %void %ext DebugTypeFunction FlagIsProtected|FlagIsPrivate %void
- %dbg_main = OpExtInst %void %ext DebugFunction %main_name %main_ty %src 0 0 %cu %main_name FlagIsProtected|FlagIsPrivate 0 %main
- %dbg_foo = OpExtInst %void %ext DebugLocalVariable %f_name %dbg_v2f %src 0 0 %dbg_main FlagIsLocal
- %main = OpFunction %void None %11
- %25 = OpLabel
- %26 = OpLoad %v2float %In2
- %27 = OpLoad %float %In0
- %28 = OpLoad %float %In1
- %29 = OpFAdd %float %27 %28
- ; CHECK: [[repl:%\w+]] = OpLoad %v2float %In2
- ; CHECK-NOT: OpCompositeInsert
- ; CHECK: DebugValue {{%\w+}} [[repl:%\w+]]
- ; CHECK-NEXT: OpCompositeInsert %v2float %float_0 [[repl]] 0
- %35 = OpCompositeInsert %v2float %29 %26 0
- %value = OpExtInst %void %ext DebugValue %dbg_foo %35 %nullexpr
- %37 = OpCompositeInsert %v2float %float_0 %35 0
- %33 = OpVectorShuffle %v4float %37 %37 0 1 0 1
- OpStore %OutColor %33
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndMatch<DeadInsertElimPass>(text, true);
- }
- TEST_F(DeadInsertElimTest, PhiOverEmptyStruct) {
- // Reproducer for nullptr access error in MarkInsertChain
- // that occurs when processing a phi operation with an
- // empty struct result type.
- //
- // Note: Disassembly created from HLSL source with
- // dxc -T cs_6_6 -spirv -Oconfig=
- // --eliminate-dead-branches,--merge-return,--ssa-rewrite
- //
- // RWBuffer<float> buf;
- //
- // struct S { };
- //
- // S fn() {
- // S s = (S)0;
- // if (buf[0] > 0) {
- // return s;
- // }
- // return s;
- // }
- //
- // [numthreads(1,1,1)]
- // void main() {
- // fn();
- // }
- const std::string disassembly =
- R"(OpCapability Shader
- OpCapability SampledBuffer
- OpCapability ImageBuffer
- OpMemoryModel Logical GLSL450
- OpEntryPoint GLCompute %main "main"
- OpExecutionMode %main LocalSize 1 1 1
- OpSource HLSL 660
- OpName %S "S"
- OpName %type_buffer_image "type.buffer.image"
- OpName %buf "buf"
- OpName %main "main"
- OpName %src_main "src.main"
- OpName %bb_entry "bb.entry"
- OpName %fn "fn"
- OpName %bb_entry_0 "bb.entry"
- OpName %s "s"
- OpName %if_true "if.true"
- OpName %if_merge "if.merge"
- OpDecorate %buf DescriptorSet 0
- OpDecorate %buf Binding 0
- %S = OpTypeStruct
- %4 = OpConstantNull %S
- %uint = OpTypeInt 32 0
- %uint_0 = OpConstant %uint 0
- %float = OpTypeFloat 32
- %float_0 = OpConstant %float 0
- %type_buffer_image = OpTypeImage %float Buffer 2 0 0 2 R32f
- %_ptr_UniformConstant_type_buffer_image = OpTypePointer UniformConstant %type_buffer_image
- %void = OpTypeVoid
- %12 = OpTypeFunction %void
- %19 = OpTypeFunction %S
- %_ptr_Function_S = OpTypePointer Function %S
- %v4float = OpTypeVector %float 4
- %bool = OpTypeBool
- %buf = OpVariable %_ptr_UniformConstant_type_buffer_image UniformConstant
- %false = OpConstantFalse %bool
- %_ptr_Function_bool = OpTypePointer Function %bool
- %true = OpConstantTrue %bool
- %main = OpFunction %void None %12
- %13 = OpLabel
- %14 = OpFunctionCall %void %src_main
- OpReturn
- OpFunctionEnd
- %src_main = OpFunction %void None %12
- %bb_entry = OpLabel
- %17 = OpFunctionCall %S %fn
- OpReturn
- OpFunctionEnd
- %fn = OpFunction %S None %19
- %bb_entry_0 = OpLabel
- %39 = OpVariable %_ptr_Function_bool Function %false
- %34 = OpVariable %_ptr_Function_S Function
- %s = OpVariable %_ptr_Function_S Function
- OpSelectionMerge %33 None
- OpSwitch %uint_0 %36
- %36 = OpLabel
- OpStore %s %4
- %23 = OpLoad %type_buffer_image %buf
- %25 = OpImageRead %v4float %23 %uint_0 None
- %26 = OpCompositeExtract %float %25 0
- %28 = OpFOrdGreaterThan %bool %26 %float_0
- OpSelectionMerge %if_merge None
- OpBranchConditional %28 %if_true %if_merge
- %if_true = OpLabel
- OpStore %39 %true
- OpStore %34 %4
- OpBranch %33
- %if_merge = OpLabel
- OpStore %39 %true
- OpStore %34 %4
- OpBranch %33
- %33 = OpLabel
- %41 = OpPhi %S %4 %if_true %4 %if_merge
- OpReturnValue %41
- OpFunctionEnd
- )";
- // Used to crash with a nullptr access violation when processing %41
- SinglePassRunToBinary<DeadInsertElimPass>(disassembly, true);
- }
- // TODO(greg-lunarg): Add tests to verify handling of these cases:
- //
- } // namespace
- } // namespace opt
- } // namespace spvtools
|