optimizer_test.cpp 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511
  1. // Copyright (c) 2017 Google Inc.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. #include <string>
  15. #include <vector>
  16. #include "gmock/gmock.h"
  17. #include "spirv-tools/libspirv.hpp"
  18. #include "spirv-tools/optimizer.hpp"
  19. #include "test/opt/pass_fixture.h"
  20. namespace spvtools {
  21. namespace opt {
  22. namespace {
  23. using ::testing::Eq;
  24. // Return a string that contains the minimum instructions needed to form
  25. // a valid module. Other instructions can be appended to this string.
  26. std::string Header() {
  27. return R"(OpCapability Shader
  28. OpCapability Linkage
  29. OpMemoryModel Logical GLSL450
  30. )";
  31. }
  32. TEST(Optimizer, CanRunNullPassWithDistinctInputOutputVectors) {
  33. SpirvTools tools(SPV_ENV_UNIVERSAL_1_0);
  34. std::vector<uint32_t> binary_in;
  35. tools.Assemble(Header() + "OpName %foo \"foo\"\n%foo = OpTypeVoid",
  36. &binary_in);
  37. Optimizer opt(SPV_ENV_UNIVERSAL_1_0);
  38. opt.RegisterPass(CreateNullPass());
  39. std::vector<uint32_t> binary_out;
  40. opt.Run(binary_in.data(), binary_in.size(), &binary_out);
  41. std::string disassembly;
  42. tools.Disassemble(binary_out.data(), binary_out.size(), &disassembly);
  43. EXPECT_THAT(disassembly,
  44. Eq(Header() + "OpName %foo \"foo\"\n%foo = OpTypeVoid\n"));
  45. }
  46. TEST(Optimizer, CanRunTransformingPassWithDistinctInputOutputVectors) {
  47. SpirvTools tools(SPV_ENV_UNIVERSAL_1_0);
  48. std::vector<uint32_t> binary_in;
  49. tools.Assemble(Header() + "OpName %foo \"foo\"\n%foo = OpTypeVoid",
  50. &binary_in);
  51. Optimizer opt(SPV_ENV_UNIVERSAL_1_0);
  52. opt.RegisterPass(CreateStripDebugInfoPass());
  53. std::vector<uint32_t> binary_out;
  54. opt.Run(binary_in.data(), binary_in.size(), &binary_out);
  55. std::string disassembly;
  56. tools.Disassemble(binary_out.data(), binary_out.size(), &disassembly);
  57. EXPECT_THAT(disassembly, Eq(Header() + "%void = OpTypeVoid\n"));
  58. }
  59. TEST(Optimizer, CanRunNullPassWithAliasedVectors) {
  60. SpirvTools tools(SPV_ENV_UNIVERSAL_1_0);
  61. std::vector<uint32_t> binary;
  62. tools.Assemble("OpName %foo \"foo\"\n%foo = OpTypeVoid", &binary);
  63. Optimizer opt(SPV_ENV_UNIVERSAL_1_0);
  64. opt.RegisterPass(CreateNullPass());
  65. opt.Run(binary.data(), binary.size(), &binary); // This is the key.
  66. std::string disassembly;
  67. tools.Disassemble(binary.data(), binary.size(), &disassembly);
  68. EXPECT_THAT(disassembly, Eq("OpName %foo \"foo\"\n%foo = OpTypeVoid\n"));
  69. }
  70. TEST(Optimizer, CanRunNullPassWithAliasedVectorDataButDifferentSize) {
  71. SpirvTools tools(SPV_ENV_UNIVERSAL_1_0);
  72. std::vector<uint32_t> binary;
  73. tools.Assemble(Header() + "OpName %foo \"foo\"\n%foo = OpTypeVoid", &binary);
  74. Optimizer opt(SPV_ENV_UNIVERSAL_1_0);
  75. opt.RegisterPass(CreateNullPass());
  76. auto orig_size = binary.size();
  77. // Now change the size. Add a word that will be ignored
  78. // by the optimizer.
  79. binary.push_back(42);
  80. EXPECT_THAT(orig_size + 1, Eq(binary.size()));
  81. opt.Run(binary.data(), orig_size, &binary); // This is the key.
  82. // The binary vector should have been rewritten.
  83. EXPECT_THAT(binary.size(), Eq(orig_size));
  84. std::string disassembly;
  85. tools.Disassemble(binary.data(), binary.size(), &disassembly);
  86. EXPECT_THAT(disassembly,
  87. Eq(Header() + "OpName %foo \"foo\"\n%foo = OpTypeVoid\n"));
  88. }
  89. TEST(Optimizer, CanRunTransformingPassWithAliasedVectors) {
  90. SpirvTools tools(SPV_ENV_UNIVERSAL_1_0);
  91. std::vector<uint32_t> binary;
  92. tools.Assemble(Header() + "OpName %foo \"foo\"\n%foo = OpTypeVoid", &binary);
  93. Optimizer opt(SPV_ENV_UNIVERSAL_1_0);
  94. opt.RegisterPass(CreateStripDebugInfoPass());
  95. opt.Run(binary.data(), binary.size(), &binary); // This is the key
  96. std::string disassembly;
  97. tools.Disassemble(binary.data(), binary.size(), &disassembly);
  98. EXPECT_THAT(disassembly, Eq(Header() + "%void = OpTypeVoid\n"));
  99. }
  100. TEST(Optimizer, CanValidateFlags) {
  101. Optimizer opt(SPV_ENV_UNIVERSAL_1_0);
  102. EXPECT_FALSE(opt.FlagHasValidForm("bad-flag"));
  103. EXPECT_TRUE(opt.FlagHasValidForm("-O"));
  104. EXPECT_TRUE(opt.FlagHasValidForm("-Os"));
  105. EXPECT_FALSE(opt.FlagHasValidForm("-O2"));
  106. EXPECT_TRUE(opt.FlagHasValidForm("--this_flag"));
  107. }
  108. TEST(Optimizer, CanRegisterPassesFromFlags) {
  109. SpirvTools tools(SPV_ENV_UNIVERSAL_1_0);
  110. Optimizer opt(SPV_ENV_UNIVERSAL_1_0);
  111. spv_message_level_t msg_level;
  112. const char* msg_fname;
  113. spv_position_t msg_position;
  114. const char* msg;
  115. auto examine_message = [&msg_level, &msg_fname, &msg_position, &msg](
  116. spv_message_level_t ml, const char* f,
  117. const spv_position_t& p, const char* m) {
  118. msg_level = ml;
  119. msg_fname = f;
  120. msg_position = p;
  121. msg = m;
  122. };
  123. opt.SetMessageConsumer(examine_message);
  124. std::vector<std::string> pass_flags = {
  125. "--strip-debug",
  126. "--strip-nonsemantic",
  127. "--set-spec-const-default-value=23:42 21:12",
  128. "--if-conversion",
  129. "--freeze-spec-const",
  130. "--inline-entry-points-exhaustive",
  131. "--inline-entry-points-opaque",
  132. "--convert-local-access-chains",
  133. "--eliminate-dead-code-aggressive",
  134. "--eliminate-insert-extract",
  135. "--eliminate-local-single-block",
  136. "--eliminate-local-single-store",
  137. "--merge-blocks",
  138. "--merge-return",
  139. "--eliminate-dead-branches",
  140. "--eliminate-dead-functions",
  141. "--eliminate-local-multi-store",
  142. "--eliminate-dead-const",
  143. "--eliminate-dead-inserts",
  144. "--eliminate-dead-variables",
  145. "--fold-spec-const-op-composite",
  146. "--loop-unswitch",
  147. "--scalar-replacement=300",
  148. "--scalar-replacement",
  149. "--strength-reduction",
  150. "--unify-const",
  151. "--flatten-decorations",
  152. "--compact-ids",
  153. "--cfg-cleanup",
  154. "--local-redundancy-elimination",
  155. "--loop-invariant-code-motion",
  156. "--reduce-load-size",
  157. "--redundancy-elimination",
  158. "--private-to-local",
  159. "--remove-duplicates",
  160. "--workaround-1209",
  161. "--replace-invalid-opcode",
  162. "--simplify-instructions",
  163. "--ssa-rewrite",
  164. "--copy-propagate-arrays",
  165. "--loop-fission=20",
  166. "--loop-fusion=2",
  167. "--loop-unroll",
  168. "--vector-dce",
  169. "--loop-unroll-partial=3",
  170. "--loop-peeling",
  171. "--ccp",
  172. "-O",
  173. "-Os",
  174. "--legalize-hlsl"};
  175. EXPECT_TRUE(opt.RegisterPassesFromFlags(pass_flags));
  176. // Test some invalid flags.
  177. EXPECT_FALSE(opt.RegisterPassFromFlag("-O2"));
  178. EXPECT_EQ(msg_level, SPV_MSG_ERROR);
  179. EXPECT_FALSE(opt.RegisterPassFromFlag("-loop-unroll"));
  180. EXPECT_EQ(msg_level, SPV_MSG_ERROR);
  181. EXPECT_FALSE(opt.RegisterPassFromFlag("--set-spec-const-default-value"));
  182. EXPECT_EQ(msg_level, SPV_MSG_ERROR);
  183. EXPECT_FALSE(opt.RegisterPassFromFlag("--scalar-replacement=s"));
  184. EXPECT_EQ(msg_level, SPV_MSG_ERROR);
  185. EXPECT_FALSE(opt.RegisterPassFromFlag("--loop-fission=-4"));
  186. EXPECT_EQ(msg_level, SPV_MSG_ERROR);
  187. EXPECT_FALSE(opt.RegisterPassFromFlag("--loop-fusion=xx"));
  188. EXPECT_EQ(msg_level, SPV_MSG_ERROR);
  189. EXPECT_FALSE(opt.RegisterPassFromFlag("--loop-unroll-partial"));
  190. EXPECT_EQ(msg_level, SPV_MSG_ERROR);
  191. }
  192. TEST(Optimizer, RemoveNop) {
  193. // Test that OpNops are removed even if no optimizations are run.
  194. const std::string before = R"(OpCapability Shader
  195. OpCapability Linkage
  196. OpMemoryModel Logical GLSL450
  197. %void = OpTypeVoid
  198. %2 = OpTypeFunction %void
  199. %3 = OpFunction %void None %2
  200. %4 = OpLabel
  201. OpNop
  202. OpReturn
  203. OpFunctionEnd
  204. )";
  205. const std::string after = R"(OpCapability Shader
  206. OpCapability Linkage
  207. OpMemoryModel Logical GLSL450
  208. %void = OpTypeVoid
  209. %2 = OpTypeFunction %void
  210. %3 = OpFunction %void None %2
  211. %4 = OpLabel
  212. OpReturn
  213. OpFunctionEnd
  214. )";
  215. std::vector<uint32_t> binary;
  216. {
  217. SpirvTools tools(SPV_ENV_VULKAN_1_1);
  218. tools.Assemble(before, &binary);
  219. }
  220. Optimizer opt(SPV_ENV_VULKAN_1_1);
  221. std::vector<uint32_t> optimized;
  222. class ValidatorOptions validator_options;
  223. ASSERT_TRUE(opt.Run(binary.data(), binary.size(), &optimized,
  224. validator_options, true))
  225. << before << "\n";
  226. std::string disassembly;
  227. {
  228. SpirvTools tools(SPV_ENV_VULKAN_1_1);
  229. tools.Disassemble(optimized.data(), optimized.size(), &disassembly);
  230. }
  231. EXPECT_EQ(after, disassembly)
  232. << "Was expecting the OpNop to have been removed.";
  233. }
  234. TEST(Optimizer, AvoidIntegrityCheckForExtraLineInfo) {
  235. // Test that it avoids the integrity check when no optimizations are run and
  236. // OpLines are propagated.
  237. const std::string before = R"(OpCapability Shader
  238. OpCapability Linkage
  239. OpMemoryModel Logical GLSL450
  240. %1 = OpString "Test"
  241. %void = OpTypeVoid
  242. %3 = OpTypeFunction %void
  243. %uint = OpTypeInt 32 0
  244. %_ptr_Function_uint = OpTypePointer Function %uint
  245. %6 = OpFunction %void None %3
  246. %7 = OpLabel
  247. OpLine %1 10 0
  248. %8 = OpVariable %_ptr_Function_uint Function
  249. OpLine %1 10 0
  250. %9 = OpVariable %_ptr_Function_uint Function
  251. OpLine %1 20 0
  252. OpReturn
  253. OpFunctionEnd
  254. )";
  255. const std::string after = R"(OpCapability Shader
  256. OpCapability Linkage
  257. OpMemoryModel Logical GLSL450
  258. %1 = OpString "Test"
  259. %void = OpTypeVoid
  260. %3 = OpTypeFunction %void
  261. %uint = OpTypeInt 32 0
  262. %_ptr_Function_uint = OpTypePointer Function %uint
  263. %6 = OpFunction %void None %3
  264. %7 = OpLabel
  265. OpLine %1 10 0
  266. %8 = OpVariable %_ptr_Function_uint Function
  267. %9 = OpVariable %_ptr_Function_uint Function
  268. OpLine %1 20 0
  269. OpReturn
  270. OpFunctionEnd
  271. )";
  272. std::vector<uint32_t> binary;
  273. SpirvTools tools(SPV_ENV_VULKAN_1_1);
  274. tools.Assemble(before, &binary);
  275. Optimizer opt(SPV_ENV_VULKAN_1_1);
  276. std::vector<uint32_t> optimized;
  277. class ValidatorOptions validator_options;
  278. ASSERT_TRUE(opt.Run(binary.data(), binary.size(), &optimized,
  279. validator_options, true))
  280. << before << "\n";
  281. std::string disassembly;
  282. tools.Disassemble(optimized.data(), optimized.size(), &disassembly);
  283. EXPECT_EQ(after, disassembly)
  284. << "Was expecting the OpLine to have been propagated.";
  285. }
  286. TEST(Optimizer, AvoidIntegrityCheckForDebugScope) {
  287. // Test that it avoids the integrity check when the code contains DebugScope.
  288. const std::string before = R"(OpCapability Shader
  289. %1 = OpExtInstImport "OpenCL.DebugInfo.100"
  290. OpMemoryModel Logical GLSL450
  291. OpEntryPoint Fragment %main "main"
  292. OpExecutionMode %main OriginUpperLeft
  293. %3 = OpString "simple_vs.hlsl"
  294. OpSource HLSL 600 %3
  295. OpName %main "main"
  296. %void = OpTypeVoid
  297. %5 = OpTypeFunction %void
  298. %6 = OpExtInst %void %1 DebugSource %3
  299. %7 = OpExtInst %void %1 DebugCompilationUnit 2 4 %6 HLSL
  300. %main = OpFunction %void None %5
  301. %14 = OpLabel
  302. %26 = OpExtInst %void %1 DebugScope %7
  303. OpReturn
  304. %27 = OpExtInst %void %1 DebugNoScope
  305. OpFunctionEnd
  306. )";
  307. const std::string after = R"(OpCapability Shader
  308. %1 = OpExtInstImport "OpenCL.DebugInfo.100"
  309. OpMemoryModel Logical GLSL450
  310. OpEntryPoint Fragment %main "main"
  311. OpExecutionMode %main OriginUpperLeft
  312. %3 = OpString "simple_vs.hlsl"
  313. OpSource HLSL 600 %3
  314. OpName %main "main"
  315. %void = OpTypeVoid
  316. %5 = OpTypeFunction %void
  317. %6 = OpExtInst %void %1 DebugSource %3
  318. %7 = OpExtInst %void %1 DebugCompilationUnit 2 4 %6 HLSL
  319. %main = OpFunction %void None %5
  320. %8 = OpLabel
  321. %11 = OpExtInst %void %1 DebugScope %7
  322. OpReturn
  323. %12 = OpExtInst %void %1 DebugNoScope
  324. OpFunctionEnd
  325. )";
  326. std::vector<uint32_t> binary;
  327. SpirvTools tools(SPV_ENV_VULKAN_1_1);
  328. tools.Assemble(before, &binary);
  329. Optimizer opt(SPV_ENV_VULKAN_1_1);
  330. std::vector<uint32_t> optimized;
  331. ASSERT_TRUE(opt.Run(binary.data(), binary.size(), &optimized))
  332. << before << "\n";
  333. std::string disassembly;
  334. tools.Disassemble(optimized.data(), optimized.size(), &disassembly);
  335. EXPECT_EQ(after, disassembly)
  336. << "Was expecting the result id of DebugScope to have been changed.";
  337. }
  338. TEST(Optimizer, CheckDefaultPerformancePassesLargeStructScalarization) {
  339. std::string start = R"(OpCapability Shader
  340. %1 = OpExtInstImport "GLSL.std.450"
  341. OpMemoryModel Logical GLSL450
  342. OpEntryPoint Vertex %4 "main" %46 %48
  343. OpSource GLSL 430
  344. OpName %4 "main"
  345. OpDecorate %44 Block
  346. OpMemberDecorate %44 0 BuiltIn Position
  347. OpMemberDecorate %44 1 BuiltIn PointSize
  348. OpMemberDecorate %44 2 BuiltIn ClipDistance
  349. OpDecorate %48 Location 0
  350. %2 = OpTypeVoid
  351. %3 = OpTypeFunction %2
  352. %6 = OpTypeFloat 32
  353. %7 = OpTypeVector %6 4
  354. %8 = OpTypePointer Function %7
  355. %9 = OpTypeStruct %7)";
  356. // add 200 float members to the struct
  357. for (int i = 0; i < 200; i++) {
  358. start += " %6";
  359. }
  360. start += R"(
  361. %10 = OpTypeFunction %9 %8
  362. %14 = OpTypeFunction %6 %9
  363. %18 = OpTypePointer Function %9
  364. %20 = OpTypeInt 32 1
  365. %21 = OpConstant %20 0
  366. %24 = OpConstant %20 1
  367. %25 = OpTypeInt 32 0
  368. %26 = OpConstant %25 1
  369. %27 = OpTypePointer Function %6
  370. %43 = OpTypeArray %6 %26
  371. %44 = OpTypeStruct %7 %6 %43
  372. %45 = OpTypePointer Output %44
  373. %46 = OpVariable %45 Output
  374. %47 = OpTypePointer Input %7
  375. %48 = OpVariable %47 Input
  376. %54 = OpTypePointer Output %7
  377. %4 = OpFunction %2 None %3
  378. %5 = OpLabel
  379. %49 = OpVariable %8 Function
  380. %50 = OpLoad %7 %48
  381. OpStore %49 %50
  382. %51 = OpFunctionCall %9 %12 %49
  383. %52 = OpFunctionCall %6 %16 %51
  384. %53 = OpCompositeConstruct %7 %52 %52 %52 %52
  385. %55 = OpAccessChain %54 %46 %21
  386. OpStore %55 %53
  387. OpReturn
  388. OpFunctionEnd
  389. %12 = OpFunction %9 None %10
  390. %11 = OpFunctionParameter %8
  391. %13 = OpLabel
  392. %19 = OpVariable %18 Function
  393. %22 = OpLoad %7 %11
  394. %23 = OpAccessChain %8 %19 %21
  395. OpStore %23 %22
  396. %28 = OpAccessChain %27 %11 %26
  397. %29 = OpLoad %6 %28
  398. %30 = OpConvertFToS %20 %29
  399. %31 = OpAccessChain %27 %19 %21 %30
  400. %32 = OpLoad %6 %31
  401. %33 = OpAccessChain %27 %19 %24
  402. OpStore %33 %32
  403. %34 = OpLoad %9 %19
  404. OpReturnValue %34
  405. OpFunctionEnd
  406. %16 = OpFunction %6 None %14
  407. %15 = OpFunctionParameter %9
  408. %17 = OpLabel
  409. %37 = OpCompositeExtract %6 %15 1
  410. %38 = OpConvertFToS %20 %37
  411. %39 = OpCompositeExtract %7 %15 0
  412. %40 = OpVectorExtractDynamic %6 %39 %38
  413. OpReturnValue %40
  414. OpFunctionEnd)";
  415. std::vector<uint32_t> binary;
  416. SpirvTools tools(SPV_ENV_VULKAN_1_3);
  417. tools.Assemble(start, &binary,
  418. SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
  419. std::string test_disassembly;
  420. std::string default_disassembly;
  421. {
  422. Optimizer opt(SPV_ENV_VULKAN_1_3);
  423. opt.RegisterPerformancePasses();
  424. std::vector<uint32_t> optimized;
  425. ASSERT_TRUE(opt.Run(binary.data(), binary.size(), &optimized))
  426. << start << "\n";
  427. tools.Disassemble(optimized.data(), optimized.size(), &default_disassembly,
  428. SPV_BINARY_TO_TEXT_OPTION_NO_HEADER);
  429. }
  430. {
  431. // default passes should not benefit from additional scalar replacement
  432. Optimizer opt(SPV_ENV_VULKAN_1_3);
  433. opt.RegisterPerformancePasses()
  434. .RegisterPass(CreateScalarReplacementPass(201))
  435. .RegisterPass(CreateAggressiveDCEPass());
  436. std::vector<uint32_t> optimized;
  437. ASSERT_TRUE(opt.Run(binary.data(), binary.size(), &optimized))
  438. << start << "\n";
  439. tools.Disassemble(optimized.data(), optimized.size(), &test_disassembly,
  440. SPV_BINARY_TO_TEXT_OPTION_NO_HEADER);
  441. }
  442. EXPECT_EQ(test_disassembly, default_disassembly);
  443. }
  444. } // namespace
  445. } // namespace opt
  446. } // namespace spvtools