| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422 |
- // Copyright (c) 2018 Google LLC
- //
- // Licensed under the Apache License, Version 2.0 (the "License");
- // you may not use this file except in compliance with the License.
- // You may obtain a copy of the License at
- //
- // http://www.apache.org/licenses/LICENSE-2.0
- //
- // Unless required by applicable law or agreed to in writing, software
- // distributed under the License is distributed on an "AS IS" BASIS,
- // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- // See the License for the specific language governing permissions and
- // limitations under the License.
- #include <string>
- #include "test/opt/pass_fixture.h"
- #include "test/opt/pass_utils.h"
- namespace spvtools {
- namespace opt {
- namespace {
- using VectorDCETest = PassTest<::testing::Test>;
- TEST_F(VectorDCETest, InsertAfterInsertElim) {
- // With two insertions to the same offset, the first is dead.
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) in float In0;
- // layout (location=1) in float In1;
- // layout (location=2) in vec2 In2;
- // layout (location=0) out vec4 OutColor;
- //
- // void main()
- // {
- // vec2 v = In2;
- // v.x = In0 + In1; // dead
- // v.x = 0.0;
- // OutColor = v.xyxy;
- // }
- const std::string before_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In2 %In0 %In1 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In2 "In2"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %OutColor "OutColor"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_n"
- OpName %_ ""
- OpDecorate %In2 Location 2
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %OutColor Location 0
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- %void = OpTypeVoid
- %11 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %_ptr_Input_v2float = OpTypePointer Input %v2float
- %In2 = OpVariable %_ptr_Input_v2float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In0 = OpVariable %_ptr_Input_float Input
- %In1 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_ptr_Function_float = OpTypePointer Function %float
- %float_0 = OpConstant %float 0
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %int = OpTypeInt 32 1
- %_Globals_ = OpTypeStruct %uint %int
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- )";
- const std::string after_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In2 %In0 %In1 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In2 "In2"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %OutColor "OutColor"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_n"
- OpName %_ ""
- OpDecorate %In2 Location 2
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %OutColor Location 0
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %_ptr_Input_v2float = OpTypePointer Input %v2float
- %In2 = OpVariable %_ptr_Input_v2float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In0 = OpVariable %_ptr_Input_float Input
- %In1 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_ptr_Function_float = OpTypePointer Function %float
- %float_0 = OpConstant %float 0
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %int = OpTypeInt 32 1
- %_Globals_ = OpTypeStruct %uint %int
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- )";
- const std::string before =
- R"(%main = OpFunction %void None %11
- %25 = OpLabel
- %26 = OpLoad %v2float %In2
- %27 = OpLoad %float %In0
- %28 = OpLoad %float %In1
- %29 = OpFAdd %float %27 %28
- %35 = OpCompositeInsert %v2float %29 %26 0
- %37 = OpCompositeInsert %v2float %float_0 %35 0
- %33 = OpVectorShuffle %v4float %37 %37 0 1 0 1
- OpStore %OutColor %33
- OpReturn
- OpFunctionEnd
- )";
- const std::string after =
- R"(%main = OpFunction %void None %10
- %23 = OpLabel
- %24 = OpLoad %v2float %In2
- %25 = OpLoad %float %In0
- %26 = OpLoad %float %In1
- %27 = OpFAdd %float %25 %26
- %28 = OpCompositeInsert %v2float %27 %24 0
- %29 = OpCompositeInsert %v2float %float_0 %24 0
- %30 = OpVectorShuffle %v4float %29 %29 0 1 0 1
- OpStore %OutColor %30
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndCheck<VectorDCE>(before_predefs + before,
- after_predefs + after, true, true);
- }
- TEST_F(VectorDCETest, DeadInsertInChainWithPhi) {
- // Dead insert eliminated with phi in insertion chain.
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) in vec4 In0;
- // layout (location=1) in float In1;
- // layout (location=2) in float In2;
- // layout (location=0) out vec4 OutColor;
- //
- // layout(std140, binding = 0 ) uniform _Globals_
- // {
- // bool g_b;
- // };
- //
- // void main()
- // {
- // vec4 v = In0;
- // v.z = In1 + In2;
- // if (g_b) v.w = 1.0;
- // OutColor = vec4(v.x,v.y,0.0,v.w);
- // }
- const std::string before_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %In2 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %11 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_ptr_Function_float = OpTypePointer Function %float
- %_Globals_ = OpTypeStruct %uint
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %_ptr_Uniform_uint = OpTypePointer Uniform %uint
- %bool = OpTypeBool
- %uint_0 = OpConstant %uint 0
- %float_1 = OpConstant %float 1
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %float_0 = OpConstant %float 0
- )";
- const std::string after_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %In2 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_ptr_Function_float = OpTypePointer Function %float
- %_Globals_ = OpTypeStruct %uint
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %_ptr_Uniform_uint = OpTypePointer Uniform %uint
- %bool = OpTypeBool
- %uint_0 = OpConstant %uint 0
- %float_1 = OpConstant %float 1
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %float_0 = OpConstant %float 0
- )";
- const std::string before =
- R"(%main = OpFunction %void None %11
- %31 = OpLabel
- %32 = OpLoad %v4float %In0
- %33 = OpLoad %float %In1
- %34 = OpLoad %float %In2
- %35 = OpFAdd %float %33 %34
- %51 = OpCompositeInsert %v4float %35 %32 2
- %37 = OpAccessChain %_ptr_Uniform_uint %_ %int_0
- %38 = OpLoad %uint %37
- %39 = OpINotEqual %bool %38 %uint_0
- OpSelectionMerge %40 None
- OpBranchConditional %39 %41 %40
- %41 = OpLabel
- %53 = OpCompositeInsert %v4float %float_1 %51 3
- OpBranch %40
- %40 = OpLabel
- %60 = OpPhi %v4float %51 %31 %53 %41
- %55 = OpCompositeExtract %float %60 0
- %57 = OpCompositeExtract %float %60 1
- %59 = OpCompositeExtract %float %60 3
- %49 = OpCompositeConstruct %v4float %55 %57 %float_0 %59
- OpStore %OutColor %49
- OpReturn
- OpFunctionEnd
- )";
- const std::string after =
- R"(%main = OpFunction %void None %10
- %27 = OpLabel
- %28 = OpLoad %v4float %In0
- %29 = OpLoad %float %In1
- %30 = OpLoad %float %In2
- %31 = OpFAdd %float %29 %30
- %32 = OpCompositeInsert %v4float %31 %28 2
- %33 = OpAccessChain %_ptr_Uniform_uint %_ %int_0
- %34 = OpLoad %uint %33
- %35 = OpINotEqual %bool %34 %uint_0
- OpSelectionMerge %36 None
- OpBranchConditional %35 %37 %36
- %37 = OpLabel
- %38 = OpCompositeInsert %v4float %float_1 %28 3
- OpBranch %36
- %36 = OpLabel
- %39 = OpPhi %v4float %28 %27 %38 %37
- %40 = OpCompositeExtract %float %39 0
- %41 = OpCompositeExtract %float %39 1
- %42 = OpCompositeExtract %float %39 3
- %43 = OpCompositeConstruct %v4float %40 %41 %float_0 %42
- OpStore %OutColor %43
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndCheck<VectorDCE>(before_predefs + before,
- after_predefs + after, true, true);
- }
- TEST_F(VectorDCETest, DeadInsertWithScalars) {
- // Dead insert which requires two passes to eliminate
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) in vec4 In0;
- // layout (location=1) in float In1;
- // layout (location=2) in float In2;
- // layout (location=0) out vec4 OutColor;
- //
- // layout(std140, binding = 0 ) uniform _Globals_
- // {
- // bool g_b;
- // bool g_b2;
- // };
- //
- // void main()
- // {
- // vec4 v1, v2;
- // v1 = In0;
- // v1.y = In1 + In2; // dead, second pass
- // if (g_b) v1.x = 1.0;
- // v2.x = v1.x;
- // v2.y = v1.y; // dead, first pass
- // if (g_b2) v2.x = 0.0;
- // OutColor = vec4(v2.x,v2.x,0.0,1.0);
- // }
- const std::string before_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %In2 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_b2"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_Globals_ = OpTypeStruct %uint %uint
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %_ptr_Uniform_uint = OpTypePointer Uniform %uint
- %bool = OpTypeBool
- %uint_0 = OpConstant %uint 0
- %float_1 = OpConstant %float 1
- %int_1 = OpConstant %int 1
- %float_0 = OpConstant %float 0
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %27 = OpUndef %v4float
- )";
- const std::string after_predefs =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %In2 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_b2"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %_Globals_ = OpTypeStruct %uint %uint
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %_ptr_Uniform_uint = OpTypePointer Uniform %uint
- %bool = OpTypeBool
- %uint_0 = OpConstant %uint 0
- %float_1 = OpConstant %float 1
- %int_1 = OpConstant %int 1
- %float_0 = OpConstant %float 0
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %27 = OpUndef %v4float
- %55 = OpUndef %v4float
- )";
- const std::string before =
- R"(%main = OpFunction %void None %10
- %28 = OpLabel
- %29 = OpLoad %v4float %In0
- %30 = OpLoad %float %In1
- %31 = OpLoad %float %In2
- %32 = OpFAdd %float %30 %31
- %33 = OpCompositeInsert %v4float %32 %29 1
- %34 = OpAccessChain %_ptr_Uniform_uint %_ %int_0
- %35 = OpLoad %uint %34
- %36 = OpINotEqual %bool %35 %uint_0
- OpSelectionMerge %37 None
- OpBranchConditional %36 %38 %37
- %38 = OpLabel
- %39 = OpCompositeInsert %v4float %float_1 %33 0
- OpBranch %37
- %37 = OpLabel
- %40 = OpPhi %v4float %33 %28 %39 %38
- %41 = OpCompositeExtract %float %40 0
- %42 = OpCompositeInsert %v4float %41 %27 0
- %43 = OpCompositeExtract %float %40 1
- %44 = OpCompositeInsert %v4float %43 %42 1
- %45 = OpAccessChain %_ptr_Uniform_uint %_ %int_1
- %46 = OpLoad %uint %45
- %47 = OpINotEqual %bool %46 %uint_0
- OpSelectionMerge %48 None
- OpBranchConditional %47 %49 %48
- %49 = OpLabel
- %50 = OpCompositeInsert %v4float %float_0 %44 0
- OpBranch %48
- %48 = OpLabel
- %51 = OpPhi %v4float %44 %37 %50 %49
- %52 = OpCompositeExtract %float %51 0
- %53 = OpCompositeExtract %float %51 0
- %54 = OpCompositeConstruct %v4float %52 %53 %float_0 %float_1
- OpStore %OutColor %54
- OpReturn
- OpFunctionEnd
- )";
- const std::string after =
- R"(%main = OpFunction %void None %10
- %28 = OpLabel
- %29 = OpLoad %v4float %In0
- %30 = OpLoad %float %In1
- %31 = OpLoad %float %In2
- %32 = OpFAdd %float %30 %31
- %33 = OpCompositeInsert %v4float %32 %29 1
- %34 = OpAccessChain %_ptr_Uniform_uint %_ %int_0
- %35 = OpLoad %uint %34
- %36 = OpINotEqual %bool %35 %uint_0
- OpSelectionMerge %37 None
- OpBranchConditional %36 %38 %37
- %38 = OpLabel
- %39 = OpCompositeInsert %v4float %float_1 %55 0
- OpBranch %37
- %37 = OpLabel
- %40 = OpPhi %v4float %29 %28 %39 %38
- %41 = OpCompositeExtract %float %40 0
- %42 = OpCompositeInsert %v4float %41 %55 0
- %43 = OpCompositeExtract %float %40 1
- %44 = OpCompositeInsert %v4float %43 %42 1
- %45 = OpAccessChain %_ptr_Uniform_uint %_ %int_1
- %46 = OpLoad %uint %45
- %47 = OpINotEqual %bool %46 %uint_0
- OpSelectionMerge %48 None
- OpBranchConditional %47 %49 %48
- %49 = OpLabel
- %50 = OpCompositeInsert %v4float %float_0 %55 0
- OpBranch %48
- %48 = OpLabel
- %51 = OpPhi %v4float %42 %37 %50 %49
- %52 = OpCompositeExtract %float %51 0
- %53 = OpCompositeExtract %float %51 0
- %54 = OpCompositeConstruct %v4float %52 %53 %float_0 %float_1
- OpStore %OutColor %54
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndCheck<VectorDCE>(before_predefs + before,
- after_predefs + after, true, true);
- }
- TEST_F(VectorDCETest, InsertObjectLive) {
- // Make sure that the object being inserted in an OpCompositeInsert
- // is not removed when it is uses later on.
- const std::string before =
- R"(OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %In1 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %main = OpFunction %void None %10
- %28 = OpLabel
- %29 = OpLoad %v4float %In0
- %30 = OpLoad %float %In1
- %33 = OpCompositeInsert %v4float %30 %29 1
- OpStore %OutColor %33
- OpReturn
- OpFunctionEnd
- )";
- SetAssembleOptions(SPV_TEXT_TO_BINARY_OPTION_PRESERVE_NUMERIC_IDS);
- SinglePassRunAndCheck<VectorDCE>(before, before, true, true);
- }
- TEST_F(VectorDCETest, DeadInsertInCycle) {
- // Dead insert in chain with cycle. Demonstrates analysis can handle
- // cycles in chains going through scalars intermediate values.
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) in vec4 In0;
- // layout (location=1) in float In1;
- // layout (location=2) in float In2;
- // layout (location=0) out vec4 OutColor;
- //
- // layout(std140, binding = 0 ) uniform _Globals_
- // {
- // int g_n ;
- // };
- //
- // void main()
- // {
- // vec2 v = vec2(0.0, 1.0);
- // for (int i = 0; i < g_n; i++) {
- // v.x = v.x + 1;
- // v.y = v.y * 0.9; // dead
- // }
- // OutColor = vec4(v.x);
- // }
- const std::string assembly =
- R"(
- ; CHECK: [[init_val:%\w+]] = OpConstantComposite %v2float %float_0 %float_1
- ; CHECK: [[undef:%\w+]] = OpUndef %v2float
- ; CHECK: OpFunction
- ; CHECK: [[entry_lab:%\w+]] = OpLabel
- ; CHECK: [[loop_header:%\w+]] = OpLabel
- ; CHECK: OpPhi %v2float [[init_val]] [[entry_lab]] [[x_insert:%\w+]] {{%\w+}}
- ; CHECK: [[x_insert:%\w+]] = OpCompositeInsert %v2float %43 [[undef]] 0
- OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %OutColor %In0 %In1 %In2
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpName %main "main"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_n"
- OpName %_ ""
- OpName %OutColor "OutColor"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %In2 "In2"
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- OpDecorate %OutColor Location 0
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %In2 Location 2
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %float_0 = OpConstant %float 0
- %float_1 = OpConstant %float 1
- %16 = OpConstantComposite %v2float %float_0 %float_1
- %int = OpTypeInt 32 1
- %_ptr_Function_int = OpTypePointer Function %int
- %int_0 = OpConstant %int 0
- %_Globals_ = OpTypeStruct %int
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %_ptr_Uniform_int = OpTypePointer Uniform %int
- %bool = OpTypeBool
- %float_0_75 = OpConstant %float 0.75
- %int_1 = OpConstant %int 1
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In1 = OpVariable %_ptr_Input_float Input
- %In2 = OpVariable %_ptr_Input_float Input
- %main = OpFunction %void None %10
- %29 = OpLabel
- OpBranch %30
- %30 = OpLabel
- %31 = OpPhi %v2float %16 %29 %32 %33
- %34 = OpPhi %int %int_0 %29 %35 %33
- OpLoopMerge %36 %33 None
- OpBranch %37
- %37 = OpLabel
- %38 = OpAccessChain %_ptr_Uniform_int %_ %int_0
- %39 = OpLoad %int %38
- %40 = OpSLessThan %bool %34 %39
- OpBranchConditional %40 %41 %36
- %41 = OpLabel
- %42 = OpCompositeExtract %float %31 0
- %43 = OpFAdd %float %42 %float_1
- %44 = OpCompositeInsert %v2float %43 %31 0
- %45 = OpCompositeExtract %float %44 1
- %46 = OpFMul %float %45 %float_0_75
- %32 = OpCompositeInsert %v2float %46 %44 1
- OpBranch %33
- %33 = OpLabel
- %35 = OpIAdd %int %34 %int_1
- OpBranch %30
- %36 = OpLabel
- %47 = OpCompositeExtract %float %31 0
- %48 = OpCompositeConstruct %v4float %47 %47 %47 %47
- OpStore %OutColor %48
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndMatch<VectorDCE>(assembly, true);
- }
- TEST_F(VectorDCETest, DeadLoadFeedingCompositeConstruct) {
- // Detach the loads feeding the CompositeConstruct for the unused elements.
- // TODO: Implement the rewrite for CompositeConstruct.
- const std::string assembly =
- R"(
- ; CHECK: [[undef:%\w+]] = OpUndef %float
- ; CHECK: [[ac:%\w+]] = OpAccessChain %_ptr_Input_float %In0 %uint_2
- ; CHECK: [[load:%\w+]] = OpLoad %float [[ac]]
- ; CHECK: OpCompositeConstruct %v3float [[load]] [[undef]] [[undef]]
- OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpSourceExtension "GL_GOOGLE_cpp_style_line_directive"
- OpSourceExtension "GL_GOOGLE_include_directive"
- OpName %main "main"
- OpName %In0 "In0"
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %6 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %uint = OpTypeInt 32 0
- %uint_0 = OpConstant %uint 0
- %_ptr_Input_float = OpTypePointer Input %float
- %uint_1 = OpConstant %uint 1
- %uint_2 = OpConstant %uint 2
- %v3float = OpTypeVector %float 3
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %int_20 = OpConstant %int 20
- %bool = OpTypeBool
- %float_1 = OpConstant %float 1
- %int_1 = OpConstant %int 1
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %23 = OpUndef %v3float
- %main = OpFunction %void None %6
- %24 = OpLabel
- %25 = OpAccessChain %_ptr_Input_float %In0 %uint_0
- %26 = OpLoad %float %25
- %27 = OpAccessChain %_ptr_Input_float %In0 %uint_1
- %28 = OpLoad %float %27
- %29 = OpAccessChain %_ptr_Input_float %In0 %uint_2
- %30 = OpLoad %float %29
- %31 = OpCompositeConstruct %v3float %30 %28 %26
- OpBranch %32
- %32 = OpLabel
- %33 = OpPhi %v3float %31 %24 %34 %35
- %36 = OpPhi %int %int_0 %24 %37 %35
- OpLoopMerge %38 %35 None
- OpBranch %39
- %39 = OpLabel
- %40 = OpSLessThan %bool %36 %int_20
- OpBranchConditional %40 %41 %38
- %41 = OpLabel
- %42 = OpCompositeExtract %float %33 0
- %43 = OpFAdd %float %42 %float_1
- %34 = OpCompositeInsert %v3float %43 %33 0
- OpBranch %35
- %35 = OpLabel
- %37 = OpIAdd %int %36 %int_1
- OpBranch %32
- %38 = OpLabel
- %44 = OpCompositeExtract %float %33 0
- %45 = OpCompositeConstruct %v4float %44 %44 %44 %44
- OpStore %OutColor %45
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndMatch<VectorDCE>(assembly, true);
- }
- TEST_F(VectorDCETest, DeadLoadFeedingVectorShuffle) {
- // Detach the loads feeding the CompositeConstruct for the unused elements.
- // TODO: Implement the rewrite for CompositeConstruct.
- const std::string assembly =
- R"(
- ; MemPass Type2Undef does not reuse and already existing undef.
- ; CHECK: {{%\w+}} = OpUndef %v3float
- ; CHECK: [[undef:%\w+]] = OpUndef %v3float
- ; CHECK: OpFunction
- ; CHECK: OpVectorShuffle %v3float {{%\w+}} [[undef]] 0 4 5
- OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpSourceExtension "GL_GOOGLE_cpp_style_line_directive"
- OpSourceExtension "GL_GOOGLE_include_directive"
- OpName %main "main"
- OpName %In0 "In0"
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %6 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %uint = OpTypeInt 32 0
- %uint_0 = OpConstant %uint 0
- %_ptr_Input_float = OpTypePointer Input %float
- %uint_1 = OpConstant %uint 1
- %uint_2 = OpConstant %uint 2
- %v3float = OpTypeVector %float 3
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %int_20 = OpConstant %int 20
- %bool = OpTypeBool
- %float_1 = OpConstant %float 1
- %vec_const = OpConstantComposite %v3float %float_1 %float_1 %float_1
- %int_1 = OpConstant %int 1
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %23 = OpUndef %v3float
- %main = OpFunction %void None %6
- %24 = OpLabel
- %25 = OpAccessChain %_ptr_Input_float %In0 %uint_0
- %26 = OpLoad %float %25
- %27 = OpAccessChain %_ptr_Input_float %In0 %uint_1
- %28 = OpLoad %float %27
- %29 = OpAccessChain %_ptr_Input_float %In0 %uint_2
- %30 = OpLoad %float %29
- %31 = OpCompositeConstruct %v3float %30 %28 %26
- %sh = OpVectorShuffle %v3float %vec_const %31 0 4 5
- OpBranch %32
- %32 = OpLabel
- %33 = OpPhi %v3float %sh %24 %34 %35
- %36 = OpPhi %int %int_0 %24 %37 %35
- OpLoopMerge %38 %35 None
- OpBranch %39
- %39 = OpLabel
- %40 = OpSLessThan %bool %36 %int_20
- OpBranchConditional %40 %41 %38
- %41 = OpLabel
- %42 = OpCompositeExtract %float %33 0
- %43 = OpFAdd %float %42 %float_1
- %34 = OpCompositeInsert %v3float %43 %33 0
- OpBranch %35
- %35 = OpLabel
- %37 = OpIAdd %int %36 %int_1
- OpBranch %32
- %38 = OpLabel
- %44 = OpCompositeExtract %float %33 0
- %45 = OpCompositeConstruct %v4float %44 %44 %44 %44
- OpStore %OutColor %45
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndMatch<VectorDCE>(assembly, true);
- }
- TEST_F(VectorDCETest, DeadInstThroughShuffle) {
- // Dead insert in chain with cycle. Demonstrates analysis can handle
- // cycles in chains.
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) out vec4 OutColor;
- //
- // void main()
- // {
- // vec2 v;
- // v.x = 0.0;
- // v.y = 0.1; // dead
- // for (int i = 0; i < 20; i++) {
- // v.x = v.x + 1;
- // v = v * 0.9;
- // }
- // OutColor = vec4(v.x);
- // }
- const std::string assembly =
- R"(
- ; CHECK: OpFunction
- ; CHECK-NOT: OpCompositeInsert %v2float {{%\w+}} 1
- ; CHECK: OpFunctionEnd
- OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpSourceExtension "GL_GOOGLE_cpp_style_line_directive"
- OpSourceExtension "GL_GOOGLE_include_directive"
- OpName %main "main"
- OpName %OutColor "OutColor"
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %3 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %float_0 = OpConstant %float 0
- %float_0_100000001 = OpConstant %float 0.100000001
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %int_20 = OpConstant %int 20
- %bool = OpTypeBool
- %float_1 = OpConstant %float 1
- %float_0_899999976 = OpConstant %float 0.899999976
- %int_1 = OpConstant %int 1
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %58 = OpUndef %v2float
- %main = OpFunction %void None %3
- %5 = OpLabel
- %49 = OpCompositeInsert %v2float %float_0 %58 0
- %51 = OpCompositeInsert %v2float %float_0_100000001 %49 1
- OpBranch %22
- %22 = OpLabel
- %60 = OpPhi %v2float %51 %5 %38 %25
- %59 = OpPhi %int %int_0 %5 %41 %25
- OpLoopMerge %24 %25 None
- OpBranch %26
- %26 = OpLabel
- %30 = OpSLessThan %bool %59 %int_20
- OpBranchConditional %30 %23 %24
- %23 = OpLabel
- %53 = OpCompositeExtract %float %60 0
- %34 = OpFAdd %float %53 %float_1
- %55 = OpCompositeInsert %v2float %34 %60 0
- %38 = OpVectorTimesScalar %v2float %55 %float_0_899999976
- OpBranch %25
- %25 = OpLabel
- %41 = OpIAdd %int %59 %int_1
- OpBranch %22
- %24 = OpLabel
- %57 = OpCompositeExtract %float %60 0
- %47 = OpCompositeConstruct %v4float %57 %57 %57 %57
- OpStore %OutColor %47
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndMatch<VectorDCE>(assembly, true);
- }
- TEST_F(VectorDCETest, DeadInsertThroughOtherInst) {
- // Dead insert in chain with cycle. Demonstrates analysis can handle
- // cycles in chains.
- //
- // Note: The SPIR-V assembly has had store/load elimination
- // performed to allow the inserts and extracts to directly
- // reference each other.
- //
- // #version 450
- //
- // layout (location=0) out vec4 OutColor;
- //
- // void main()
- // {
- // vec2 v;
- // v.x = 0.0;
- // v.y = 0.1; // dead
- // for (int i = 0; i < 20; i++) {
- // v.x = v.x + 1;
- // v = v * 0.9;
- // }
- // OutColor = vec4(v.x);
- // }
- const std::string assembly =
- R"(
- ; CHECK: OpFunction
- ; CHECK-NOT: OpCompositeInsert %v2float {{%\w+}} 1
- ; CHECK: OpFunctionEnd
- OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- OpSourceExtension "GL_GOOGLE_cpp_style_line_directive"
- OpSourceExtension "GL_GOOGLE_include_directive"
- OpName %main "main"
- OpName %OutColor "OutColor"
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %3 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %float_0 = OpConstant %float 0
- %float_0_100000001 = OpConstant %float 0.100000001
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %int_20 = OpConstant %int 20
- %bool = OpTypeBool
- %float_1 = OpConstant %float 1
- %float_0_899999976 = OpConstant %float 0.899999976
- %int_1 = OpConstant %int 1
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %58 = OpUndef %v2float
- %main = OpFunction %void None %3
- %5 = OpLabel
- %49 = OpCompositeInsert %v2float %float_0 %58 0
- %51 = OpCompositeInsert %v2float %float_0_100000001 %49 1
- OpBranch %22
- %22 = OpLabel
- %60 = OpPhi %v2float %51 %5 %38 %25
- %59 = OpPhi %int %int_0 %5 %41 %25
- OpLoopMerge %24 %25 None
- OpBranch %26
- %26 = OpLabel
- %30 = OpSLessThan %bool %59 %int_20
- OpBranchConditional %30 %23 %24
- %23 = OpLabel
- %53 = OpCompositeExtract %float %60 0
- %34 = OpFAdd %float %53 %float_1
- %55 = OpCompositeInsert %v2float %34 %60 0
- %38 = OpVectorTimesScalar %v2float %55 %float_0_899999976
- OpBranch %25
- %25 = OpLabel
- %41 = OpIAdd %int %59 %int_1
- OpBranch %22
- %24 = OpLabel
- %57 = OpCompositeExtract %float %60 0
- %47 = OpCompositeConstruct %v4float %57 %57 %57 %57
- OpStore %OutColor %47
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndMatch<VectorDCE>(assembly, true);
- }
- TEST_F(VectorDCETest, VectorIntoCompositeConstruct) {
- const std::string text = R"(OpCapability Linkage
- OpCapability Shader
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %1 "EntryPoint_Main" %2 %3
- OpExecutionMode %1 OriginUpperLeft
- OpDecorate %2 Location 0
- OpDecorate %_struct_4 Block
- OpDecorate %3 Location 0
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %v4float = OpTypeVector %float 4
- %_ptr_Function_v4float = OpTypePointer Function %v4float
- %mat4v4float = OpTypeMatrix %v4float 4
- %_ptr_Function_mat4v4float = OpTypePointer Function %mat4v4float
- %v3float = OpTypeVector %float 3
- %_ptr_Function_v3float = OpTypePointer Function %v3float
- %_struct_14 = OpTypeStruct %v2float %mat4v4float %v3float %v2float %v4float
- %_ptr_Function__struct_14 = OpTypePointer Function %_struct_14
- %void = OpTypeVoid
- %int = OpTypeInt 32 1
- %int_2 = OpConstant %int 2
- %int_1 = OpConstant %int 1
- %int_4 = OpConstant %int 4
- %int_0 = OpConstant %int 0
- %int_3 = OpConstant %int 3
- %float_0 = OpConstant %float 0
- %float_1 = OpConstant %float 1
- %_ptr_Input_v2float = OpTypePointer Input %v2float
- %2 = OpVariable %_ptr_Input_v2float Input
- %_ptr_Output_v2float = OpTypePointer Output %v2float
- %_struct_4 = OpTypeStruct %v2float
- %_ptr_Output__struct_4 = OpTypePointer Output %_struct_4
- %3 = OpVariable %_ptr_Output__struct_4 Output
- %28 = OpTypeFunction %void
- %29 = OpConstantComposite %v2float %float_0 %float_0
- %30 = OpConstantComposite %v4float %float_0 %float_0 %float_0 %float_0
- %31 = OpConstantComposite %mat4v4float %30 %30 %30 %30
- %32 = OpConstantComposite %v3float %float_0 %float_0 %float_0
- %1 = OpFunction %void None %28
- %33 = OpLabel
- %34 = OpVariable %_ptr_Function_v4float Function
- %35 = OpVariable %_ptr_Function__struct_14 Function
- %36 = OpAccessChain %_ptr_Function_v2float %35 %int_0
- OpStore %36 %29
- %37 = OpAccessChain %_ptr_Function_mat4v4float %35 %int_1
- OpStore %37 %31
- %38 = OpAccessChain %_ptr_Function_v3float %35 %int_2
- OpStore %38 %32
- %39 = OpAccessChain %_ptr_Function_v2float %35 %int_3
- OpStore %39 %29
- %40 = OpAccessChain %_ptr_Function_v4float %35 %int_4
- OpStore %40 %30
- %41 = OpLoad %v2float %2
- OpStore %36 %41
- %42 = OpLoad %v3float %38
- %43 = OpCompositeConstruct %v4float %42 %float_1
- %44 = OpLoad %mat4v4float %37
- %45 = OpVectorTimesMatrix %v4float %43 %44
- OpStore %34 %45
- OpCopyMemory %40 %34
- OpCopyMemory %36 %39
- %46 = OpAccessChain %_ptr_Output_v2float %3 %int_0
- %47 = OpLoad %v2float %36
- OpStore %46 %47
- OpReturn
- OpFunctionEnd
- )";
- SinglePassRunAndCheck<VectorDCE>(text, text, true, true);
- }
- TEST_F(VectorDCETest, NotAffectedByDebugValue) {
- // It tests that an OpenCL.DebugInfo.100 DebugValue instruction does
- // not change the vector DCE pass result. If the composite used for
- // the value of DebugValue is killed, the DebugValue must be killed as well.
- const std::string text = R"(
- OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- %ext = OpExtInstImport "OpenCL.DebugInfo.100"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In2 %In0 %In1 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- %file_name = OpString "test"
- %float_name = OpString "float"
- %main_name = OpString "main"
- %f_name = OpString "f"
- OpName %main "main"
- OpName %In2 "In2"
- OpName %In0 "In0"
- OpName %In1 "In1"
- OpName %OutColor "OutColor"
- OpName %_Globals_ "_Globals_"
- OpMemberName %_Globals_ 0 "g_b"
- OpMemberName %_Globals_ 1 "g_n"
- OpName %_ ""
- OpDecorate %In2 Location 2
- OpDecorate %In0 Location 0
- OpDecorate %In1 Location 1
- OpDecorate %OutColor Location 0
- OpMemberDecorate %_Globals_ 0 Offset 0
- OpMemberDecorate %_Globals_ 1 Offset 4
- OpDecorate %_Globals_ Block
- OpDecorate %_ DescriptorSet 0
- OpDecorate %_ Binding 0
- %void = OpTypeVoid
- %11 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v2float = OpTypeVector %float 2
- %_ptr_Function_v2float = OpTypePointer Function %v2float
- %_ptr_Input_v2float = OpTypePointer Input %v2float
- %In2 = OpVariable %_ptr_Input_v2float Input
- %_ptr_Input_float = OpTypePointer Input %float
- %In0 = OpVariable %_ptr_Input_float Input
- %In1 = OpVariable %_ptr_Input_float Input
- %uint = OpTypeInt 32 0
- %uint_32 = OpConstant %uint 32
- %_ptr_Function_float = OpTypePointer Function %float
- %float_0 = OpConstant %float 0
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %int = OpTypeInt 32 1
- %_Globals_ = OpTypeStruct %uint %int
- %_ptr_Uniform__Globals_ = OpTypePointer Uniform %_Globals_
- %_ = OpVariable %_ptr_Uniform__Globals_ Uniform
- %null_expr = OpExtInst %void %ext DebugExpression
- %src = OpExtInst %void %ext DebugSource %file_name
- %cu = OpExtInst %void %ext DebugCompilationUnit 1 4 %src HLSL
- %dbg_tf = OpExtInst %void %ext DebugTypeBasic %float_name %uint_32 Float
- %main_ty = OpExtInst %void %ext DebugTypeFunction FlagIsProtected|FlagIsPrivate %dbg_tf
- %dbg_main = OpExtInst %void %ext DebugFunction %main_name %main_ty %src 0 0 %cu %main_name FlagIsProtected|FlagIsPrivate 10 %main
- %dbg_f = OpExtInst %void %ext DebugLocalVariable %f_name %dbg_tf %src 0 0 %dbg_main FlagIsLocal
- %main = OpFunction %void None %11
- %25 = OpLabel
- %s = OpExtInst %void %ext DebugScope %dbg_main
- ; CHECK: [[in2:%\w+]] = OpLoad %v2float %In2
- %26 = OpLoad %v2float %In2
- %27 = OpLoad %float %In0
- %28 = OpLoad %float %In1
- %29 = OpFAdd %float %27 %28
- ; CHECK: OpCompositeInsert %v2float {{%\w+}} [[in2]] 0
- ; CHECK-NEXT: OpCompositeInsert %v2float {{%\w+}} [[in2]] 0
- ; CHECK-NOT: DebugValue
- %35 = OpCompositeInsert %v2float %29 %26 0
- %value = OpExtInst %void %ext DebugValue %dbg_f %35 %null_expr
- %37 = OpCompositeInsert %v2float %float_0 %35 0
- %33 = OpVectorShuffle %v4float %37 %37 0 1 0 1
- OpStore %OutColor %33
- OpReturn
- OpFunctionEnd
- )";
- SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
- SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
- SinglePassRunAndMatch<VectorDCE>(text, true);
- }
- TEST_F(VectorDCETest, RemoveDebugValueUsesKilledInstr) {
- // It tests that the vector DCE pass removes the OpenCL.DebugInfo.100
- // DebugValue instruction using a killed instruction.
- const std::string text = R"(
- OpCapability Shader
- %1 = OpExtInstImport "GLSL.std.450"
- %ext = OpExtInstImport "OpenCL.DebugInfo.100"
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %In0 %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpSource GLSL 450
- %file_name = OpString "test"
- %float_name = OpString "float"
- %main_name = OpString "main"
- %f_name = OpString "f"
- OpSourceExtension "GL_GOOGLE_cpp_style_line_directive"
- OpSourceExtension "GL_GOOGLE_include_directive"
- OpName %main "main"
- OpName %In0 "In0"
- OpName %OutColor "OutColor"
- OpDecorate %In0 Location 0
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %6 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Input_v4float = OpTypePointer Input %v4float
- %In0 = OpVariable %_ptr_Input_v4float Input
- %uint = OpTypeInt 32 0
- %uint_0 = OpConstant %uint 0
- %uint_32 = OpConstant %uint 32
- %_ptr_Input_float = OpTypePointer Input %float
- %uint_1 = OpConstant %uint 1
- %uint_2 = OpConstant %uint 2
- %v3float = OpTypeVector %float 3
- %int = OpTypeInt 32 1
- %int_0 = OpConstant %int 0
- %int_20 = OpConstant %int 20
- %bool = OpTypeBool
- %float_1 = OpConstant %float 1
- %int_1 = OpConstant %int 1
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %23 = OpUndef %v3float
- %null_expr = OpExtInst %void %ext DebugExpression
- %src = OpExtInst %void %ext DebugSource %file_name
- %cu = OpExtInst %void %ext DebugCompilationUnit 1 4 %src HLSL
- %dbg_tf = OpExtInst %void %ext DebugTypeBasic %float_name %uint_32 Float
- %main_ty = OpExtInst %void %ext DebugTypeFunction FlagIsProtected|FlagIsPrivate %dbg_tf
- %dbg_main = OpExtInst %void %ext DebugFunction %main_name %main_ty %src 0 0 %cu %main_name FlagIsProtected|FlagIsPrivate 10 %main
- %dbg_f = OpExtInst %void %ext DebugLocalVariable %f_name %dbg_tf %src 0 0 %dbg_main FlagIsLocal
- %main = OpFunction %void None %6
- %24 = OpLabel
- %s0 = OpExtInst %void %ext DebugScope %dbg_main
- %25 = OpAccessChain %_ptr_Input_float %In0 %uint_0
- %26 = OpLoad %float %25
- %27 = OpAccessChain %_ptr_Input_float %In0 %uint_1
- %28 = OpLoad %float %27
- ; CHECK: [[undef:%\w+]] = OpUndef %float
- ; CHECK-NOT: DebugValue
- %value = OpExtInst %void %ext DebugValue %dbg_f %28 %null_expr
- %29 = OpAccessChain %_ptr_Input_float %In0 %uint_2
- %30 = OpLoad %float %29
- ; CHECK: [[composite:%\w+]] = OpCompositeConstruct %v3float {{%\w+}} [[undef]] [[undef]]
- ; CHECK-NEXT: DebugValue {{%\w+}} [[composite]]
- %31 = OpCompositeConstruct %v3float %30 %28 %26
- %value_live = OpExtInst %void %ext DebugValue %dbg_f %31 %null_expr
- OpBranch %32
- %32 = OpLabel
- %s1 = OpExtInst %void %ext DebugScope %dbg_main
- %33 = OpPhi %v3float %31 %24 %34 %35
- %36 = OpPhi %int %int_0 %24 %37 %35
- OpLoopMerge %38 %35 None
- OpBranch %39
- %39 = OpLabel
- %s2 = OpExtInst %void %ext DebugScope %dbg_main
- %40 = OpSLessThan %bool %36 %int_20
- OpBranchConditional %40 %41 %38
- %41 = OpLabel
- %s3 = OpExtInst %void %ext DebugScope %dbg_main
- %42 = OpCompositeExtract %float %33 0
- %43 = OpFAdd %float %42 %float_1
- %34 = OpCompositeInsert %v3float %43 %33 0
- OpBranch %35
- %35 = OpLabel
- %s4 = OpExtInst %void %ext DebugScope %dbg_main
- %37 = OpIAdd %int %36 %int_1
- OpBranch %32
- %38 = OpLabel
- %s5 = OpExtInst %void %ext DebugScope %dbg_main
- %44 = OpCompositeExtract %float %33 0
- %45 = OpCompositeConstruct %v4float %44 %44 %44 %44
- OpStore %OutColor %45
- OpReturn
- OpFunctionEnd
- )";
- SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
- SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
- SinglePassRunAndMatch<VectorDCE>(text, true);
- }
- TEST_F(VectorDCETest, OutOfBoundsExtract) {
- // It tests that the vector DCE pass is able to handle an extract with an
- // index that is out of bounds.
- const std::string text = R"(
- ; CHECK: [[undef:%\w+]] = OpUndef %v4float
- ; CHECK: OpCompositeExtract %float [[undef]] 8
- OpCapability Shader
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Output_float = OpTypePointer Output %float
- %OutColor = OpVariable %_ptr_Output_float Output
- %null = OpConstantNull %v4float
- %float_1 = OpConstant %float 1
- %main = OpFunction %void None %10
- %28 = OpLabel
- %33 = OpCompositeInsert %v4float %float_1 %null 1
- %extract = OpCompositeExtract %float %33 8
- OpStore %OutColor %extract
- OpReturn
- OpFunctionEnd
- )";
- SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
- SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
- SinglePassRunAndMatch<VectorDCE>(text, false);
- }
- TEST_F(VectorDCETest, OutOfBoundsShuffle) {
- // It tests that the vector DCE pass is able to handle a shuffle with an
- // index that is out of bounds.
- const std::string text = R"(
- ; CHECK: [[undef:%\w+]] = OpUndef %v4float
- ; CHECK: OpVectorShuffle %v4float [[undef]] [[undef]] 9 10 11 12
- OpCapability Shader
- OpMemoryModel Logical GLSL450
- OpEntryPoint Fragment %main "main" %OutColor
- OpExecutionMode %main OriginUpperLeft
- OpDecorate %OutColor Location 0
- %void = OpTypeVoid
- %10 = OpTypeFunction %void
- %float = OpTypeFloat 32
- %v4float = OpTypeVector %float 4
- %_ptr_Output_v4float = OpTypePointer Output %v4float
- %OutColor = OpVariable %_ptr_Output_v4float Output
- %null = OpConstantNull %v4float
- %float_1 = OpConstant %float 1
- %main = OpFunction %void None %10
- %28 = OpLabel
- %33 = OpCompositeInsert %v4float %float_1 %null 1
- %shuffle = OpVectorShuffle %v4float %33 %33 9 10 11 12
- OpStore %OutColor %shuffle
- OpReturn
- OpFunctionEnd
- )";
- SetDisassembleOptions(SPV_BINARY_TO_TEXT_OPTION_NO_HEADER |
- SPV_BINARY_TO_TEXT_OPTION_FRIENDLY_NAMES);
- SinglePassRunAndMatch<VectorDCE>(text, false);
- }
- } // namespace
- } // namespace opt
- } // namespace spvtools
|