| 123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272 |
- // Copyright (c) 2018 Google LLC.
- //
- // Licensed under the Apache License, Version 2.0 (the "License");
- // you may not use this file except in compliance with the License.
- // You may obtain a copy of the License at
- //
- // http://www.apache.org/licenses/LICENSE-2.0
- //
- // Unless required by applicable law or agreed to in writing, software
- // distributed under the License is distributed on an "AS IS" BASIS,
- // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- // See the License for the specific language governing permissions and
- // limitations under the License.
- // Validates correctness of barrier SPIR-V instructions.
- #include "validate.h"
- #include "diagnostic.h"
- #include "opcode.h"
- #include "spirv_constant.h"
- #include "spirv_target_env.h"
- #include "util/bitutils.h"
- #include "val/instruction.h"
- #include "val/validation_state.h"
- namespace libspirv {
- namespace {
- // Validates Execution Scope operand.
- spv_result_t ValidateExecutionScope(ValidationState_t& _,
- const spv_parsed_instruction_t* inst,
- uint32_t id) {
- const SpvOp opcode = static_cast<SpvOp>(inst->opcode);
- bool is_int32 = false, is_const_int32 = false;
- uint32_t value = 0;
- std::tie(is_int32, is_const_int32, value) = _.EvalInt32IfConst(id);
- if (!is_int32) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": expected Execution Scope to be a 32-bit int";
- }
- if (!is_const_int32) {
- return SPV_SUCCESS;
- }
- if (spvIsVulkanEnv(_.context()->target_env)) {
- if (value != SpvScopeWorkgroup && value != SpvScopeSubgroup) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": in Vulkan environment Execution Scope is limited to "
- "Workgroup and Subgroup";
- }
- }
- // TODO([email protected]) Add checks for OpenCL and OpenGL environments.
- return SPV_SUCCESS;
- }
- // Validates Memory Scope operand.
- spv_result_t ValidateMemoryScope(ValidationState_t& _,
- const spv_parsed_instruction_t* inst,
- uint32_t id) {
- const SpvOp opcode = static_cast<SpvOp>(inst->opcode);
- bool is_int32 = false, is_const_int32 = false;
- uint32_t value = 0;
- std::tie(is_int32, is_const_int32, value) = _.EvalInt32IfConst(id);
- if (!is_int32) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": expected Memory Scope to be a 32-bit int";
- }
- if (!is_const_int32) {
- return SPV_SUCCESS;
- }
- if (spvIsVulkanEnv(_.context()->target_env)) {
- if (value != SpvScopeDevice && value != SpvScopeWorkgroup &&
- value != SpvScopeInvocation) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": in Vulkan environment Memory Scope is limited to Device, "
- "Workgroup and Invocation";
- }
- }
- // TODO([email protected]) Add checks for OpenCL and OpenGL environments.
- return SPV_SUCCESS;
- }
- // Validates Memory Semantics operand.
- spv_result_t ValidateMemorySemantics(ValidationState_t& _,
- const spv_parsed_instruction_t* inst,
- uint32_t id) {
- const SpvOp opcode = static_cast<SpvOp>(inst->opcode);
- bool is_int32 = false, is_const_int32 = false;
- uint32_t value = 0;
- std::tie(is_int32, is_const_int32, value) = _.EvalInt32IfConst(id);
- if (!is_int32) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": expected Memory Semantics to be a 32-bit int";
- }
- if (!is_const_int32) {
- return SPV_SUCCESS;
- }
- const size_t num_memory_order_set_bits = spvutils::CountSetBits(
- value & (SpvMemorySemanticsAcquireMask | SpvMemorySemanticsReleaseMask |
- SpvMemorySemanticsAcquireReleaseMask |
- SpvMemorySemanticsSequentiallyConsistentMask));
- if (num_memory_order_set_bits > 1) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": Memory Semantics can have at most one of the following bits "
- "set: Acquire, Release, AcquireRelease or SequentiallyConsistent";
- }
- if (spvIsVulkanEnv(_.context()->target_env)) {
- const bool includes_storage_class =
- value & (SpvMemorySemanticsUniformMemoryMask |
- SpvMemorySemanticsWorkgroupMemoryMask |
- SpvMemorySemanticsImageMemoryMask);
- if (opcode == SpvOpMemoryBarrier && !num_memory_order_set_bits) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": Vulkan specification requires Memory Semantics to have one "
- "of the following bits set: Acquire, Release, AcquireRelease "
- "or SequentiallyConsistent";
- }
- if (opcode == SpvOpMemoryBarrier && !includes_storage_class) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": expected Memory Semantics to include a Vulkan-supported "
- "storage class";
- }
- #if 0
- // TODO([email protected]): this check fails Vulkan CTS, reenable once fixed.
- if (opcode == SpvOpControlBarrier && value && !includes_storage_class) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": expected Memory Semantics to include a Vulkan-supported "
- "storage class if Memory Semantics is not None";
- }
- #endif
- }
- // TODO([email protected]) Add checks for OpenCL and OpenGL environments.
- return SPV_SUCCESS;
- }
- } // anonymous namespace
- // Validates correctness of barrier instructions.
- spv_result_t BarriersPass(ValidationState_t& _,
- const spv_parsed_instruction_t* inst) {
- const SpvOp opcode = static_cast<SpvOp>(inst->opcode);
- const uint32_t result_type = inst->type_id;
- switch (opcode) {
- case SpvOpControlBarrier: {
- if (spvVersionForTargetEnv(_.context()->target_env) <
- SPV_SPIRV_VERSION_WORD(1, 3)) {
- _.current_function().RegisterExecutionModelLimitation(
- [](SpvExecutionModel model, std::string* message) {
- if (model != SpvExecutionModelTessellationControl &&
- model != SpvExecutionModelGLCompute &&
- model != SpvExecutionModelKernel) {
- if (message) {
- *message =
- "OpControlBarrier requires one of the following "
- "Execution "
- "Models: TessellationControl, GLCompute or Kernel";
- }
- return false;
- }
- return true;
- });
- }
- const uint32_t execution_scope = inst->words[1];
- const uint32_t memory_scope = inst->words[2];
- const uint32_t memory_semantics = inst->words[3];
- if (auto error = ValidateExecutionScope(_, inst, execution_scope)) {
- return error;
- }
- if (auto error = ValidateMemoryScope(_, inst, memory_scope)) {
- return error;
- }
- if (auto error = ValidateMemorySemantics(_, inst, memory_semantics)) {
- return error;
- }
- break;
- }
- case SpvOpMemoryBarrier: {
- const uint32_t memory_scope = inst->words[1];
- const uint32_t memory_semantics = inst->words[2];
- if (auto error = ValidateMemoryScope(_, inst, memory_scope)) {
- return error;
- }
- if (auto error = ValidateMemorySemantics(_, inst, memory_semantics)) {
- return error;
- }
- break;
- }
- case SpvOpNamedBarrierInitialize: {
- if (_.GetIdOpcode(result_type) != SpvOpTypeNamedBarrier) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": expected Result Type to be OpTypeNamedBarrier";
- }
- const uint32_t subgroup_count_type = _.GetOperandTypeId(inst, 2);
- if (!_.IsIntScalarType(subgroup_count_type) ||
- _.GetBitWidth(subgroup_count_type) != 32) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": expected Subgroup Count to be a 32-bit int";
- }
- break;
- }
- case SpvOpMemoryNamedBarrier: {
- const uint32_t named_barrier_type = _.GetOperandTypeId(inst, 0);
- if (_.GetIdOpcode(named_barrier_type) != SpvOpTypeNamedBarrier) {
- return _.diag(SPV_ERROR_INVALID_DATA)
- << spvOpcodeString(opcode)
- << ": expected Named Barrier to be of type OpTypeNamedBarrier";
- }
- const uint32_t memory_scope = inst->words[2];
- const uint32_t memory_semantics = inst->words[3];
- if (auto error = ValidateMemoryScope(_, inst, memory_scope)) {
- return error;
- }
- if (auto error = ValidateMemorySemantics(_, inst, memory_semantics)) {
- return error;
- }
- break;
- }
- default:
- break;
- }
- return SPV_SUCCESS;
- }
- } // namespace libspirv
|