validate.cpp 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445
  1. // Copyright (c) 2015-2016 The Khronos Group Inc.
  2. //
  3. // Licensed under the Apache License, Version 2.0 (the "License");
  4. // you may not use this file except in compliance with the License.
  5. // You may obtain a copy of the License at
  6. //
  7. // http://www.apache.org/licenses/LICENSE-2.0
  8. //
  9. // Unless required by applicable law or agreed to in writing, software
  10. // distributed under the License is distributed on an "AS IS" BASIS,
  11. // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  12. // See the License for the specific language governing permissions and
  13. // limitations under the License.
  14. #include "source/val/validate.h"
  15. #include <algorithm>
  16. #include <cassert>
  17. #include <cstdio>
  18. #include <functional>
  19. #include <iterator>
  20. #include <memory>
  21. #include <sstream>
  22. #include <string>
  23. #include <vector>
  24. #include "source/binary.h"
  25. #include "source/diagnostic.h"
  26. #include "source/enum_string_mapping.h"
  27. #include "source/extensions.h"
  28. #include "source/instruction.h"
  29. #include "source/opcode.h"
  30. #include "source/operand.h"
  31. #include "source/spirv_constant.h"
  32. #include "source/spirv_endian.h"
  33. #include "source/spirv_target_env.h"
  34. #include "source/spirv_validator_options.h"
  35. #include "source/val/construct.h"
  36. #include "source/val/function.h"
  37. #include "source/val/instruction.h"
  38. #include "source/val/validation_state.h"
  39. #include "spirv-tools/libspirv.h"
  40. namespace {
  41. // TODO(issue 1950): The validator only returns a single message anyway, so no
  42. // point in generating more than 1 warning.
  43. static uint32_t kDefaultMaxNumOfWarnings = 1;
  44. } // namespace
  45. namespace spvtools {
  46. namespace val {
  47. namespace {
  48. // Parses OpExtension instruction and registers extension.
  49. void RegisterExtension(ValidationState_t& _,
  50. const spv_parsed_instruction_t* inst) {
  51. const std::string extension_str = spvtools::GetExtensionString(inst);
  52. Extension extension;
  53. if (!GetExtensionFromString(extension_str.c_str(), &extension)) {
  54. // The error will be logged in the ProcessInstruction pass.
  55. return;
  56. }
  57. _.RegisterExtension(extension);
  58. }
  59. // Parses the beginning of the module searching for OpExtension instructions.
  60. // Registers extensions if recognized. Returns SPV_REQUESTED_TERMINATION
  61. // once an instruction which is not SpvOpCapability and SpvOpExtension is
  62. // encountered. According to the SPIR-V spec extensions are declared after
  63. // capabilities and before everything else.
  64. spv_result_t ProcessExtensions(void* user_data,
  65. const spv_parsed_instruction_t* inst) {
  66. const SpvOp opcode = static_cast<SpvOp>(inst->opcode);
  67. if (opcode == SpvOpCapability) return SPV_SUCCESS;
  68. if (opcode == SpvOpExtension) {
  69. ValidationState_t& _ = *(reinterpret_cast<ValidationState_t*>(user_data));
  70. RegisterExtension(_, inst);
  71. return SPV_SUCCESS;
  72. }
  73. // OpExtension block is finished, requesting termination.
  74. return SPV_REQUESTED_TERMINATION;
  75. }
  76. spv_result_t ProcessInstruction(void* user_data,
  77. const spv_parsed_instruction_t* inst) {
  78. ValidationState_t& _ = *(reinterpret_cast<ValidationState_t*>(user_data));
  79. auto* instruction = _.AddOrderedInstruction(inst);
  80. _.RegisterDebugInstruction(instruction);
  81. return SPV_SUCCESS;
  82. }
  83. spv_result_t ValidateForwardDecls(ValidationState_t& _) {
  84. if (_.unresolved_forward_id_count() == 0) return SPV_SUCCESS;
  85. std::stringstream ss;
  86. std::vector<uint32_t> ids = _.UnresolvedForwardIds();
  87. std::transform(
  88. std::begin(ids), std::end(ids),
  89. std::ostream_iterator<std::string>(ss, " "),
  90. bind(&ValidationState_t::getIdName, std::ref(_), std::placeholders::_1));
  91. auto id_str = ss.str();
  92. return _.diag(SPV_ERROR_INVALID_ID, nullptr)
  93. << "The following forward referenced IDs have not been defined:\n"
  94. << id_str.substr(0, id_str.size() - 1);
  95. }
  96. // Entry point validation. Based on 2.16.1 (Universal Validation Rules) of the
  97. // SPIRV spec:
  98. // * There is at least one OpEntryPoint instruction, unless the Linkage
  99. // capability is being used.
  100. // * No function can be targeted by both an OpEntryPoint instruction and an
  101. // OpFunctionCall instruction.
  102. //
  103. // Additionally enforces that entry points for Vulkan should not have recursion.
  104. spv_result_t ValidateEntryPoints(ValidationState_t& _) {
  105. _.ComputeFunctionToEntryPointMapping();
  106. _.ComputeRecursiveEntryPoints();
  107. if (_.entry_points().empty() && !_.HasCapability(SpvCapabilityLinkage)) {
  108. return _.diag(SPV_ERROR_INVALID_BINARY, nullptr)
  109. << "No OpEntryPoint instruction was found. This is only allowed if "
  110. "the Linkage capability is being used.";
  111. }
  112. for (const auto& entry_point : _.entry_points()) {
  113. if (_.IsFunctionCallTarget(entry_point)) {
  114. return _.diag(SPV_ERROR_INVALID_BINARY, _.FindDef(entry_point))
  115. << "A function (" << entry_point
  116. << ") may not be targeted by both an OpEntryPoint instruction and "
  117. "an OpFunctionCall instruction.";
  118. }
  119. // For Vulkan, the static function-call graph for an entry point
  120. // must not contain cycles.
  121. if (spvIsVulkanEnv(_.context()->target_env)) {
  122. if (_.recursive_entry_points().find(entry_point) !=
  123. _.recursive_entry_points().end()) {
  124. return _.diag(SPV_ERROR_INVALID_BINARY, _.FindDef(entry_point))
  125. << _.VkErrorID(4634)
  126. << "Entry points may not have a call graph with cycles.";
  127. }
  128. }
  129. }
  130. return SPV_SUCCESS;
  131. }
  132. spv_result_t ValidateBinaryUsingContextAndValidationState(
  133. const spv_context_t& context, const uint32_t* words, const size_t num_words,
  134. spv_diagnostic* pDiagnostic, ValidationState_t* vstate) {
  135. auto binary = std::unique_ptr<spv_const_binary_t>(
  136. new spv_const_binary_t{words, num_words});
  137. spv_endianness_t endian;
  138. spv_position_t position = {};
  139. if (spvBinaryEndianness(binary.get(), &endian)) {
  140. return DiagnosticStream(position, context.consumer, "",
  141. SPV_ERROR_INVALID_BINARY)
  142. << "Invalid SPIR-V magic number.";
  143. }
  144. spv_header_t header;
  145. if (spvBinaryHeaderGet(binary.get(), endian, &header)) {
  146. return DiagnosticStream(position, context.consumer, "",
  147. SPV_ERROR_INVALID_BINARY)
  148. << "Invalid SPIR-V header.";
  149. }
  150. if (header.version > spvVersionForTargetEnv(context.target_env)) {
  151. return DiagnosticStream(position, context.consumer, "",
  152. SPV_ERROR_WRONG_VERSION)
  153. << "Invalid SPIR-V binary version "
  154. << SPV_SPIRV_VERSION_MAJOR_PART(header.version) << "."
  155. << SPV_SPIRV_VERSION_MINOR_PART(header.version)
  156. << " for target environment "
  157. << spvTargetEnvDescription(context.target_env) << ".";
  158. }
  159. if (header.bound > vstate->options()->universal_limits_.max_id_bound) {
  160. return DiagnosticStream(position, context.consumer, "",
  161. SPV_ERROR_INVALID_BINARY)
  162. << "Invalid SPIR-V. The id bound is larger than the max id bound "
  163. << vstate->options()->universal_limits_.max_id_bound << ".";
  164. }
  165. // Look for OpExtension instructions and register extensions.
  166. // This parse should not produce any error messages. Hijack the context and
  167. // replace the message consumer so that we do not pollute any state in input
  168. // consumer.
  169. spv_context_t hijacked_context = context;
  170. hijacked_context.consumer = [](spv_message_level_t, const char*,
  171. const spv_position_t&, const char*) {};
  172. spvBinaryParse(&hijacked_context, vstate, words, num_words,
  173. /* parsed_header = */ nullptr, ProcessExtensions,
  174. /* diagnostic = */ nullptr);
  175. // Parse the module and perform inline validation checks. These checks do
  176. // not require the knowledge of the whole module.
  177. if (auto error = spvBinaryParse(&context, vstate, words, num_words,
  178. /*parsed_header =*/nullptr,
  179. ProcessInstruction, pDiagnostic)) {
  180. return error;
  181. }
  182. std::vector<Instruction*> visited_entry_points;
  183. for (auto& instruction : vstate->ordered_instructions()) {
  184. {
  185. // In order to do this work outside of Process Instruction we need to be
  186. // able to, briefly, de-const the instruction.
  187. Instruction* inst = const_cast<Instruction*>(&instruction);
  188. if (inst->opcode() == SpvOpEntryPoint) {
  189. const auto entry_point = inst->GetOperandAs<uint32_t>(1);
  190. const auto execution_model = inst->GetOperandAs<SpvExecutionModel>(0);
  191. const std::string desc_name = inst->GetOperandAs<std::string>(2);
  192. ValidationState_t::EntryPointDescription desc;
  193. desc.name = desc_name;
  194. std::vector<uint32_t> interfaces;
  195. for (size_t j = 3; j < inst->operands().size(); ++j)
  196. desc.interfaces.push_back(inst->word(inst->operand(j).offset));
  197. vstate->RegisterEntryPoint(entry_point, execution_model,
  198. std::move(desc));
  199. if (visited_entry_points.size() > 0) {
  200. for (const Instruction* check_inst : visited_entry_points) {
  201. const auto check_execution_model =
  202. check_inst->GetOperandAs<SpvExecutionModel>(0);
  203. const std::string check_name =
  204. check_inst->GetOperandAs<std::string>(2);
  205. if (desc_name == check_name &&
  206. execution_model == check_execution_model) {
  207. return vstate->diag(SPV_ERROR_INVALID_DATA, inst)
  208. << "2 Entry points cannot share the same name and "
  209. "ExecutionMode.";
  210. }
  211. }
  212. }
  213. visited_entry_points.push_back(inst);
  214. }
  215. if (inst->opcode() == SpvOpFunctionCall) {
  216. if (!vstate->in_function_body()) {
  217. return vstate->diag(SPV_ERROR_INVALID_LAYOUT, &instruction)
  218. << "A FunctionCall must happen within a function body.";
  219. }
  220. const auto called_id = inst->GetOperandAs<uint32_t>(2);
  221. vstate->AddFunctionCallTarget(called_id);
  222. }
  223. if (vstate->in_function_body()) {
  224. inst->set_function(&(vstate->current_function()));
  225. inst->set_block(vstate->current_function().current_block());
  226. if (vstate->in_block() && spvOpcodeIsBlockTerminator(inst->opcode())) {
  227. vstate->current_function().current_block()->set_terminator(inst);
  228. }
  229. }
  230. if (auto error = IdPass(*vstate, inst)) return error;
  231. }
  232. if (auto error = CapabilityPass(*vstate, &instruction)) return error;
  233. if (auto error = ModuleLayoutPass(*vstate, &instruction)) return error;
  234. if (auto error = CfgPass(*vstate, &instruction)) return error;
  235. if (auto error = InstructionPass(*vstate, &instruction)) return error;
  236. // Now that all of the checks are done, update the state.
  237. {
  238. Instruction* inst = const_cast<Instruction*>(&instruction);
  239. vstate->RegisterInstruction(inst);
  240. if (inst->opcode() == SpvOpTypeForwardPointer) {
  241. vstate->RegisterForwardPointer(inst->GetOperandAs<uint32_t>(0));
  242. }
  243. }
  244. }
  245. if (!vstate->has_memory_model_specified())
  246. return vstate->diag(SPV_ERROR_INVALID_LAYOUT, nullptr)
  247. << "Missing required OpMemoryModel instruction.";
  248. if (vstate->in_function_body())
  249. return vstate->diag(SPV_ERROR_INVALID_LAYOUT, nullptr)
  250. << "Missing OpFunctionEnd at end of module.";
  251. // Catch undefined forward references before performing further checks.
  252. if (auto error = ValidateForwardDecls(*vstate)) return error;
  253. // Calculate reachability after all the blocks are parsed, but early that it
  254. // can be relied on in subsequent pases.
  255. ReachabilityPass(*vstate);
  256. // ID usage needs be handled in its own iteration of the instructions,
  257. // between the two others. It depends on the first loop to have been
  258. // finished, so that all instructions have been registered. And the following
  259. // loop depends on all of the usage data being populated. Thus it cannot live
  260. // in either of those iterations.
  261. // It should also live after the forward declaration check, since it will
  262. // have problems with missing forward declarations, but give less useful error
  263. // messages.
  264. for (size_t i = 0; i < vstate->ordered_instructions().size(); ++i) {
  265. auto& instruction = vstate->ordered_instructions()[i];
  266. if (auto error = UpdateIdUse(*vstate, &instruction)) return error;
  267. }
  268. // Validate individual opcodes.
  269. for (size_t i = 0; i < vstate->ordered_instructions().size(); ++i) {
  270. auto& instruction = vstate->ordered_instructions()[i];
  271. // Keep these passes in the order they appear in the SPIR-V specification
  272. // sections to maintain test consistency.
  273. if (auto error = MiscPass(*vstate, &instruction)) return error;
  274. if (auto error = DebugPass(*vstate, &instruction)) return error;
  275. if (auto error = AnnotationPass(*vstate, &instruction)) return error;
  276. if (auto error = ExtensionPass(*vstate, &instruction)) return error;
  277. if (auto error = ModeSettingPass(*vstate, &instruction)) return error;
  278. if (auto error = TypePass(*vstate, &instruction)) return error;
  279. if (auto error = ConstantPass(*vstate, &instruction)) return error;
  280. if (auto error = MemoryPass(*vstate, &instruction)) return error;
  281. if (auto error = FunctionPass(*vstate, &instruction)) return error;
  282. if (auto error = ImagePass(*vstate, &instruction)) return error;
  283. if (auto error = ConversionPass(*vstate, &instruction)) return error;
  284. if (auto error = CompositesPass(*vstate, &instruction)) return error;
  285. if (auto error = ArithmeticsPass(*vstate, &instruction)) return error;
  286. if (auto error = BitwisePass(*vstate, &instruction)) return error;
  287. if (auto error = LogicalsPass(*vstate, &instruction)) return error;
  288. if (auto error = ControlFlowPass(*vstate, &instruction)) return error;
  289. if (auto error = DerivativesPass(*vstate, &instruction)) return error;
  290. if (auto error = AtomicsPass(*vstate, &instruction)) return error;
  291. if (auto error = PrimitivesPass(*vstate, &instruction)) return error;
  292. if (auto error = BarriersPass(*vstate, &instruction)) return error;
  293. // Group
  294. // Device-Side Enqueue
  295. // Pipe
  296. if (auto error = NonUniformPass(*vstate, &instruction)) return error;
  297. if (auto error = LiteralsPass(*vstate, &instruction)) return error;
  298. }
  299. // Validate the preconditions involving adjacent instructions. e.g. SpvOpPhi
  300. // must only be preceded by SpvOpLabel, SpvOpPhi, or SpvOpLine.
  301. if (auto error = ValidateAdjacency(*vstate)) return error;
  302. if (auto error = ValidateEntryPoints(*vstate)) return error;
  303. // CFG checks are performed after the binary has been parsed
  304. // and the CFGPass has collected information about the control flow
  305. if (auto error = PerformCfgChecks(*vstate)) return error;
  306. if (auto error = CheckIdDefinitionDominateUse(*vstate)) return error;
  307. if (auto error = ValidateDecorations(*vstate)) return error;
  308. if (auto error = ValidateInterfaces(*vstate)) return error;
  309. // TODO(dsinclair): Restructure ValidateBuiltins so we can move into the
  310. // for() above as it loops over all ordered_instructions internally.
  311. if (auto error = ValidateBuiltIns(*vstate)) return error;
  312. // These checks must be performed after individual opcode checks because
  313. // those checks register the limitation checked here.
  314. for (const auto& inst : vstate->ordered_instructions()) {
  315. if (auto error = ValidateExecutionLimitations(*vstate, &inst)) return error;
  316. if (auto error = ValidateSmallTypeUses(*vstate, &inst)) return error;
  317. }
  318. return SPV_SUCCESS;
  319. }
  320. } // namespace
  321. spv_result_t ValidateBinaryAndKeepValidationState(
  322. const spv_const_context context, spv_const_validator_options options,
  323. const uint32_t* words, const size_t num_words, spv_diagnostic* pDiagnostic,
  324. std::unique_ptr<ValidationState_t>* vstate) {
  325. spv_context_t hijack_context = *context;
  326. if (pDiagnostic) {
  327. *pDiagnostic = nullptr;
  328. UseDiagnosticAsMessageConsumer(&hijack_context, pDiagnostic);
  329. }
  330. vstate->reset(new ValidationState_t(&hijack_context, options, words,
  331. num_words, kDefaultMaxNumOfWarnings));
  332. return ValidateBinaryUsingContextAndValidationState(
  333. hijack_context, words, num_words, pDiagnostic, vstate->get());
  334. }
  335. } // namespace val
  336. } // namespace spvtools
  337. spv_result_t spvValidate(const spv_const_context context,
  338. const spv_const_binary binary,
  339. spv_diagnostic* pDiagnostic) {
  340. return spvValidateBinary(context, binary->code, binary->wordCount,
  341. pDiagnostic);
  342. }
  343. spv_result_t spvValidateBinary(const spv_const_context context,
  344. const uint32_t* words, const size_t num_words,
  345. spv_diagnostic* pDiagnostic) {
  346. spv_context_t hijack_context = *context;
  347. if (pDiagnostic) {
  348. *pDiagnostic = nullptr;
  349. spvtools::UseDiagnosticAsMessageConsumer(&hijack_context, pDiagnostic);
  350. }
  351. // This interface is used for default command line options.
  352. spv_validator_options default_options = spvValidatorOptionsCreate();
  353. // Create the ValidationState using the context and default options.
  354. spvtools::val::ValidationState_t vstate(&hijack_context, default_options,
  355. words, num_words,
  356. kDefaultMaxNumOfWarnings);
  357. spv_result_t result =
  358. spvtools::val::ValidateBinaryUsingContextAndValidationState(
  359. hijack_context, words, num_words, pDiagnostic, &vstate);
  360. spvValidatorOptionsDestroy(default_options);
  361. return result;
  362. }
  363. spv_result_t spvValidateWithOptions(const spv_const_context context,
  364. spv_const_validator_options options,
  365. const spv_const_binary binary,
  366. spv_diagnostic* pDiagnostic) {
  367. spv_context_t hijack_context = *context;
  368. if (pDiagnostic) {
  369. *pDiagnostic = nullptr;
  370. spvtools::UseDiagnosticAsMessageConsumer(&hijack_context, pDiagnostic);
  371. }
  372. // Create the ValidationState using the context.
  373. spvtools::val::ValidationState_t vstate(&hijack_context, options,
  374. binary->code, binary->wordCount,
  375. kDefaultMaxNumOfWarnings);
  376. return spvtools::val::ValidateBinaryUsingContextAndValidationState(
  377. hijack_context, binary->code, binary->wordCount, pDiagnostic, &vstate);
  378. }