Bläddra i källkod

Merge pull request #597 from paullouisageneau/fix-incoming-track-early-open

Fix incorrect early open event on incoming tracks
Paul-Louis Ageneau 3 år sedan
förälder
incheckning
1ee2c9bf5a
1 ändrade filer med 5 tillägg och 5 borttagningar
  1. 5 5
      src/impl/peerconnection.cpp

+ 5 - 5
src/impl/peerconnection.cpp

@@ -864,10 +864,10 @@ void PeerConnection::processLocalDescription(Description description) {
 				        auto reciprocated = remoteMedia->reciprocate();
 #if !RTC_ENABLE_MEDIA
 				        if (!reciprocated.isRemoved()) {
-							// No media support, mark as removed
-							PLOG_WARNING << "Rejecting track (not compiled with media support)";
-							reciprocated.markRemoved();
-						}
+					        // No media support, mark as removed
+					        PLOG_WARNING << "Rejecting track (not compiled with media support)";
+					        reciprocated.markRemoved();
+				        }
 #endif
 				        incomingTrack(reciprocated);
 
@@ -1087,7 +1087,7 @@ void PeerConnection::triggerPendingTracks() {
 
 		auto impl = std::move(*next);
 		trackCallback(std::make_shared<rtc::Track>(impl));
-		impl->triggerOpen();
+		// Do not trigger open immediately for tracks as it'll be done later
 	}
 }