浏览代码

Merge pull request #102 from paullouisageneau/fix-getaddrinfo-leak

Fix getaddrinfo() leak in Candidate::resolve()
Paul-Louis Ageneau 5 年之前
父节点
当前提交
313f081061
共有 1 个文件被更改,包括 3 次插入2 次删除
  1. 3 2
      src/candidate.cpp

+ 3 - 2
src/candidate.cpp

@@ -107,8 +107,9 @@ bool Candidate::resolve(ResolveMode mode) {
 						oss << sp << nodebuffer << sp << servbuffer << sp << "typ" << sp << type;
 						oss << sp << nodebuffer << sp << servbuffer << sp << "typ" << sp << type;
 						oss << left;
 						oss << left;
 						mCandidate = oss.str();
 						mCandidate = oss.str();
+						mIsResolved = true;
 						PLOG_VERBOSE << "Resolved candidate: " << mCandidate;
 						PLOG_VERBOSE << "Resolved candidate: " << mCandidate;
-						return mIsResolved = true;
+						break;
 					}
 					}
 				}
 				}
 		}
 		}
@@ -116,7 +117,7 @@ bool Candidate::resolve(ResolveMode mode) {
 		freeaddrinfo(result);
 		freeaddrinfo(result);
 	}
 	}
 
 
-	return false;
+	return mIsResolved;
 }
 }
 
 
 bool Candidate::isResolved() const { return mIsResolved; }
 bool Candidate::isResolved() const { return mIsResolved; }