Browse Source

Added profile to all description codec methods for consistency

Paul-Louis Ageneau 1 year ago
parent
commit
3765ff7507
2 changed files with 14 additions and 12 deletions
  1. 3 3
      include/rtc/description.hpp
  2. 11 9
      src/description.cpp

+ 3 - 3
include/rtc/description.hpp

@@ -246,9 +246,9 @@ public:
 
 
 		void addH264Codec(int payloadType, optional<string> profile = DEFAULT_H264_VIDEO_PROFILE);
 		void addH264Codec(int payloadType, optional<string> profile = DEFAULT_H264_VIDEO_PROFILE);
 		void addH265Codec(int payloadType, optional<string> profile = std::nullopt);
 		void addH265Codec(int payloadType, optional<string> profile = std::nullopt);
-		void addVP8Codec(int payloadType);
-		void addVP9Codec(int payloadType);
-		void addAV1Codec(int payloadType);
+		void addVP8Codec(int payloadType, optional<string> profile = std::nullopt);
+		void addVP9Codec(int payloadType, optional<string> profile = std::nullopt);
+		void addAV1Codec(int payloadType, optional<string> profile = std::nullopt);
 	};
 	};
 
 
 	bool hasApplication() const;
 	bool hasApplication() const;

+ 11 - 9
src/description.cpp

@@ -1196,23 +1196,25 @@ void Description::Video::addVideoCodec(int payloadType, string codec, optional<s
 	// ";rtx-time=3000"); addFormat(rtx);
 	// ";rtx-time=3000"); addFormat(rtx);
 }
 }
 
 
-void Description::Video::addH264Codec(int pt, optional<string> profile) {
-	addVideoCodec(pt, "H264", profile);
+void Description::Video::addH264Codec(int payloadType, optional<string> profile) {
+	addVideoCodec(payloadType, "H264", profile);
 }
 }
 
 
-void Description::Video::addH265Codec(int pt, optional<string> profile) {
-	addVideoCodec(pt, "H265", profile);
+void Description::Video::addH265Codec(int payloadType, optional<string> profile) {
+	addVideoCodec(payloadType, "H265", profile);
 }
 }
 
 
-void Description::Video::addVP8Codec(int payloadType) {
-	addVideoCodec(payloadType, "VP8", nullopt);
+void Description::Video::addVP8Codec(int payloadType, optional<string> profile) {
+	addVideoCodec(payloadType, "VP8", profile);
 }
 }
 
 
-void Description::Video::addVP9Codec(int payloadType) {
-	addVideoCodec(payloadType, "VP9", nullopt);
+void Description::Video::addVP9Codec(int payloadType, optional<string> profile) {
+	addVideoCodec(payloadType, "VP9", profile);
 }
 }
 
 
-void Description::Video::addAV1Codec(int pt) { addVideoCodec(pt, "AV1", nullopt); }
+void Description::Video::addAV1Codec(int payloadType, optional<string> profile) {
+	addVideoCodec(payloadType, "AV1", profile);
+}
 
 
 Description::Type Description::stringToType(const string &typeString) {
 Description::Type Description::stringToType(const string &typeString) {
 	using TypeMap_t = std::unordered_map<string, Type>;
 	using TypeMap_t = std::unordered_map<string, Type>;