Browse Source

Fix missing override keyword on destructors

Paul-Louis Ageneau 2 years ago
parent
commit
6044bc029b
4 changed files with 5 additions and 3 deletions
  1. 1 1
      include/rtc/datachannel.hpp
  2. 1 1
      include/rtc/track.hpp
  3. 1 1
      include/rtc/websocket.hpp
  4. 2 0
      src/track.cpp

+ 1 - 1
include/rtc/datachannel.hpp

@@ -27,7 +27,7 @@ struct PeerConnection;
 class RTC_CPP_EXPORT DataChannel final : private CheshireCat<impl::DataChannel>, public Channel {
 public:
 	DataChannel(impl_ptr<impl::DataChannel> impl);
-	virtual ~DataChannel();
+	~DataChannel() override;
 
 	optional<uint16_t> stream() const;
 	optional<uint16_t> id() const;

+ 1 - 1
include/rtc/track.hpp

@@ -25,7 +25,7 @@ class Track;
 class RTC_CPP_EXPORT Track final : private CheshireCat<impl::Track>, public Channel {
 public:
 	Track(impl_ptr<impl::Track> impl);
-	~Track() = default;
+	~Track() override;
 
 	string mid() const;
 	Description::Direction direction() const;

+ 1 - 1
include/rtc/websocket.hpp

@@ -43,7 +43,7 @@ public:
 	WebSocket();
 	WebSocket(Configuration config);
 	WebSocket(impl_ptr<impl::WebSocket> impl);
-	~WebSocket();
+	~WebSocket() override;
 
 	State readyState() const;
 

+ 2 - 0
src/track.cpp

@@ -16,6 +16,8 @@ namespace rtc {
 Track::Track(impl_ptr<impl::Track> impl)
     : CheshireCat<impl::Track>(impl), Channel(std::dynamic_pointer_cast<impl::Channel>(impl)) {}
 
+Track::~Track() {}
+
 string Track::mid() const { return impl()->mid(); }
 
 Description::Direction Track::direction() const { return impl()->direction(); }