Browse Source

Added Candidate.candidate() method for symmetry with web API

Paul-Louis Ageneau 5 years ago
parent
commit
65813e4e31
4 changed files with 7 additions and 4 deletions
  1. 2 2
      README.md
  2. 1 0
      include/rtc/candidate.hpp
  3. 3 1
      src/candidate.cpp
  4. 1 1
      test/main.cpp

+ 2 - 2
README.md

@@ -38,7 +38,7 @@ pc->onLocalDescription([](const rtc::Description &sdp) {
 
 pc->onLocalCandidate([](const optional<rtc::Candidate> &candidate) {
     if (candidate) {
-        MY_SEND_CANDIDATE_TO_REMOTE(string(*candidate), candidate->mid());
+        MY_SEND_CANDIDATE_TO_REMOTE(candidate->candidate(), candidate->mid());
     } else {
         // Gathering finished
     }
@@ -60,7 +60,7 @@ auto dc = pc->createDataChannel("test");
 dc->onOpen([]() {
     cout << "Open" << endl;
 });
-dc->onMessage([](variant<binary, string> message) {
+dc->onMessage([](const variant<binary, string> &message) {
     if (holds_alternative<string>(message)) {
         cout << "Received: " << get<string>(message) << endl;
     }

+ 1 - 0
include/rtc/candidate.hpp

@@ -29,6 +29,7 @@ class Candidate {
 public:
 	Candidate(string candidate, string mid = "");
 
+	string candidate() const;
 	string mid() const;
 	operator string() const;
 

+ 3 - 1
src/candidate.cpp

@@ -92,11 +92,13 @@ Candidate::Candidate(string candidate, string mid) {
 	}
 }
 
+string Candidate::candidate() const { return "candidate:" + mCandidate; }
+
 string Candidate::mid() const { return mMid; }
 
 Candidate::operator string() const {
 	std::ostringstream line;
-	line << "a=candidate:" << mCandidate;
+	line << "a=" << candidate();
 	return line.str();
 }
 

+ 1 - 1
test/main.cpp

@@ -65,7 +65,7 @@ int main(int argc, char **argv) {
 	dc1->onOpen([dc1]() {
 		cout << "DataChannel open: " << dc1->label() << endl;
 	});
-	dc1->onMessage([](variant<binary, string> message) {
+	dc1->onMessage([](const variant<binary, string> &message) {
 		if (holds_alternative<string>(message)) {
 			cout << "Received: " << get<string>(message) << endl;
 		}