Browse Source

Use make_shared where possible

Paul-Louis Ageneau 4 years ago
parent
commit
cd68d1dba7

+ 5 - 5
examples/streamer/main.cpp

@@ -218,11 +218,11 @@ shared_ptr<ClientTrackData> addVideo(const shared_ptr<PeerConnection> pc, const
     video.addSSRC(ssrc, cname, msid, cname);
     video.addSSRC(ssrc, cname, msid, cname);
     auto track = pc->addTrack(video);
     auto track = pc->addTrack(video);
     // create RTP configuration
     // create RTP configuration
-    auto rtpConfig = shared_ptr<RtpPacketizationConfig>(new RtpPacketizationConfig(ssrc, cname, payloadType, H264RtpPacketizer::defaultClockRate));
+    auto rtpConfig = make_shared<RtpPacketizationConfig>(ssrc, cname, payloadType, H264RtpPacketizer::defaultClockRate);
     // create packetizer
     // create packetizer
-    auto packetizer = shared_ptr<H264RtpPacketizer>(new H264RtpPacketizer(H264RtpPacketizer::Separator::Length, rtpConfig));
+    auto packetizer = make_shared<H264RtpPacketizer>(H264RtpPacketizer::Separator::Length, rtpConfig);
     // create H264 handler
     // create H264 handler
-    shared_ptr<H264PacketizationHandler> h264Handler(new H264PacketizationHandler(packetizer));
+    auto h264Handler = make_shared<H264PacketizationHandler>(packetizer);
     // add RTCP SR handler
     // add RTCP SR handler
     auto srReporter = make_shared<RtcpSrReporter>(rtpConfig);
     auto srReporter = make_shared<RtcpSrReporter>(rtpConfig);
     h264Handler->addToChain(srReporter);
     h264Handler->addToChain(srReporter);
@@ -242,7 +242,7 @@ shared_ptr<ClientTrackData> addAudio(const shared_ptr<PeerConnection> pc, const
     audio.addSSRC(ssrc, cname, msid, cname);
     audio.addSSRC(ssrc, cname, msid, cname);
     auto track = pc->addTrack(audio);
     auto track = pc->addTrack(audio);
     // create RTP configuration
     // create RTP configuration
-    auto rtpConfig = shared_ptr<RtpPacketizationConfig>(new RtpPacketizationConfig(ssrc, cname, payloadType, OpusRtpPacketizer::defaultClockRate));
+    auto rtpConfig = make_shared<RtpPacketizationConfig>(ssrc, cname, payloadType, OpusRtpPacketizer::defaultClockRate);
     // create packetizer
     // create packetizer
     auto packetizer = make_shared<OpusRtpPacketizer>(rtpConfig);
     auto packetizer = make_shared<OpusRtpPacketizer>(rtpConfig);
     // create opus handler
     // create opus handler
@@ -265,7 +265,7 @@ shared_ptr<Client> createPeerConnection(const Configuration &config,
                                                 weak_ptr<WebSocket> wws,
                                                 weak_ptr<WebSocket> wws,
                                                 string id) {
                                                 string id) {
     auto pc = make_shared<PeerConnection>(config);
     auto pc = make_shared<PeerConnection>(config);
-    shared_ptr<Client> client(new Client(pc));
+    auto client = make_shared<Client>(pc);
 
 
     pc->onStateChange([id](PeerConnection::State state) {
     pc->onStateChange([id](PeerConnection::State state) {
         cout << "State: " << state << endl;
         cout << "State: " << state << endl;

+ 1 - 1
include/rtc/h264rtppacketizer.hpp

@@ -34,7 +34,7 @@ class RTC_CPP_EXPORT H264RtpPacketizer final : public RtpPacketizer, public Medi
 
 
 public:
 public:
 	/// Default clock rate for H264 in RTP
 	/// Default clock rate for H264 in RTP
-	static const auto defaultClockRate = 90 * 1000;
+	inline static const uint32_t defaultClockRate = 90 * 1000;
 
 
 	/// Nalunit separator
 	/// Nalunit separator
 	enum class Separator {
 	enum class Separator {

+ 1 - 1
include/rtc/opusrtppacketizer.hpp

@@ -30,7 +30,7 @@ namespace rtc {
 class RTC_CPP_EXPORT OpusRtpPacketizer final : public RtpPacketizer, public MediaHandlerRootElement {
 class RTC_CPP_EXPORT OpusRtpPacketizer final : public RtpPacketizer, public MediaHandlerRootElement {
 public:
 public:
 	/// default clock rate used in opus RTP communication
 	/// default clock rate used in opus RTP communication
-	static const uint32_t defaultClockRate = 48 * 1000;
+	inline static const uint32_t defaultClockRate = 48 * 1000;
 
 
 	/// Constructs opus packetizer with given RTP configuration.
 	/// Constructs opus packetizer with given RTP configuration.
 	/// @note RTP configuration is used in packetization process which may change some configuration
 	/// @note RTP configuration is used in packetization process which may change some configuration