Browse Source

opengl: add version checks when setting debug names.

Sasha Szpakowski 1 year ago
parent
commit
7b899fbc17

+ 1 - 1
src/modules/graphics/opengl/Buffer.cpp

@@ -164,7 +164,7 @@ bool Buffer::load(const void *initialdata)
 		glTexBuffer(target, glformat, buffer);
 		glTexBuffer(target, glformat, buffer);
 	}
 	}
 
 
-	if (!debugName.empty())
+	if (!debugName.empty() && (GLAD_VERSION_4_3 || GLAD_ES_VERSION_3_2))
 		glObjectLabel(GL_BUFFER, buffer, -1, debugName.c_str());
 		glObjectLabel(GL_BUFFER, buffer, -1, debugName.c_str());
 
 
 	return (glGetError() == GL_NO_ERROR);
 	return (glGetError() == GL_NO_ERROR);

+ 9 - 3
src/modules/graphics/opengl/Texture.cpp

@@ -422,12 +422,18 @@ bool Texture::loadVolatile()
 
 
 	setGraphicsMemorySize(memsize);
 	setGraphicsMemorySize(memsize);
 
 
-	if (!debugName.empty())
+	if (!debugName.empty() && (GLAD_VERSION_4_3 || GLAD_ES_VERSION_3_2))
 	{
 	{
 		if (texture)
 		if (texture)
 			glObjectLabel(GL_TEXTURE, texture, -1, debugName.c_str());
 			glObjectLabel(GL_TEXTURE, texture, -1, debugName.c_str());
-		else
-			glObjectLabel(GL_FRAMEBUFFER, renderbuffer, -1, debugName.c_str());
+
+		if (renderbuffer)
+		{
+			std::string rname = debugName;
+			if (actualSamples > 1)
+				rname += " (MSAA buffer)";
+			glObjectLabel(GL_RENDERBUFFER, renderbuffer, -1, rname.c_str());
+		}
 	}
 	}
 
 
 	return true;
 	return true;