Browse Source

metal: add a couple comments clarifying depth format fallbacks.

Alex Szpakowski 3 years ago
parent
commit
8c496d60e5
1 changed files with 2 additions and 3 deletions
  1. 2 3
      src/modules/graphics/metal/Graphics.mm

+ 2 - 3
src/modules/graphics/metal/Graphics.mm

@@ -1958,8 +1958,7 @@ bool Graphics::isPixelFormatSupported(PixelFormat format, PixelFormatUsageFlags
 			//if (families.apple[3] || families.mac[1] || families.macCatalyst[1])
 			//	flags |= resolve;
 			break;
-		case PIXELFORMAT_DEPTH24_UNORM:
-			// TODO
+		case PIXELFORMAT_DEPTH24_UNORM: // This is emulated via 32f.
 		case PIXELFORMAT_DEPTH32_FLOAT:
 			if (families.apple[1])
 				flags |= rt | sample | msaa;
@@ -1969,7 +1968,7 @@ bool Graphics::isPixelFormatSupported(PixelFormat format, PixelFormatUsageFlags
 				flags |= rt | commonsample | msaa; // | resolve;
 			break;
 		case PIXELFORMAT_DEPTH24_UNORM_STENCIL8:
-			// TODO
+			// Note: this falls back to 32f_s8 on some systems.
 			flags |= rt | sample | msaa;
 			break;
 		case PIXELFORMAT_DEPTH32_FLOAT_STENCIL8: