Browse Source

Merge pull request #16 from learn-more/openal-assert

Import upstream openal commit, fixing an assert in debug iterators:
Sasha Szpakowski 1 year ago
parent
commit
2c854305d7
1 changed files with 12 additions and 4 deletions
  1. 12 4
      libs/openal-soft/core/helpers.cpp

+ 12 - 4
libs/openal-soft/core/helpers.cpp

@@ -60,10 +60,18 @@ void DirectorySearch(const std::filesystem::path &path, const std::string_view e
         ERR("Exception enumerating files: %s\n", e.what());
     }
 
-    const al::span newlist{results->begin()+base, results->end()};
-    std::sort(newlist.begin(), newlist.end());
-    for(const auto &name : newlist)
-        TRACE(" got %s\n", name.c_str());
+    /* HACK: Without the size check this trips up range-checked iterators, as
+     * al::span uses al::to_address to get the first iterator's data pointer,
+     * which relies on operator->(), which can assert on end iterators. The
+     * check shouldn't be needed with C++20's std::span.
+     */
+    if(static_cast<size_t>(base) < results->size())
+    {
+        const al::span newlist{results->begin()+base, results->end()};
+        std::sort(newlist.begin(), newlist.end());
+        for(const auto &name : newlist)
+            TRACE(" got %s\n", name.c_str());
+    }
 }
 
 } // namespace