Browse Source

Fix crash when using pnmimage.write with unsupported format, also fix a minor issue in shader.set_filename

rdb 9 years ago
parent
commit
910a50de16
2 changed files with 3 additions and 1 deletions
  1. 2 0
      panda/src/gobj/shader.I
  2. 1 1
      panda/src/pnmimage/pnmImageHeader.cxx

+ 2 - 0
panda/src/gobj/shader.I

@@ -56,6 +56,7 @@ get_filename(ShaderType type) const {
  */
  */
 INLINE void Shader::
 INLINE void Shader::
 set_filename(ShaderType type, const Filename &filename) {
 set_filename(ShaderType type, const Filename &filename) {
+  _filename._separate = true;
   switch (type) {
   switch (type) {
   case ST_vertex:
   case ST_vertex:
     _filename._vertex = filename;
     _filename._vertex = filename;
@@ -77,6 +78,7 @@ set_filename(ShaderType type, const Filename &filename) {
     break;
     break;
   default:
   default:
     _filename._shared = filename;
     _filename._shared = filename;
+    _filename._separate = false;
   }
   }
 }
 }
 
 

+ 1 - 1
panda/src/pnmimage/pnmImageHeader.cxx

@@ -343,7 +343,7 @@ make_writer(ostream *file, bool owns_file, const Filename &filename,
     delete file;
     delete file;
   }
   }
 
 
-  if (!writer->is_valid()) {
+  if (writer != NULL && !writer->is_valid()) {
     delete writer;
     delete writer;
     writer = NULL;
     writer = NULL;
   }
   }