2
0
Эх сурвалжийг харах

CMake: Only link PRIVATEly against libraries not installed

Sam Edwards 7 жил өмнө
parent
commit
940ef456ff

+ 2 - 2
pandatool/src/assimp/CMakeLists.txt

@@ -23,7 +23,7 @@ set(P3ASSIMP_SOURCES
 composite_sources(p3assimp P3ASSIMP_SOURCES)
 add_library(p3assimp ${MODULE_TYPE} ${P3ASSIMP_HEADERS} ${P3ASSIMP_SOURCES})
 set_target_properties(p3assimp PROPERTIES DEFINE_SYMBOL BUILDING_ASSIMP)
-target_link_libraries(p3assimp p3pandatoolbase
-  PKG::ASSIMP)
+target_link_libraries(p3assimp PRIVATE p3pandatoolbase)
+target_link_libraries(p3assimp PUBLIC PKG::ASSIMP)
 
 install(TARGETS p3assimp DESTINATION ${MODULE_DESTINATION})

+ 1 - 1
pandatool/src/egg-palettize/CMakeLists.txt

@@ -4,5 +4,5 @@ install(TARGETS egg-palettize DESTINATION bin)
 
 add_library(p3txafile txaFileFilter.cxx txaFileFilter.h txaFileFilter.I)
 set_target_properties(p3txafile PROPERTIES DEFINE_SYMBOL BUILDING_MISC)
-target_link_libraries(p3txafile p3palettizer)
+target_link_libraries(p3txafile PRIVATE p3palettizer)
 install(TARGETS p3txafile DESTINATION lib RUNTIME DESTINATION bin)

+ 1 - 1
pandatool/src/ptloader/CMakeLists.txt

@@ -11,7 +11,7 @@ set(P3PTLOADER_SOURCES
 composite_sources(p3ptloader P3PTLOADER_SOURCES)
 add_library(p3ptloader ${MODULE_TYPE} ${P3PTLOADER_HEADERS} ${P3PTLOADER_SOURCES})
 set_target_properties(p3ptloader PROPERTIES DEFINE_SYMBOL BUILDING_PTLOADER)
-target_link_libraries(p3ptloader
+target_link_libraries(p3ptloader PRIVATE
   p3dxfegg p3fltegg p3lwoegg p3objegg p3vrmlegg p3xfileegg
   p3converter)