Selaa lähdekoodia

better cmp operator for Tasks

Joe Shochet 21 vuotta sitten
vanhempi
sitoutus
b1377f317e
1 muutettua tiedostoa jossa 3 lisäystä ja 5 poistoa
  1. 3 5
      direct/src/task/Task.py

+ 3 - 5
direct/src/task/Task.py

@@ -87,12 +87,10 @@ class Task:
             # If the wakeTimes happen to be the same, just
             # If the wakeTimes happen to be the same, just
             # sort them based on id
             # sort them based on id
             else:
             else:
-                return cmp(self.id, other.id)
-        # Not sure what to do here, I guess we should just make sure it is
-        # not equal since it cannot be. Should it be less than or greater
-        # than? Not sure anybody will care.
+                return cmp(id(self), id(other))
+        # This is important for people doing a (task != None) and such.
         else:
         else:
-            return -1
+            return cmp(id(self), id(other))
 
 
     # According to the Python manual (3.3.1), if you define a cmp operator
     # According to the Python manual (3.3.1), if you define a cmp operator
     # you should also define a hash operator or your objects will not be
     # you should also define a hash operator or your objects will not be