Răsfoiți Sursa

cull: Fix crash caused by freeing a cull object with empty volume

Disyer 11 luni în urmă
părinte
comite
cc6646a448

+ 1 - 1
panda/src/cull/cullBinBackToFront.cxx

@@ -40,7 +40,7 @@ add_object(CullableObject *object, Thread *current_thread) {
   // Determine the center of the bounding volume.
   // Determine the center of the bounding volume.
   CPT(BoundingVolume) volume = object->_geom->get_bounds(current_thread);
   CPT(BoundingVolume) volume = object->_geom->get_bounds(current_thread);
   if (volume->is_empty()) {
   if (volume->is_empty()) {
-    delete object;
+    // No point in culling objects with no volume.
     return;
     return;
   }
   }
 
 

+ 1 - 1
panda/src/cull/cullBinFrontToBack.cxx

@@ -40,7 +40,7 @@ add_object(CullableObject *object, Thread *current_thread) {
   // Determine the center of the bounding volume.
   // Determine the center of the bounding volume.
   CPT(BoundingVolume) volume = object->_geom->get_bounds();
   CPT(BoundingVolume) volume = object->_geom->get_bounds();
   if (volume->is_empty()) {
   if (volume->is_empty()) {
-    delete object;
+    // No point in culling objects with no volume.
     return;
     return;
   }
   }