Browse Source

Clang-Tidy - bugprone-undefined-memory-manipulation.
Close #2282

Yao Wei Tjong 姚伟忠 7 years ago
parent
commit
ae537f1e18
2 changed files with 2 additions and 2 deletions
  1. 1 1
      Source/Urho3D/Core/Variant.cpp
  2. 1 1
      Source/Urho3D/Graphics/Batch.cpp

+ 1 - 1
Source/Urho3D/Core/Variant.cpp

@@ -133,7 +133,7 @@ Variant& Variant::operator =(const Variant& rhs)
         break;
         break;
 
 
     default:
     default:
-        memcpy(&value_, &rhs.value_, sizeof(VariantValue));
+        memcpy(&value_, &rhs.value_, sizeof(VariantValue));     // NOLINT(bugprone-undefined-memory-manipulation)
         break;
         break;
     }
     }
 
 

+ 1 - 1
Source/Urho3D/Graphics/Batch.cpp

@@ -655,7 +655,7 @@ void BatchGroup::SetInstancingData(void* lockedData, unsigned stride, unsigned&
     {
     {
         const InstanceData& instance = instances_[i];
         const InstanceData& instance = instances_[i];
 
 
-        memcpy(buffer, instance.worldTransform_, sizeof(Matrix3x4));
+        memcpy(buffer, instance.worldTransform_, sizeof(Matrix3x4));    // NOLINT(bugprone-undefined-memory-manipulation)
         if (instance.instancingData_)
         if (instance.instancingData_)
             memcpy(buffer + sizeof(Matrix3x4), instance.instancingData_, stride - sizeof(Matrix3x4));
             memcpy(buffer + sizeof(Matrix3x4), instance.instancingData_, stride - sizeof(Matrix3x4));