Fixed download conditions

.github/workflows/localization.yml

@@ -22,8 +22,6 @@ jobs:
   compare-upload:
     name: "Compare local English"
     runs-on: ubuntu-latest
-    outputs:
-      hasChanges: ${{ steps.upload-comparison.outputs.HAS_CHANGES }}
     if: ${{ inputs.mode != 'Download only' }}
     steps:
       - name: Checkout
@@ -34,6 +32,8 @@ jobs:
         env:
           POEDITOR_API_KEY: ${{ secrets.POEDITORKEY }}
           POEDITOR_PROJECT_ID: ${{ secrets.POEDITORPROJECT }}
+    outputs:
+      hasChanges: ${{ steps.upload-comparison.outputs.HAS_CHANGES }}
 
   upload:
     name: "Upload English changes"
@@ -64,20 +64,21 @@ jobs:
           POEDITOR_API_KEY: ${{ secrets.POEDITORKEY }}
           POEDITOR_PROJECT_ID: ${{ secrets.POEDITORPROJECT }}
       - name: Create branch
-        if: ${{ steps.download-languages.outputs.hasChanges == 'true' }}
+        if: ${{ steps.download-languages.outputs.HAS_CHANGES == 'true' }}
         run: git checkout -B "language-update-${{ github.run_number }}-${{ github.run_attempt }}"
       - name: Add changes and commit
+        if: ${{ steps.download-languages.outputs.HAS_CHANGES == 'true' }}
         run: |
           git config --global user.name "github-actions[bot]"
           git config --global user.email "github-actions[bot]@users.noreply.github.com"
           git add -A
           git commit -m "Update language files"
       - name: Push changes
-        if: ${{ steps.download-languages.outputs.hasChanges == 'true' }}
+        if: ${{ steps.download-languages.outputs.HAS_CHANGES == 'true' }}
         run: |
           git push --set-upstream origin $(git rev-parse --abbrev-ref HEAD)
       # - name: Create Pull Request
-      #   if: ${{ steps.download-languages.outputs.hasChanges == 'true' }}
+      #   if: ${{ steps.download-languages.outputs.HAS_CHANGES == 'true' }}
       #   run: |
       #     gh pr create --title "Language Update ${{ github.run_number }}" \
       #           --body "This PR was created automatically.

.github/workflows/localization/download-languages.py

@@ -68,7 +68,7 @@ def update_locale_file(language):
     # Use "remote-code" if available, otherwise default to "code"
     lang_code = language.get("remoteCode", language["code"])
     if language["code"].lower() == "en":
-        return  # Skip English (do not update)
+        return False # Skip English (do not update)
 
     file_name = language["localeFileName"]
     file_path = os.path.join(LOCALES_DIR, file_name)
@@ -76,7 +76,7 @@ def update_locale_file(language):
     remote_data = fetch_poeditor_language_json(lang_code)
     if remote_data is None:
         print(f"::error::Skipping update for {language['name']} ({lang_code}) due to fetch error.")
-        return
+        return False
 
     # Build new ordered data:
     # 1. Start with keys from local file that exist in remote.
@@ -93,7 +93,7 @@ def update_locale_file(language):
     if updated_data != local_data:
         write_ordered_json(file_path, updated_data)
         print(f"✅ Updated locale file for {language['name']} ({language['code']}).")
-        return False
+        return True
     else:
         print(f"✅ No changes for {language['name']} ({language['code']}).")
         return False