Fixed deselct generating new changes

PixiEditor/Helpers/SelectionHelpers.cs

@@ -1,18 +1,13 @@
-using PixiEditor.Models.DataHolders;
+using System.Collections.Generic;
+using PixiEditor.Models.DataHolders;
 using PixiEditor.Models.Enums;
 using PixiEditor.Models.Position;
 using PixiEditor.Models.Undo;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 
 namespace PixiEditor.Helpers
 {
     public class SelectionHelpers
     {
-
         public static void UndoSelect(object[] arguments)
         {
             Document document = (Document)arguments[0];

PixiEditor/Models/Tools/ToolSettings/Settings/Setting.cs

@@ -2,12 +2,10 @@
 using System.Windows.Controls;
 using PixiEditor.Helpers;
 
+#pragma warning disable SA1402 // File may only contain a single type, Justification: "Same class with generic value"
+
 namespace PixiEditor.Models.Tools.ToolSettings.Settings
 {
-    [System.Diagnostics.CodeAnalysis.SuppressMessage(
-        "StyleCop.CSharp.MaintainabilityRules",
-        "SA1402:File may only contain a single type",
-        Justification = "Same class with generic value")]
     public abstract class Setting<T, TControl> : Setting<T>
         where TControl : Control
     {
@@ -23,10 +21,6 @@ namespace PixiEditor.Models.Tools.ToolSettings.Settings
         }
     }
 
-    [System.Diagnostics.CodeAnalysis.SuppressMessage(
-        "StyleCop.CSharp.MaintainabilityRules",
-        "SA1402:File may only contain a single type",
-        Justification = "Same class with generic value")]
     public abstract class Setting<T> : Setting
     {
         protected Setting(string name)

PixiEditor/NotifyableObject.cs

@@ -30,6 +30,5 @@ namespace PixiEditor.Helpers
             PropertyChanged(this, new PropertyChangedEventArgs(propertyName));
             return true;
         }
-
     }
 }

PixiEditor/ViewModels/SubViewModels/Main/SelectionViewModel.cs

@@ -32,12 +32,20 @@ namespace PixiEditor.ViewModels.SubViewModels.Main
         }
 
         public void Deselect(object parameter)
+        {
+            Deselect();
+        }
+
+        public void Deselect(bool addUndo = true)
         {
             var oldSelection = new List<Coordinates>(Owner.BitmapManager.ActiveDocument.ActiveSelection.SelectedPoints);
 
             Owner.BitmapManager.ActiveDocument.ActiveSelection?.Clear();
 
-            SelectionHelpers.AddSelectionUndoStep(Owner.BitmapManager.ActiveDocument, oldSelection, SelectionType.New);
+            if (addUndo)
+            {
+                SelectionHelpers.AddSelectionUndoStep(Owner.BitmapManager.ActiveDocument, oldSelection, SelectionType.New);
+            }
         }
 
         public bool SelectionIsNotEmpty(object property)

PixiEditor/ViewModels/SubViewModels/Main/UndoViewModel.cs

@@ -75,7 +75,7 @@ namespace PixiEditor.ViewModels.SubViewModels.Main
         /// <param name="parameter">CommandParameter.</param>
         public void Undo(object parameter)
         {
-            Owner.SelectionSubViewModel.Deselect(null);
+            Owner.SelectionSubViewModel.Deselect(false);
             Owner.BitmapManager.ActiveDocument.UndoManager.Undo();
         }