Browse Source

2025.1.0-rc0 Fixed runtime issues

Marcin Ziąbek 11 months ago
parent
commit
044be63a22

+ 1 - 2
Source/QuestPDF/Elements/DynamicImage.cs

@@ -46,6 +46,7 @@ namespace QuestPDF.Elements
             foreach (var cacheItem in Cache)
                 cacheItem.Image?.Dispose();
             
+            Cache.Clear();
             GC.SuppressFinalize(this);
         }
         
@@ -75,8 +76,6 @@ namespace QuestPDF.Elements
             if (targetImage != null)
                 Canvas.DrawImage(targetImage, availableSpace);
             
-            targetImage?.Dispose();
-            
             GenerationTime += (float) stopWatch.Elapsed.TotalMilliseconds;
             DrawnImageSize += targetImage?.EncodedDataSize ?? 0;
             

+ 1 - 2
Source/QuestPDF/Elements/DynamicSvgImage.cs

@@ -25,6 +25,7 @@ internal class DynamicSvgImage : Element, IStateful, IDisposable
         foreach (var cacheItem in Cache)
             cacheItem.Image?.Dispose();
             
+        Cache.Clear();
         GC.SuppressFinalize(this);
     }
     
@@ -57,8 +58,6 @@ internal class DynamicSvgImage : Element, IStateful, IDisposable
             Canvas.Scale(widthScale,  heightScale);
             Canvas.DrawSvg(targetImage, availableSpace);
             Canvas.Restore();
-            
-            targetImage.Dispose();
         }
             
         IsRendered = true;

+ 1 - 0
Source/QuestPDF/Fluent/SvgExtensions.cs

@@ -90,6 +90,7 @@ public static class SvgExtensions
         var isFile = Path.GetExtension(svg).Equals(".svg", StringComparison.OrdinalIgnoreCase);
         
         var image = isFile ? SvgImage.FromFile(svg) : SvgImage.FromText(svg);
+        image.IsShared = false;
         return container.Svg(image);
     }