Browse Source

Minor adjustments

Marcin Ziąbek 9 months ago
parent
commit
9a6334820a

+ 1 - 1
Source/QuestPDF.DocumentationExamples/ImageExamples.cs

@@ -205,7 +205,7 @@ public class ImageExamples
     [Test]
     [Test]
     public void SharedImages()
     public void SharedImages()
     {
     {
-        var image = Image.FromFile("Resources/checkbox.png");
+        using var image = Image.FromFile("Resources/checkbox.png");
         
         
         Document
         Document
             .Create(document =>
             .Create(document =>

+ 3 - 1
Source/QuestPDF.UnitTests/ImageTests.cs

@@ -163,7 +163,9 @@ namespace QuestPDF.UnitTests
         static DocumentImage GenerateDocumentImage(int width, int height)
         static DocumentImage GenerateDocumentImage(int width, int height)
         {
         {
             var image = Placeholders.Image(width, height);
             var image = Placeholders.Image(width, height);
-            return DocumentImage.FromBinaryData(image);
+            var result = DocumentImage.FromBinaryData(image);
+            result.IsShared = false;
+            return result;
         }
         }
     }
     }
 }
 }

+ 3 - 0
Source/QuestPDF/Elements/Text/TextBlock.cs

@@ -48,6 +48,9 @@ namespace QuestPDF.Elements.Text
 
 
         ~TextBlock()
         ~TextBlock()
         {
         {
+            if (Paragraph == null)
+                return;
+            
             this.WarnThatFinalizerIsReached();
             this.WarnThatFinalizerIsReached();
             Dispose();
             Dispose();
         }
         }

+ 2 - 2
Source/QuestPDF/Infrastructure/Image.cs

@@ -84,7 +84,7 @@ namespace QuestPDF.Infrastructure
         public static Image FromBinaryData(byte[] imageBytes)
         public static Image FromBinaryData(byte[] imageBytes)
         {
         {
             using var imageData = SkData.FromBinary(imageBytes);
             using var imageData = SkData.FromBinary(imageBytes);
-            return StaticImageCache.DecodeImage(imageData, isShared: false);
+            return StaticImageCache.DecodeImage(imageData, isShared: true);
         }
         }
 
 
         /// <summary>
         /// <summary>
@@ -105,7 +105,7 @@ namespace QuestPDF.Infrastructure
         public static Image FromStream(Stream stream)
         public static Image FromStream(Stream stream)
         {
         {
             using var imageData = SkData.FromStream(stream);
             using var imageData = SkData.FromStream(stream);
-            return StaticImageCache.DecodeImage(imageData, isShared: false);
+            return StaticImageCache.DecodeImage(imageData, isShared: true);
         }
         }
 
 
         #endregion
         #endregion