瀏覽代碼

using WithExtras

Bert Temme 2 年之前
父節點
當前提交
e1d4e45a36

+ 0 - 2
src/SharpGLTF.Toolkit/Scenes/Transformers.Schema2.cs

@@ -162,11 +162,9 @@ namespace SharpGLTF.Scenes
 
                     srcOperator.ApplyTo(dstNode, context);
 
-
                     dstNode
                         .UseGpuInstancing()
                         .WithInstanceAccessors(xforms);
-                        // Todo BT: How to get the extras? .WithInstanceCustomAccessor(extras);
 
                     #if DEBUG
                     var dstInstances = dstNode.GetGpuInstancing();

+ 6 - 12
tests/SharpGLTF.ThirdParty.Tests/CesiumInstancingTests.cs

@@ -24,24 +24,18 @@ namespace SharpGLTF.ThirdParty
             var quaternion = Quaternion.CreateFromYawPitchRoll(0, 0, 0);
             var scale = Vector3.One;
 
-            sceneBuilder.AddRigidMesh(meshBuilder, new AffineTransform(scale, quaternion, new Vector3(-10, 0, 10)));
-            sceneBuilder.AddRigidMesh(meshBuilder, new AffineTransform(scale, quaternion, new Vector3(0, 0, 0)));
+            sceneBuilder.
+                    AddRigidMesh(meshBuilder, new AffineTransform(scale, quaternion, new Vector3(-10, 0, 10))).
+                    WithExtras(JsonNode.Parse("{\"_FEATURE_ID_0\":0}"));
+            sceneBuilder.
+                    AddRigidMesh(meshBuilder, new AffineTransform(scale, quaternion, new Vector3(0, 0, 0))).
+                    WithExtras(JsonNode.Parse("{\"_FEATURE_ID_0\":1}"));
 
-            var extras = new List<JsonNode>();
-            var jsonNode = JsonNode.Parse("{\"_FEATURE_ID_0\":0}");
-            var jsonNode1 = JsonNode.Parse("{\"_FEATURE_ID_0\":1}");
-            extras.Add(jsonNode);
-            extras.Add(jsonNode1);
-
-            // BT todo: pass in the extras, but how?
             var instancedModel = sceneBuilder.ToGltf2(settings);
 
             var dstPath = AttachmentInfo
                 .From("instanced_model_with_feature_id.glb")
                 .WriteObject(f => instancedModel.SaveGLB(f));
-
-
-
         }
     }
 }