Phase 1: Enable nullable by default, add directives to all files

- Added <Nullable>enable</Nullable> to Terminal.Gui.csproj
- Removed #nullable enable from 37 files (now redundant with project setting)
- Added #nullable disable to 170 files that don't have nullable enabled yet
- Build successful with 279 nullable warnings (expected)

Breakdown of files with #nullable disable:
- 27 in Views/ directory (will remain disabled per plan)
- 143 outside Views/ (need to be fixed in subsequent commits)

Next: Systematically fix nullable issues in non-View files.

Co-authored-by: tig <[email protected]>

Terminal.Gui/App/Application.Driver.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 using System.Diagnostics.CodeAnalysis;
 
 namespace Terminal.Gui.App;
@@ -59,4 +59,4 @@ public static partial class Application // Driver abstractions
 
         return (driverTypes, driverTypeNames);
     }
-}
+}

Terminal.Gui/App/Application.Keyboard.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/Application.Lifecycle.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable disable
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Reflection;

Terminal.Gui/App/Application.Mouse.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable disable
 using System.ComponentModel;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/Application.Navigation.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 namespace Terminal.Gui.App;
 
 public static partial class Application // Navigation stuff

Terminal.Gui/App/Application.Popover.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 namespace Terminal.Gui.App;
 
 public static partial class Application // Popover handling
@@ -10,4 +10,4 @@ public static partial class Application // Popover handling
         get => ApplicationImpl.Instance.Popover;
         internal set => ApplicationImpl.Instance.Popover = value;
     }
-}
+}

Terminal.Gui/App/Application.Run.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable disable
 using System.Diagnostics.CodeAnalysis;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/Application.Screen.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 namespace Terminal.Gui.App;
 
 public static partial class Application // Screen related stuff; intended to hide Driver details

Terminal.Gui/App/Application.Toplevel.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable disable
 using System.Collections.Concurrent;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/Application.cs

@@ -1,8 +1,8 @@
-#nullable enable
 
 // We use global using directives to simplify the code and avoid repetitive namespace declarations.
 // Put them here so they are available throughout the application.
 // Do not put them in AssemblyInfo.cs as it will break GitVersion's /updateassemblyinfo
+#nullable disable
 global using Attribute = Terminal.Gui.Drawing.Attribute;
 global using Color = Terminal.Gui.Drawing.Color;
 global using CM = Terminal.Gui.Configuration.ConfigurationManager;

Terminal.Gui/App/ApplicationImpl.Driver.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable disable
 using System.Collections.Concurrent;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/ApplicationImpl.Lifecycle.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable disable
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 

Terminal.Gui/App/ApplicationImpl.Run.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable disable
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 

Terminal.Gui/App/ApplicationImpl.Screen.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 namespace Terminal.Gui.App;
 
 public partial class ApplicationImpl

Terminal.Gui/App/ApplicationImpl.cs

@@ -1,4 +1,4 @@
-#nullable enable
+#nullable disable
 using System.Collections.Concurrent;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/ApplicationNavigation.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 using System.Diagnostics;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/ApplicationPopover.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 using System.Diagnostics;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/CWP/CWPEventHelper.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 
@@ -53,4 +54,4 @@ public static class CWPEventHelper
         eventHandler.Invoke (null, args);
         return args.Handled;
     }
-}
+}

Terminal.Gui/App/CWP/CWPWorkflowHelper.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 
@@ -126,4 +127,4 @@ public static class CWPWorkflowHelper
         }
         return args.Result!;
     }
-}
+}

Terminal.Gui/App/CWP/CancelEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.ComponentModel;
 

Terminal.Gui/App/CWP/EventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 

Terminal.Gui/App/CWP/ResultEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 
@@ -42,4 +43,4 @@ public class ResultEventArgs<T>
         Result = result;
     }
 }
-#pragma warning restore CS1711
+#pragma warning restore CS1711

Terminal.Gui/App/CWP/ValueChangedEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 

Terminal.Gui/App/CWP/ValueChangingEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 
@@ -41,4 +42,4 @@ public class ValueChangingEventArgs<T>
         CurrentValue = currentValue;
         NewValue = newValue;
     }
-}
+}

Terminal.Gui/App/Clipboard/Clipboard.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 
@@ -66,4 +67,4 @@ public static class Clipboard
     /// <summary>Returns true if the environmental dependencies are in place to interact with the OS clipboard.</summary>
     /// <remarks></remarks>
     public static bool IsSupported => Application.Driver?.Clipboard?.IsSupported ?? false;
-}
+}

Terminal.Gui/App/Clipboard/ClipboardBase.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Diagnostics;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/Clipboard/ClipboardProcessRunner.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Diagnostics;
 

Terminal.Gui/App/Clipboard/IClipboard.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>Definition to interact with the OS clipboard.</summary>

Terminal.Gui/App/IApplication.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Collections.Concurrent;
 using System.Diagnostics.CodeAnalysis;

Terminal.Gui/App/IPopover.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>

Terminal.Gui/App/IterationEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>Event arguments for the <see cref="IApplication.Iteration"/> event.</summary>

Terminal.Gui/App/Keyboard/IKeyboard.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 

Terminal.Gui/App/Keyboard/KeyboardImpl.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Diagnostics;
 

Terminal.Gui/App/Logging.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Diagnostics.Metrics;
 using System.Runtime.CompilerServices;
 using Microsoft.Extensions.Logging;

Terminal.Gui/App/MainLoop/ApplicationMainLoop.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System;
 using System.Collections.Concurrent;

Terminal.Gui/App/MainLoop/IApplicationMainLoop.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Collections.Concurrent;
 

Terminal.Gui/App/MainLoop/IMainLoopCoordinator.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>

Terminal.Gui/App/MainLoop/MainLoopCoordinator.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Collections.Concurrent;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/MainLoop/MainLoopSyncContext.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>

Terminal.Gui/App/Mouse/IMouseGrabHandler.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 

Terminal.Gui/App/Mouse/MouseGrabHandler.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 

Terminal.Gui/App/NotInitializedException.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>

Terminal.Gui/App/PopoverBaseImpl.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>

Terminal.Gui/App/SessionToken.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Collections.Concurrent;
 
 namespace Terminal.Gui.App;

Terminal.Gui/App/SessionTokenEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>Event arguments for events about <see cref="SessionToken"/></summary>

Terminal.Gui/App/Timeout/ITimedEvents.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.App;
 

Terminal.Gui/App/Timeout/LogarithmicTimeout.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>Implements a logarithmic increasing timeout.</summary>

Terminal.Gui/App/Timeout/SmoothAcceleratingTimeout.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>

Terminal.Gui/App/Timeout/TimedEvents.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Diagnostics;
 

Terminal.Gui/App/Timeout/Timeout.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>

Terminal.Gui/App/Timeout/TimeoutEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary><see cref="EventArgs"/> for timeout events (e.g. <see cref="TimedEvents.Added"/>)</summary>

Terminal.Gui/App/Toplevel/IToplevelTransitionManager.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.App;
 
 /// <summary>

Terminal.Gui/App/Toplevel/ToplevelTransitionManager.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using Terminal.Gui.Drivers;
 

Terminal.Gui/Configuration/AppSettingsScope.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Text.Json.Serialization;
 

Terminal.Gui/Configuration/AttributeJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Diagnostics.CodeAnalysis;
 using System.Text.Json;
 using System.Text.Json.Serialization;

Terminal.Gui/Configuration/ColorJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Text.Json;
 using System.Text.Json.Serialization;
 

Terminal.Gui/Configuration/ConcurrentDictionaryJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Collections.Concurrent;
 using System.Diagnostics.CodeAnalysis;
 using System.Text.Json;

Terminal.Gui/Configuration/ConfigLocations.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.Configuration;
 

Terminal.Gui/Configuration/ConfigProperty.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Collections.Concurrent;
 using System.Collections.Immutable;

Terminal.Gui/Configuration/ConfigurationManager.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 using System.Collections.Frozen;

Terminal.Gui/Configuration/ConfigurationManagerEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 namespace Terminal.Gui.Configuration;

Terminal.Gui/Configuration/ConfigurationManagerNotEnabledException.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 namespace Terminal.Gui.Configuration;
 

Terminal.Gui/Configuration/ConfigurationPropertyAttribute.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 namespace Terminal.Gui.Configuration;

Terminal.Gui/Configuration/DeepCloner.cs

@@ -1,5 +1,5 @@
-#nullable enable
 
+#nullable disable
 using System.Collections;
 using System.Collections.Concurrent;
 using System.Diagnostics.CodeAnalysis;

Terminal.Gui/Configuration/DictionaryJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Diagnostics.CodeAnalysis;
 using System.Text.Json;
 using System.Text.Json.Serialization;

Terminal.Gui/Configuration/KeyCodeJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Text.Json;
 using System.Text.Json.Serialization;
 

Terminal.Gui/Configuration/KeyJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Text.Json;
 using System.Text.Json.Serialization;
 

Terminal.Gui/Configuration/RuneJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;

Terminal.Gui/Configuration/SchemeJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Diagnostics.CodeAnalysis;
 using System.Text.Json;

Terminal.Gui/Configuration/SchemeManager.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Collections.Immutable;
 using System.Diagnostics;

Terminal.Gui/Configuration/Scope.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Collections.Concurrent;
 using System.Diagnostics;

Terminal.Gui/Configuration/ScopeJsonConverter.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Diagnostics.CodeAnalysis;
 using System.Reflection;

Terminal.Gui/Configuration/SettingsScope.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Text.Json.Serialization;
 

Terminal.Gui/Configuration/SourceGenerationContext.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Collections.Concurrent;
 using System.Text.Json.Serialization;
 

Terminal.Gui/Configuration/SourcesManager.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;

Terminal.Gui/Configuration/ThemeManager.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Collections.Concurrent;
 using System.Collections.Immutable;

Terminal.Gui/Configuration/ThemeScope.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Text.Json.Serialization;
 

Terminal.Gui/Drawing/Attribute.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Numerics;
 using System.Text.Json.Serialization;

Terminal.Gui/Drawing/Cell.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 

Terminal.Gui/Drawing/CellEventArgs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>Args for events that relate to a specific <see cref="Cell"/>.</summary>

Terminal.Gui/Drawing/Color/AnsiColorCode.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>

Terminal.Gui/Drawing/Color/AnsiColorNameResolver.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 using System.Collections.Immutable;

Terminal.Gui/Drawing/Color/Color.ColorName.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>

Terminal.Gui/Drawing/Color/ColorModel.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 namespace Terminal.Gui.Drawing;

Terminal.Gui/Drawing/Color/ColorQuantizer.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System.Collections.Concurrent;
 
 namespace Terminal.Gui.Drawing;

Terminal.Gui/Drawing/Color/IColorDistance.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>

Terminal.Gui/Drawing/Color/IColorNameResolver.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 using System.Diagnostics.CodeAnalysis;

Terminal.Gui/Drawing/Color/MultiStandardColorNameResolver.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 using System.Collections.Frozen;

Terminal.Gui/Drawing/Color/StandardColor.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>

Terminal.Gui/Drawing/Color/StandardColors.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 using System.Collections.Frozen;
 using System.Collections.Immutable;

Terminal.Gui/Drawing/Color/StandardColorsNameResolver.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 using System.Diagnostics.CodeAnalysis;
@@ -17,4 +18,4 @@ public class StandardColorsNameResolver : IColorNameResolver
 
     /// <inheritdoc/>
     public bool TryNameColor (Color color, [NotNullWhen (true)] out string? name) => StandardColors.TryNameColor (color, out name);
-}
+}

Terminal.Gui/Drawing/FillPair.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>

Terminal.Gui/Drawing/Glyphs.cs

@@ -1,3 +1,4 @@
+#nullable disable
 #nullable enable
 
 namespace Terminal.Gui.Drawing;

Terminal.Gui/Drawing/Gradient.cs

@@ -1,5 +1,6 @@
 // This code is a C# port from python library Terminal Text Effects  https://github.com/ChrisBuilds/terminaltexteffects/
 
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>

Terminal.Gui/Drawing/GradientFill.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>

Terminal.Gui/Drawing/IFill.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>

Terminal.Gui/Drawing/LineCanvas/IntersectionDefinition.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 internal class IntersectionDefinition
@@ -17,4 +18,4 @@ internal class IntersectionDefinition
 
     /// <summary>Defines how <see cref="Line"/> position relates to <see cref="Point"/>.</summary>
     internal IntersectionType Type { get; }
-}
+}

Terminal.Gui/Drawing/LineCanvas/IntersectionRuneType.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 /// <summary>The type of Rune that we will use before considering double width, curved borders etc</summary>
@@ -16,4 +17,4 @@ internal enum IntersectionRuneType
     Cross,
     HLine,
     VLine
-}
+}

Terminal.Gui/Drawing/LineCanvas/IntersectionType.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Terminal.Gui.Drawing;
 
 internal enum IntersectionType
@@ -25,4 +26,4 @@ internal enum IntersectionType
 
     /// <summary>A line exists at this point who has 0 length</summary>
     Dot
-}
+}

Terminal.Gui/Drawing/LineCanvas/StraightLineExtensions.cs

@@ -1,3 +1,4 @@
+#nullable disable
 
 namespace Terminal.Gui.Drawing;