Preparing PR + fix cursor issue happening inside frameview

Terminal.Gui/ConsoleDrivers/FakeDriver/FakeDriver.cs

@@ -422,12 +422,12 @@ namespace Terminal.Gui {
 		{
 			visibility = CursorVisibility.Default;
 
-			return true;
+			return false;
 		}
 
 		public override bool SetCursorVisibility (CursorVisibility visibility)
 		{
-			return true;
+			return false;
 		}
 
 		public override bool EnsureCursorVisibility ()

Terminal.Gui/ConsoleDrivers/WindowsDriver.cs

@@ -504,6 +504,7 @@ namespace Terminal.Gui {
 		[DllImport ("kernel32.dll")]
 		static extern bool GetConsoleMode (IntPtr hConsoleHandle, out uint lpMode);
 
+
 		[DllImport ("kernel32.dll")]
 		static extern bool SetConsoleMode (IntPtr hConsoleHandle, uint dwMode);
 
@@ -1490,7 +1491,6 @@ namespace Terminal.Gui {
 		public override void CookMouse ()
 		{
 		}
-
 		#endregion
 	}
 

Terminal.Gui/Core/Application.cs

@@ -503,7 +503,6 @@ namespace Terminal.Gui {
 			toplevel.PositionCursor ();
 			Driver.Refresh ();
 
-
 			return rs;
 		}
 
@@ -711,7 +710,8 @@ namespace Terminal.Gui {
 					RunLoop (runToken);
 
 					End (runToken);
-				} catch (Exception error)
+				} 
+				catch (Exception error)
 				{
 					if (errorHandler == null)
 					{

Terminal.Gui/Views/DateField.cs

@@ -377,14 +377,6 @@ namespace Terminal.Gui {
 		{
 			DateChanged?.Invoke (args);
 		}
-
-		///<inheritdoc/>
-		public override bool OnEnter (View view)
-		{
-			Application.Driver.SetCursorVisibility (CursorVisibility.Invisible);
-
-			return base.OnEnter (view);
-		}
 	}
 
 	/// <summary>

Terminal.Gui/Views/FrameView.cs

@@ -9,6 +9,7 @@
 //  - Does not support IEnumerable
 // Any udpates done here should probably be done in Window as well; TODO: Merge these classes
 
+using System.Linq;
 using NStack;
 
 namespace Terminal.Gui {
@@ -195,7 +196,9 @@ namespace Terminal.Gui {
 		///<inheritdoc/>
 		public override bool OnEnter (View view)
 		{
-			Application.Driver.SetCursorVisibility (CursorVisibility.Invisible);
+			if (Subviews.Count == 0 || !Subviews.Any (subview => subview.CanFocus)) {
+				Application.Driver?.SetCursorVisibility (CursorVisibility.Invisible);
+			}
 
 			return base.OnEnter (view);
 		}

Terminal.Gui/Views/ScrollView.cs

@@ -12,6 +12,7 @@
 // - Perhaps allow an option to not display the scrollbar arrow indicators?
 
 using System;
+using System.Linq;
 using System.Reflection;
 
 namespace Terminal.Gui {
@@ -526,7 +527,9 @@ namespace Terminal.Gui {
 		///<inheritdoc/>
 		public override bool OnEnter (View view)
 		{
-			Application.Driver.SetCursorVisibility (CursorVisibility.Invisible);
+			if (Subviews.Count == 0 || !Subviews.Any (subview => subview.CanFocus)) {
+				Application.Driver?.SetCursorVisibility (CursorVisibility.Invisible);
+			}
 
 			return base.OnEnter (view);
 		}

UICatalog/Scenarios/Editor.cs

@@ -24,25 +24,24 @@ namespace UICatalog {
 				Top = Application.Top;
 			}
 
-			List<MenuBarItem> menuBarItems = new List<MenuBarItem> ();
-
-			menuBarItems.AddRange	(	new MenuBarItem [] 
-							{
-								new MenuBarItem ("_File", new MenuItem [] {
-									new MenuItem ("_New", "", () => New()),
-									new MenuItem ("_Open", "", () => Open()),
-									new MenuItem ("_Save", "", () => Save()),
-									null,
-									new MenuItem ("_Quit", "", () => Quit()),
-								}),
-								new MenuBarItem ("_Edit", new MenuItem [] {
-									new MenuItem ("_Copy", "", () => Copy()),
-									new MenuItem ("C_ut", "", () => Cut()),
-									new MenuItem ("_Paste", "", () => Paste())
-								}),
-								new MenuBarItem ("_ScrollBarView", CreateKeepChecked ())
-							}
-						);
+			List<MenuBarItem> menuBarItems = new List<MenuBarItem> (
+				new MenuBarItem [] 
+				{
+					new MenuBarItem ("_File", new MenuItem [] {
+						new MenuItem ("_New", "", () => New()),
+						new MenuItem ("_Open", "", () => Open()),
+						new MenuItem ("_Save", "", () => Save()),
+						null,
+						new MenuItem ("_Quit", "", () => Quit()),
+					}),
+					new MenuBarItem ("_Edit", new MenuItem [] {
+						new MenuItem ("_Copy", "", () => Copy()),
+						new MenuItem ("C_ut", "", () => Cut()),
+						new MenuItem ("_Paste", "", () => Paste())
+					}),
+					new MenuBarItem ("_ScrollBarView", CreateKeepChecked ())
+				}
+			);
 
 			if (!Application.UseSystemConsole) {
 				menuBarItems.Add (new MenuBarItem ("_Cursor", new MenuItem [] {