NeedsDrawTests.cs 15 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484
  1. #nullable enable
  2. using UnitTests;
  3. namespace ViewBaseTests.Drawing;
  4. [Trait ("Category", "Output")]
  5. public class NeedsDrawTests : FakeDriverBase
  6. {
  7. [Fact]
  8. public void NeedsDraw_False_If_Width_Height_Zero ()
  9. {
  10. View view = new () { Width = 0, Height = 0 };
  11. view.BeginInit ();
  12. view.EndInit ();
  13. Assert.False (view.NeedsDraw);
  14. //Assert.False (view.SubViewNeedsDraw);
  15. }
  16. [Fact]
  17. public void NeedsDraw_True_Initially_If_Width_Height_Not_Zero ()
  18. {
  19. View superView = new () { Driver = CreateFakeDriver (), Width = 1, Height = 1 };
  20. View view1 = new () { Width = 1, Height = 1 };
  21. View view2 = new () { Width = 1, Height = 1 };
  22. superView.Add (view1, view2);
  23. superView.BeginInit ();
  24. superView.EndInit ();
  25. Assert.True (superView.NeedsDraw);
  26. Assert.True (superView.SubViewNeedsDraw);
  27. Assert.True (view1.NeedsDraw);
  28. Assert.True (view2.NeedsDraw);
  29. superView.Layout (); // NeedsDraw is always false if Layout is needed
  30. superView.Draw ();
  31. Assert.False (superView.NeedsDraw);
  32. Assert.False (superView.SubViewNeedsDraw);
  33. Assert.False (view1.NeedsDraw);
  34. Assert.False (view2.NeedsDraw);
  35. superView.SetNeedsDraw ();
  36. Assert.True (superView.NeedsDraw);
  37. Assert.True (superView.SubViewNeedsDraw);
  38. Assert.True (view1.NeedsDraw);
  39. Assert.True (view2.NeedsDraw);
  40. }
  41. [Fact]
  42. public void NeedsDraw_True_After_Constructor ()
  43. {
  44. var view = new View { Width = 2, Height = 2 };
  45. Assert.True (view.NeedsDraw);
  46. view = new () { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
  47. Assert.True (view.NeedsDraw);
  48. }
  49. [Fact]
  50. public void NeedsDraw_True_After_BeginInit ()
  51. {
  52. var view = new View { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
  53. Assert.True (view.NeedsDraw);
  54. view.BeginInit ();
  55. Assert.True (view.NeedsDraw);
  56. view.NeedsDraw = false;
  57. view.BeginInit ();
  58. Assert.False (view.NeedsDraw); // Because layout is still needed
  59. view.Layout ();
  60. // NeedsDraw is true after layout and NeedsLayout is false if SubViewsLaidOut doesn't call SetNeedsLayout
  61. Assert.True (view.NeedsDraw);
  62. Assert.False (view.NeedsLayout);
  63. }
  64. [Fact]
  65. public void NeedsDraw_True_After_EndInit_Where_Call_Layout ()
  66. {
  67. var view = new View { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
  68. Assert.True (view.NeedsDraw);
  69. view.BeginInit ();
  70. Assert.True (view.NeedsDraw);
  71. view.EndInit ();
  72. Assert.True (view.NeedsDraw);
  73. view = new () { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
  74. view.BeginInit ();
  75. view.NeedsDraw = false;
  76. view.EndInit ();
  77. Assert.True (view.NeedsDraw);
  78. }
  79. [Fact]
  80. public void NeedsDraw_After_SetLayoutNeeded_And_Layout ()
  81. {
  82. var view = new View { Driver = CreateFakeDriver (), Width = 2, Height = 2 };
  83. Assert.True (view.NeedsDraw);
  84. Assert.False (view.NeedsLayout);
  85. view.Draw ();
  86. Assert.False (view.NeedsDraw);
  87. Assert.False (view.NeedsLayout);
  88. view.SetNeedsLayout ();
  89. Assert.False (view.NeedsDraw);
  90. Assert.True (view.NeedsLayout);
  91. view.Layout ();
  92. Assert.True (view.NeedsDraw);
  93. Assert.False (view.NeedsLayout);
  94. }
  95. [Fact]
  96. public void NeedsDraw_False_After_SetRelativeLayout_Absolute_Dims ()
  97. {
  98. var view = new View { Driver = CreateFakeDriver (), Width = 2, Height = 2 };
  99. Assert.True (view.NeedsDraw);
  100. view.Draw ();
  101. Assert.False (view.NeedsDraw);
  102. Assert.False (view.NeedsLayout);
  103. // SRL won't change anything since the view frame wasn't changed
  104. view.SetRelativeLayout (new (100, 100));
  105. Assert.False (view.NeedsDraw);
  106. view.SetNeedsLayout ();
  107. // SRL won't change anything since the view frame wasn't changed
  108. // SRL doesn't depend on NeedsLayout, but LayoutSubViews does
  109. view.SetRelativeLayout (new (100, 100));
  110. Assert.False (view.NeedsDraw);
  111. Assert.True (view.NeedsLayout);
  112. view.Layout ();
  113. Assert.True (view.NeedsDraw);
  114. Assert.False (view.NeedsLayout);
  115. view.NeedsDraw = false;
  116. // SRL won't change anything since the view frame wasn't changed. However, Layout has not been called
  117. view.SetRelativeLayout (new (10, 10));
  118. Assert.False (view.NeedsDraw);
  119. }
  120. [Fact]
  121. public void NeedsDraw_False_After_SetRelativeLayout_Relative_Dims ()
  122. {
  123. var view = new View { Width = Dim.Percent (50), Height = Dim.Percent (50) };
  124. View superView = new ()
  125. {
  126. Id = "superView",
  127. Width = Dim.Fill (),
  128. Height = Dim.Fill ()
  129. };
  130. // A layout wasn't called yet, so NeedsDraw is still empty
  131. Assert.False (superView.NeedsDraw);
  132. superView.Add (view);
  133. // A layout wasn't called yet, so NeedsDraw is still empty
  134. Assert.False (view.NeedsDraw);
  135. Assert.False (superView.NeedsDraw);
  136. superView.BeginInit ();
  137. Assert.False (view.NeedsDraw);
  138. Assert.False (superView.NeedsDraw);
  139. superView.EndInit (); // Call Layout
  140. Assert.True (view.NeedsDraw);
  141. Assert.True (superView.NeedsDraw);
  142. superView.SetRelativeLayout (new (100, 100));
  143. Assert.True (view.NeedsDraw);
  144. Assert.True (superView.NeedsDraw);
  145. }
  146. [Fact]
  147. public void NeedsDraw_False_After_SetRelativeLayout_10x10 ()
  148. {
  149. View superView = new ()
  150. {
  151. Id = "superView",
  152. Width = Dim.Fill (),
  153. Height = Dim.Fill ()
  154. };
  155. Assert.False (superView.NeedsDraw);
  156. superView.Layout ();
  157. Assert.True (superView.NeedsDraw);
  158. superView.NeedsDraw = false;
  159. superView.SetRelativeLayout (new (10, 10));
  160. Assert.True (superView.NeedsDraw);
  161. }
  162. [Fact]
  163. public void NeedsDraw_True_After_LayoutSubViews ()
  164. {
  165. var view = new View { Width = 2, Height = 2, BorderStyle = LineStyle.Single };
  166. Assert.True (view.NeedsDraw);
  167. view.BeginInit ();
  168. Assert.True (view.NeedsDraw);
  169. view.EndInit ();
  170. Assert.True (view.NeedsDraw);
  171. view.SetRelativeLayout (new (100, 100));
  172. Assert.True (view.NeedsDraw);
  173. view.LayoutSubViews ();
  174. Assert.True (view.NeedsDraw);
  175. }
  176. [Fact]
  177. public void NeedsDraw_False_After_Draw ()
  178. {
  179. var view = new View { Driver = CreateFakeDriver (), Width = 2, Height = 2, BorderStyle = LineStyle.Single };
  180. Assert.True (view.NeedsDraw);
  181. view.BeginInit ();
  182. Assert.True (view.NeedsDraw);
  183. view.EndInit ();
  184. Assert.True (view.NeedsDraw);
  185. view.SetRelativeLayout (new (100, 100));
  186. Assert.True (view.NeedsDraw);
  187. view.LayoutSubViews ();
  188. Assert.True (view.NeedsDraw);
  189. view.Draw ();
  190. Assert.False (view.NeedsDraw);
  191. }
  192. [Fact]
  193. public void NeedsDrawRect_Is_Viewport_Relative ()
  194. {
  195. View superView = new ()
  196. {
  197. Id = "superView",
  198. Width = 10,
  199. Height = 10
  200. };
  201. Assert.Equal (new (0, 0, 10, 10), superView.Frame);
  202. Assert.Equal (new (0, 0, 10, 10), superView.Viewport);
  203. Assert.Equal (new (0, 0, 10, 10), superView.NeedsDrawRect);
  204. var view = new View
  205. {
  206. Id = "view"
  207. };
  208. view.Frame = new (0, 1, 2, 3);
  209. Assert.Equal (new (0, 1, 2, 3), view.Frame);
  210. Assert.Equal (new (0, 0, 2, 3), view.Viewport);
  211. Assert.Equal (new (0, 0, 2, 3), view.NeedsDrawRect);
  212. superView.Add (view);
  213. Assert.Equal (new (0, 0, 10, 10), superView.Frame);
  214. Assert.Equal (new (0, 0, 10, 10), superView.Viewport);
  215. Assert.Equal (new (0, 0, 10, 10), superView.NeedsDrawRect);
  216. Assert.Equal (new (0, 1, 2, 3), view.Frame);
  217. Assert.Equal (new (0, 0, 2, 3), view.Viewport);
  218. Assert.Equal (new (0, 0, 2, 3), view.NeedsDrawRect);
  219. view.Frame = new (3, 3, 5, 5);
  220. Assert.Equal (new (3, 3, 5, 5), view.Frame);
  221. Assert.Equal (new (0, 0, 5, 5), view.Viewport);
  222. Assert.Equal (new (0, 0, 5, 5), view.NeedsDrawRect);
  223. view.Frame = new (3, 3, 6, 6); // Grow right/bottom 1
  224. Assert.Equal (new (3, 3, 6, 6), view.Frame);
  225. Assert.Equal (new (0, 0, 6, 6), view.Viewport);
  226. Assert.Equal (new (0, 0, 6, 6), view.NeedsDrawRect);
  227. view.Frame = new (3, 3, 5, 5); // Shrink right/bottom 1
  228. Assert.Equal (new (3, 3, 5, 5), view.Frame);
  229. Assert.Equal (new (0, 0, 5, 5), view.Viewport);
  230. Assert.Equal (new (0, 0, 5, 5), view.NeedsDrawRect);
  231. view.SetContentSize (new (10, 10));
  232. Assert.Equal (new (3, 3, 5, 5), view.Frame);
  233. Assert.Equal (new (0, 0, 5, 5), view.Viewport);
  234. Assert.Equal (new (0, 0, 5, 5), view.NeedsDrawRect);
  235. view.Viewport = new (1, 1, 5, 5); // Scroll up/left 1
  236. Assert.Equal (new (3, 3, 5, 5), view.Frame);
  237. Assert.Equal (new (1, 1, 5, 5), view.Viewport);
  238. Assert.Equal (new (0, 0, 5, 5), view.NeedsDrawRect);
  239. view.Frame = new (3, 3, 6, 6); // Grow right/bottom 1
  240. Assert.Equal (new (3, 3, 6, 6), view.Frame);
  241. Assert.Equal (new (1, 1, 6, 6), view.Viewport);
  242. Assert.Equal (new (1, 1, 6, 6), view.NeedsDrawRect);
  243. view.Frame = new (3, 3, 5, 5);
  244. Assert.Equal (new (3, 3, 5, 5), view.Frame);
  245. Assert.Equal (new (1, 1, 5, 5), view.Viewport);
  246. Assert.Equal (new (1, 1, 5, 5), view.NeedsDrawRect);
  247. }
  248. [Fact (Skip = "Not valid")]
  249. public void ClearNeedsDraw_WithSiblings_DoesNotClearSuperViewSubViewNeedsDraw ()
  250. {
  251. // This test verifies the fix for the bug where a subview clearing its NeedsDraw
  252. // would incorrectly clear the superview's SubViewNeedsDraw flag, even if other siblings
  253. // still needed drawing.
  254. IDriver driver = CreateFakeDriver (80, 25);
  255. driver.Clip = new Region (driver.Screen);
  256. var superView = new View
  257. {
  258. X = 0,
  259. Y = 0,
  260. Width = 50,
  261. Height = 50,
  262. Driver = driver
  263. };
  264. var subView1 = new View { X = 0, Y = 0, Width = 10, Height = 10, Id = "SubView1" };
  265. var subView2 = new View { X = 0, Y = 10, Width = 10, Height = 10, Id = "SubView2" };
  266. var subView3 = new View { X = 0, Y = 20, Width = 10, Height = 10, Id = "SubView3" };
  267. superView.Add (subView1, subView2, subView3);
  268. superView.BeginInit ();
  269. superView.EndInit ();
  270. superView.LayoutSubViews ();
  271. // All subviews should need drawing initially
  272. Assert.True (subView1.NeedsDraw);
  273. Assert.True (subView2.NeedsDraw);
  274. Assert.True (subView3.NeedsDraw);
  275. Assert.True (superView.SubViewNeedsDraw);
  276. // Draw subView1 - this will call ClearNeedsDraw() on subView1
  277. subView1.Draw ();
  278. // SubView1 should no longer need drawing
  279. Assert.False (subView1.NeedsDraw);
  280. // But subView2 and subView3 still need drawing
  281. Assert.True (subView2.NeedsDraw);
  282. Assert.True (subView3.NeedsDraw);
  283. // THE BUG: Before the fix, subView1.ClearNeedsDraw() would set superView.SubViewNeedsDraw = false
  284. // even though subView2 and subView3 still need drawing.
  285. // After the fix, superView.SubViewNeedsDraw should still be true because subView2 and subView3 need drawing.
  286. Assert.True (superView.SubViewNeedsDraw, "SuperView's SubViewNeedsDraw should still be true because subView2 and subView3 still need drawing");
  287. // Now draw subView2
  288. subView2.Draw ();
  289. Assert.False (subView2.NeedsDraw);
  290. Assert.True (subView3.NeedsDraw);
  291. // SuperView should still have SubViewNeedsDraw = true because subView3 needs drawing
  292. Assert.True (superView.SubViewNeedsDraw, "SuperView's SubViewNeedsDraw should still be true because subView3 still needs drawing");
  293. // Now draw subView3
  294. subView3.Draw ();
  295. Assert.False (subView3.NeedsDraw);
  296. // SuperView should STILL have SubViewNeedsDraw = true because it hasn't been cleared by the superview itself
  297. // Only the superview's own ClearNeedsDraw() should clear this flag
  298. Assert.True (superView.SubViewNeedsDraw, "SuperView's SubViewNeedsDraw should only be cleared by superView.ClearNeedsDraw(), not by subviews");
  299. // Finally, draw the superview - this will clear SubViewNeedsDraw
  300. superView.Draw ();
  301. Assert.False (superView.SubViewNeedsDraw, "SuperView's SubViewNeedsDraw should now be false after superView.Draw()");
  302. Assert.False (subView1.NeedsDraw);
  303. Assert.False (subView2.NeedsDraw);
  304. Assert.False (subView3.NeedsDraw);
  305. }
  306. [Fact]
  307. public void ClearNeedsDraw_ClearsOwnFlags ()
  308. {
  309. // Verify that ClearNeedsDraw properly clears the view's own flags
  310. IDriver driver = CreateFakeDriver (80, 25);
  311. driver.Clip = new Region (driver.Screen);
  312. var view = new View
  313. {
  314. X = 0,
  315. Y = 0,
  316. Width = 20,
  317. Height = 20,
  318. Driver = driver
  319. };
  320. view.BeginInit ();
  321. view.EndInit ();
  322. view.LayoutSubViews ();
  323. Assert.True (view.NeedsDraw);
  324. Assert.Equal (view.Viewport, view.NeedsDrawRect);
  325. view.Draw ();
  326. Assert.False (view.NeedsDraw);
  327. Assert.Equal (Rectangle.Empty, view.NeedsDrawRect);
  328. Assert.False (view.SubViewNeedsDraw);
  329. }
  330. [Fact]
  331. public void ClearNeedsDraw_ClearsAdornments ()
  332. {
  333. // Verify that ClearNeedsDraw clears adornment flags
  334. IDriver driver = CreateFakeDriver (80, 25);
  335. driver.Clip = new Region (driver.Screen);
  336. var view = new View
  337. {
  338. X = 0,
  339. Y = 0,
  340. Width = 20,
  341. Height = 20,
  342. Driver = driver
  343. };
  344. view.Border!.Thickness = new Thickness (1);
  345. view.Padding!.Thickness = new Thickness (1);
  346. view.BeginInit ();
  347. view.EndInit ();
  348. view.LayoutSubViews ();
  349. Assert.True (view.Border!.NeedsDraw);
  350. Assert.True (view.Padding!.NeedsDraw);
  351. view.Draw ();
  352. Assert.False (view.Border!.NeedsDraw);
  353. Assert.False (view.Padding!.NeedsDraw);
  354. }
  355. [Fact]
  356. public void ClearNeedsDraw_PropagatesDownToAllSubViews ()
  357. {
  358. // Verify that ClearNeedsDraw clears flags on all descendants
  359. IDriver driver = CreateFakeDriver (80, 25);
  360. driver.Clip = new Region (driver.Screen);
  361. var topView = new View
  362. {
  363. X = 0,
  364. Y = 0,
  365. Width = 100,
  366. Height = 100,
  367. Driver = driver
  368. };
  369. var middleView = new View { X = 10, Y = 10, Width = 50, Height = 50 };
  370. var bottomView = new View { X = 5, Y = 5, Width = 20, Height = 20 };
  371. topView.Add (middleView);
  372. middleView.Add (bottomView);
  373. topView.BeginInit ();
  374. topView.EndInit ();
  375. topView.LayoutSubViews ();
  376. Assert.True (topView.NeedsDraw);
  377. Assert.True (middleView.NeedsDraw);
  378. Assert.True (bottomView.NeedsDraw);
  379. topView.Draw ();
  380. Assert.False (topView.NeedsDraw);
  381. Assert.False (topView.SubViewNeedsDraw);
  382. Assert.False (middleView.NeedsDraw);
  383. Assert.False (middleView.SubViewNeedsDraw);
  384. Assert.False (bottomView.NeedsDraw);
  385. }
  386. }