Switch to Visual Studio 2019 and .NET Core 3 test runner (#669)

Jint.Benchmark/Jint.Benchmark.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>netcoreapp2.2</TargetFramework>
+    <TargetFramework>netcoreapp3.0</TargetFramework>
     <AssemblyName>Jint.Benchmark</AssemblyName>
     <OutputType>Exe</OutputType>
     <PackageId>Jint.Benchmark</PackageId>

Jint.Tests.CommonScripts/Jint.Tests.CommonScripts.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>netcoreapp2.1</TargetFramework>
+    <TargetFramework>netcoreapp3.0</TargetFramework>
   </PropertyGroup>
   <ItemGroup>
     <EmbeddedResource Include="Scripts\*.*" />
@@ -9,7 +9,7 @@
     <ProjectReference Include="..\Jint\Jint.csproj" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.3.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.analyzers" Version="0.10.0" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />

Jint.Tests.Ecma/Jint.Tests.Ecma.csproj

@@ -1,12 +1,12 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>netcoreapp2.1</TargetFramework>
+    <TargetFramework>netcoreapp3.0</TargetFramework>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\Jint\Jint.csproj" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.3.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.analyzers" Version="0.10.0" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />

Jint.Tests.Test262/Jint.Tests.Test262.csproj

@@ -1,12 +1,12 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFramework>netcoreapp2.1</TargetFramework>
+    <TargetFramework>netcoreapp3.0</TargetFramework>
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\Jint\Jint.csproj" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.3.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.analyzers" Version="0.10.0" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />

Jint.Tests/Jint.Tests.csproj

@@ -1,6 +1,6 @@
 <Project Sdk="Microsoft.NET.Sdk">
   <PropertyGroup>
-    <TargetFrameworks>netcoreapp2.1;net452</TargetFrameworks>
+    <TargetFrameworks>netcoreapp3.0;net452</TargetFrameworks>
   </PropertyGroup>
   <ItemGroup>
     <EmbeddedResource Include="Runtime\Scripts\*.*;Parser\Scripts\*.*" />
@@ -12,7 +12,7 @@
     <Reference Include="Microsoft.CSharp" Condition=" '$(TargetFramework)' == 'net452' " />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.9.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.3.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.analyzers" Version="0.10.0" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" />

Jint.Tests/Runtime/DateTests.cs

@@ -1,5 +1,4 @@
 using System;
-using Jint.Runtime;
 using Xunit;
 
 namespace Jint.Tests.Runtime

Jint/Native/Date/DateConstructor.cs

@@ -94,7 +94,7 @@ namespace Jint.Native.Date
             if (!DateTime.TryParseExact(date, DefaultFormats, CultureInfo.InvariantCulture, DateTimeStyles.AdjustToUniversal | DateTimeStyles.AssumeUniversal, out var result))
             {
                 if (!DateTime.TryParseExact(date, SecondaryFormats, CultureInfo.InvariantCulture, DateTimeStyles.AdjustToUniversal, out result))
-            {
+                {
                     if (!DateTime.TryParse(date, Engine.Options._Culture, DateTimeStyles.AdjustToUniversal, out result))
                     {
                         if (!DateTime.TryParse(date, CultureInfo.InvariantCulture, DateTimeStyles.AdjustToUniversal, out result))

Jint/Native/Date/DateInstance.cs

@@ -7,10 +7,10 @@ namespace Jint.Native.Date
     public class DateInstance : ObjectInstance
     {
         // Maximum allowed value to prevent DateTime overflow
-        internal static readonly double Max = (DateTime.MaxValue - new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc)).TotalMilliseconds;
+        private static readonly double Max = (DateTime.MaxValue - new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc)).TotalMilliseconds;
 
         // Minimum allowed value to prevent DateTime overflow
-        internal static readonly double Min = -(new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc) - DateTime.MinValue).TotalMilliseconds;
+        private static readonly double Min = -(new DateTime(1970, 1, 1, 0, 0, 0, DateTimeKind.Utc) - DateTime.MinValue).TotalMilliseconds;
 
         public DateInstance(Engine engine)
             : base(engine, objectClass: "Date")
@@ -21,13 +21,10 @@ namespace Jint.Native.Date
         {
             if (double.IsNaN(PrimitiveValue) || PrimitiveValue > Max || PrimitiveValue < Min)
             {
-                ExceptionHelper.ThrowRangeError(Engine);
-                return DateTime.MinValue;
-            }
-            else
-            {
-                return DateConstructor.Epoch.AddMilliseconds(PrimitiveValue);
+                return ExceptionHelper.ThrowRangeError<DateTime>(Engine);
             }
+
+            return DateConstructor.Epoch.AddMilliseconds(PrimitiveValue);
         }
 
         public double PrimitiveValue { get; set; }

Jint/Native/Date/DatePrototype.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Globalization;
+using System.Runtime.CompilerServices;
 using Jint.Collections;
 using Jint.Runtime;
 using Jint.Runtime.Descriptors;
@@ -96,10 +97,7 @@ namespace Jint.Native.Date
         /// </summary>
         private DateInstance EnsureDateInstance(JsValue thisObj)
         {
-            return thisObj.TryCast<DateInstance>(value =>
-               {
-                   ExceptionHelper.ThrowTypeError(_engine, "Invalid Date");
-               });
+            return thisObj as DateInstance ?? ExceptionHelper.ThrowTypeError<DateInstance>(_engine, "Invalid Date");
         }
 
         public JsValue ToString(JsValue thisObj, JsValue[] arg2)
@@ -367,7 +365,7 @@ namespace Jint.Native.Date
                 return JsNumber.DoubleNaN;
             }
 
-            return (t - LocalTime(t))/MsPerMinute;
+            return (int) (t - LocalTime(t))/MsPerMinute;
         }
 
         private JsValue SetTime(JsValue thisObj, JsValue[] arguments)
@@ -477,7 +475,7 @@ namespace Jint.Native.Date
 
         private JsValue SetUTCDate(JsValue thisObj, JsValue[] arguments)
         {
-            var t = EnsureDateInstance(thisObj).PrimitiveValue;
+            var t = (long) EnsureDateInstance(thisObj).PrimitiveValue;
             var dt = TypeConverter.ToNumber(arguments.At(0));
             var newDate = MakeDate(MakeDay(YearFromTime(t), MonthFromTime(t), dt), TimeWithinDay(t));
             var u = TimeClip(newDate);
@@ -498,7 +496,7 @@ namespace Jint.Native.Date
 
         private JsValue SetUTCMonth(JsValue thisObj, JsValue[] arguments)
         {
-            var t = EnsureDateInstance(thisObj).PrimitiveValue;
+            var t = (long) EnsureDateInstance(thisObj).PrimitiveValue;
             var m = TypeConverter.ToNumber(arguments.At(0));
             var dt = arguments.Length <= 1 ? DateFromTime(t) : TypeConverter.ToNumber(arguments.At(1));
             var newDate = MakeDate(MakeDay(YearFromTime(t), m, dt), TimeWithinDay(t));
@@ -510,7 +508,7 @@ namespace Jint.Native.Date
         private JsValue SetFullYear(JsValue thisObj, JsValue[] arguments)
         {
             var thisTime = EnsureDateInstance(thisObj).PrimitiveValue;
-            var t = double.IsNaN(thisTime) ? +0 : LocalTime(thisTime);
+            var t = double.IsNaN(thisTime) ? 0 : LocalTime(thisTime);
             var y = TypeConverter.ToNumber(arguments.At(0));
             var m = arguments.Length <= 1 ? MonthFromTime(t) : TypeConverter.ToNumber(arguments.At(1));
             var dt = arguments.Length <= 2 ? DateFromTime(t) : TypeConverter.ToNumber(arguments.At(2));
@@ -523,7 +521,7 @@ namespace Jint.Native.Date
         private JsValue SetYear(JsValue thisObj, JsValue[] arguments)
         {
             var thisTime = EnsureDateInstance(thisObj).PrimitiveValue;
-            var t = double.IsNaN(thisTime) ? +0 : LocalTime(thisTime);
+            var t = double.IsNaN(thisTime) ? 0 : LocalTime(thisTime);
             var y = TypeConverter.ToNumber(arguments.At(0));
             if (double.IsNaN(y))
             {
@@ -534,7 +532,7 @@ namespace Jint.Native.Date
             var fy = TypeConverter.ToInteger(y);
             if (y >= 0 && y <= 99)
             {
-                fy = fy + 1900;
+                fy += 1900;
             }
 
             var newDate = MakeDay(fy, MonthFromTime(t), DateFromTime(t));
@@ -546,7 +544,7 @@ namespace Jint.Native.Date
         private JsValue SetUTCFullYear(JsValue thisObj, JsValue[] arguments)
         {
             var thisTime = EnsureDateInstance(thisObj).PrimitiveValue;
-            var t = double.IsNaN(thisTime) ? +0 : thisTime;
+            var t = (long) (double.IsNaN(thisTime) ? 0 : thisTime);
             var y = TypeConverter.ToNumber(arguments.At(0));
             var m = arguments.Length <= 1 ? MonthFromTime(t) : TypeConverter.ToNumber(arguments.At(1));
             var dt = arguments.Length <= 2 ? DateFromTime(t) : TypeConverter.ToNumber(arguments.At(2));
@@ -558,28 +556,22 @@ namespace Jint.Native.Date
 
         private JsValue ToUtcString(JsValue thisObj, JsValue[] arguments)
         {
-            return thisObj.TryCast<DateInstance>(x =>
-                {
-                    ExceptionHelper.ThrowTypeError(_engine);
-                } )
+            return (thisObj as DateInstance?? ExceptionHelper.ThrowTypeError<DateInstance>(_engine))
             .ToDateTime().ToUniversalTime().ToString("ddd MMM dd yyyy HH:mm:ss 'GMT'", CultureInfo.InvariantCulture);
         }
 
         private JsValue ToISOString(JsValue thisObj, JsValue[] arguments)
         {
-            var t = thisObj.TryCast<DateInstance>(x =>
-            {
-                ExceptionHelper.ThrowTypeError(_engine);
-            }).PrimitiveValue;
+            var t = (thisObj as DateInstance ?? ExceptionHelper.ThrowTypeError<DateInstance>(_engine)).PrimitiveValue;
 
             if (double.IsInfinity(t) || double.IsNaN(t))
             {
                 ExceptionHelper.ThrowRangeError(_engine);
             }
-            double h = HourFromTime(t);
-            double m = MinFromTime(t);
-            double s = SecFromTime(t);
-            double ms = MsFromTime(t);
+            var h = HourFromTime(t);
+            var m = MinFromTime(t);
+            var s = SecFromTime(t);
+            var ms = MsFromTime(t);
             if (h < 0) { h += HoursPerDay; }
             if (m < 0) { m += MinutesPerHour; }
             if (s < 0) { s += SecondsPerMinute; }
@@ -605,26 +597,26 @@ namespace Jint.Native.Date
             return toIso.TryCast<ICallable>().Call(o, Arguments.Empty);
         }
 
-        public const double HoursPerDay = 24;
-        public const double MinutesPerHour = 60;
-        public const double SecondsPerMinute = 60;
-        public const double MsPerSecond = 1000;
-        public const double MsPerMinute = 60000;
-        public const double MsPerHour = 3600000;
-        public const double MsPerDay = 86400000;
+        public const int HoursPerDay = 24;
+        public const int MinutesPerHour = 60;
+        public const int SecondsPerMinute = 60;
+        public const int MsPerSecond = 1000;
+        public const int MsPerMinute = 60000;
+        public const int MsPerHour = 3600000;
+        public const long MsPerDay = 86400000;
 
         /// <summary>
         /// 15.9.1.2
         /// </summary>
-        public static double Day(double t)
+        public static int Day(double t)
         {
-            return System.Math.Floor(t / MsPerDay);
+            return (int) System.Math.Floor(t / MsPerDay);
         }
 
         /// <summary>
         /// 15.9.1.2
         /// </summary>
-        public static double TimeWithinDay(double t)
+        public static long TimeWithinDay(long t)
         {
             var result = t % MsPerDay;
 
@@ -639,7 +631,7 @@ namespace Jint.Native.Date
         /// <summary>
         /// The number of days in a year
         /// </summary>
-        public static double DaysInYear(double y)
+        public static int DaysInYear(double y)
         {
             if (!(y%4).Equals(0))
             {
@@ -667,18 +659,18 @@ namespace Jint.Native.Date
         /// <summary>
         /// The day number of the first day of the year.
         /// </summary>
-        public static double DayFromYear(double y)
+        public static int DayFromYear(double y)
         {
-            return 365*(y - 1970)
-                + System.Math.Floor((y - 1969)/4)
-                - System.Math.Floor((y - 1901)/100)
-                + System.Math.Floor((y - 1601)/400);
+            return (int) (365*(y - 1970)
+                          + System.Math.Floor((y - 1969)/4)
+                          - System.Math.Floor((y - 1901)/100)
+                          + System.Math.Floor((y - 1601)/400));
         }
 
         /// <summary>
         /// The time value of the start of the year
         /// </summary>
-        public static double TimeFromYear(double y)
+        public static long TimeFromYear(double y)
         {
             return MsPerDay*DayFromYear(y);
         }
@@ -695,7 +687,7 @@ namespace Jint.Native.Date
 
             var sign = (t < 0) ? -1 : 1;
             var year = (sign < 0) ? 1969 : 1970;
-            for (var timeToTimeZero = t; ;)
+            for (var timeToTimeZero = (long) t; ;)
             {
                 //  Subtract the current year's time from the time that's left.
                 var timeInYear = DaysInYear(year) * MsPerDay;
@@ -732,28 +724,27 @@ namespace Jint.Native.Date
         /// <summary>
         /// <value>true</value> if the time is within a leap year, <value>false</value> otherwise
         /// </summary>
-        public static double InLeapYear(double t)
+        public static int InLeapYear(double t)
         {
             var daysInYear = DaysInYear(YearFromTime(t));
 
-            if (daysInYear.Equals(365))
+            if (daysInYear == 365)
             {
                 return 0;
             }
 
-            if (daysInYear.Equals(366))
+            if (daysInYear == 366)
             {
                 return 1;
             }
 
-            ExceptionHelper.ThrowArgumentException();
-            return 0;
+            return ExceptionHelper.ThrowArgumentException<int>();
         }
 
         /// <summary>
         /// The month number of a time value.
         /// </summary>
-        public static double MonthFromTime(double t)
+        public static int MonthFromTime(double t)
         {
             var dayWithinYear = DayWithinYear(t);
             var inLeapYear = InLeapYear(t);
@@ -822,7 +813,7 @@ namespace Jint.Native.Date
             return 0;
         }
 
-        public static double DayWithinYear(double t)
+        public static int DayWithinYear(double t)
         {
             return Day(t) - DayFromYear(YearFromTime(t));
         }
@@ -832,62 +823,62 @@ namespace Jint.Native.Date
             var monthFromTime = MonthFromTime(t);
             var dayWithinYear = DayWithinYear(t);
 
-            if (monthFromTime.Equals(0))
+            if (monthFromTime == 0)
             {
                 return dayWithinYear + 1;
             }
 
-            if (monthFromTime.Equals(1))
+            if (monthFromTime== 1)
             {
                 return dayWithinYear - 30;
             }
 
-            if (monthFromTime.Equals(2))
+            if (monthFromTime == 2)
             {
                 return dayWithinYear - 58 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(3))
+            if (monthFromTime == 3)
             {
                 return dayWithinYear - 89 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(4))
+            if (monthFromTime == 4)
             {
                 return dayWithinYear - 119 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(5))
+            if (monthFromTime == 5)
             {
                 return dayWithinYear - 150 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(6))
+            if (monthFromTime == 6)
             {
                 return dayWithinYear - 180 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(7))
+            if (monthFromTime == 7)
             {
                 return dayWithinYear - 211 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(8))
+            if (monthFromTime == 8)
             {
                 return dayWithinYear - 242 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(9))
+            if (monthFromTime == 9)
             {
                 return dayWithinYear - 272 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(10))
+            if (monthFromTime == 10)
             {
                 return dayWithinYear - 303 - InLeapYear(t);
             }
 
-            if (monthFromTime.Equals(11))
+            if (monthFromTime == 11)
             {
                 return dayWithinYear - 333 - InLeapYear(t);
             }
@@ -899,14 +890,14 @@ namespace Jint.Native.Date
         /// <summary>
         /// The weekday for a particular time value.
         /// </summary>
-        public static double WeekDay(double t)
+        public static int WeekDay(double t)
         {
             return (Day(t) + 4)%7;
         }
 
-        public double LocalTza => Engine.Options._LocalTimeZone.BaseUtcOffset.TotalMilliseconds;
+        public long LocalTza => (long) Engine.Options._LocalTimeZone.BaseUtcOffset.TotalMilliseconds;
 
-        public double DaylightSavingTa(double t)
+        public long DaylightSavingTa(double t)
         {
             var timeInYear = t - TimeFromYear(YearFromTime(t));
 
@@ -923,7 +914,7 @@ namespace Jint.Native.Date
             else
             {
                 // use similar leap-ed year
-                var isLeapYear = InLeapYear(t).Equals(1);
+                var isLeapYear = InLeapYear(t) == 1;
                 year = isLeapYear ? 2000 : 1999;
             }
 
@@ -945,9 +936,9 @@ namespace Jint.Native.Date
             }
         }
 
-        public double LocalTime(double t)
+        public long LocalTime(double t)
         {
-            return t + LocalTza + DaylightSavingTa(t);
+            return (long) (t + LocalTza + DaylightSavingTa(t));
         }
 
         public double Utc(double t)
@@ -955,7 +946,7 @@ namespace Jint.Native.Date
             return t - LocalTza - DaylightSavingTa(t - LocalTza);
         }
 
-        public static double HourFromTime(double t)
+        public static int HourFromTime(double t)
         {
             var hours = System.Math.Floor(t / MsPerHour) % HoursPerDay;
 
@@ -964,10 +955,10 @@ namespace Jint.Native.Date
                 hours += HoursPerDay;
             }
 
-            return hours;
+            return (int) hours;
         }
 
-        public static double MinFromTime(double t)
+        public static int MinFromTime(double t)
         {
             var minutes = System.Math.Floor(t / MsPerMinute) % MinutesPerHour;
 
@@ -976,10 +967,10 @@ namespace Jint.Native.Date
                 minutes += MinutesPerHour;
             }
 
-            return minutes;
+            return (int) minutes;
         }
 
-        public static double SecFromTime(double t)
+        public static int SecFromTime(double t)
         {
             var seconds = System.Math.Floor(t / MsPerSecond) % SecondsPerMinute;
 
@@ -988,10 +979,10 @@ namespace Jint.Native.Date
                 seconds += SecondsPerMinute;
             }
 
-            return seconds;
+            return (int) seconds;
         }
 
-        public static double MsFromTime(double t)
+        public static int MsFromTime(double t)
         {
             var milli = t % MsPerSecond;
 
@@ -1000,12 +991,12 @@ namespace Jint.Native.Date
                 milli += MsPerSecond;
             }
 
-            return milli;
+            return (int) milli;
         }
 
-        public static double DayFromMonth(double year, double month)
+        public static int DayFromMonth(int year, int month)
         {
-            double day = month * 30;
+            int day = month * 30;
 
             if (month >= 7)
             {
@@ -1020,7 +1011,7 @@ namespace Jint.Native.Date
                 day += month;
             }
 
-            if (month >= 2 && InLeapYear(year).Equals(1))
+            if (month >= 2 && InLeapYear(year) == 1)
             {
                 day++;
             }
@@ -1029,7 +1020,7 @@ namespace Jint.Native.Date
         }
 
 
-        public static double DaysInMonth(double month, double leap)
+        public static int DaysInMonth(int month, int leap)
         {
             month = month%12;
 
@@ -1051,8 +1042,7 @@ namespace Jint.Native.Date
                 case 1:
                     return 28 + leap;
                 default:
-                    ExceptionHelper.ThrowArgumentOutOfRangeException(nameof(month), "invalid month");
-                    return 0;
+                    return ExceptionHelper.ThrowArgumentOutOfRangeException<int>(nameof(month), "invalid month");
             }
         }
 
@@ -1091,7 +1081,7 @@ namespace Jint.Native.Date
             }
 
             var sign = (year < 1970) ? -1 : 1;
-            double t = (year < 1970) ? 1 : 0;
+            long t = (year < 1970) ? 1 : 0;
             int y;
 
             if (sign == -1)
@@ -1142,18 +1132,25 @@ namespace Jint.Native.Date
             return (long) time + 0;
         }
 
-        private static bool AreFinite(params double[] values)
+        [MethodImpl(MethodImplOptions.AggressiveInlining)]
+        private static bool AreFinite(double value)
         {
-            for (int index = 0; index < values.Length; index++)
-            {
-                var value = values[index];
-                if (double.IsNaN(value) || double.IsInfinity(value))
-                {
-                    return false;
-                }
-            }
+            return !double.IsNaN(value) && !double.IsInfinity(value);
+        }
+
+        private static bool AreFinite(double value1, double value2)
+        {
+            return AreFinite(value1) && AreFinite(value2);
+        }
 
-            return true;
+        private static bool AreFinite(double value1, double value2, double value3)
+        {
+            return AreFinite(value1) && AreFinite(value2) &&  AreFinite(value3);
+        }
+
+        private static bool AreFinite(double value1, double value2, double value3, double value4)
+        {
+            return AreFinite(value1) && AreFinite(value2) &&  AreFinite(value3) && AreFinite(value4);
         }
     }
 }

Jint/Runtime/ExceptionHelper.cs

@@ -102,6 +102,11 @@ namespace Jint.Runtime
             throw new ArgumentOutOfRangeException();
         }
 
+        public static T ThrowArgumentOutOfRangeException<T>(string paramName, string message)
+        {
+            throw new ArgumentOutOfRangeException(paramName, message);
+        }
+
         public static void ThrowArgumentOutOfRangeException(string paramName, string message)
         {
             throw new ArgumentOutOfRangeException(paramName, message);

appveyor.yml

@@ -1,4 +1,4 @@
-image: Visual Studio 2017
+image: Visual Studio 2019
 
 # Do not build feature branch with open Pull Requests
 skip_branch_with_pr: true
@@ -19,11 +19,11 @@ build_script:
   - dotnet --version
   - dotnet pack -c Release
 test_script:
-  - dotnet test .\Jint.Tests\Jint.Tests.csproj -c Release -f netcoreapp2.1
+  - dotnet test .\Jint.Tests\Jint.Tests.csproj -c Release -f netcoreapp3.0
   - dotnet test .\Jint.Tests\Jint.Tests.csproj -c Release -f net452
-  - dotnet test .\Jint.Tests.CommonScripts\Jint.Tests.CommonScripts.csproj -c Release -f netcoreapp2.1
-  - dotnet test .\Jint.Tests.Ecma\Jint.Tests.Ecma.csproj -c Release -f netcoreapp2.1
-  - dotnet test .\Jint.Tests.Test262\Jint.Tests.Test262.csproj -c Release -f netcoreapp2.1
+  - dotnet test .\Jint.Tests.CommonScripts\Jint.Tests.CommonScripts.csproj -c Release -f netcoreapp3.0
+  - dotnet test .\Jint.Tests.Ecma\Jint.Tests.Ecma.csproj -c Release -f netcoreapp3.0
+  - dotnet test .\Jint.Tests.Test262\Jint.Tests.Test262.csproj -c Release -f netcoreapp3.0
 artifacts:
   - path: 'Jint\**\*.nupkg'
 deploy: