Ver código fonte

Rename WeakMapInstance to JsWeakMap (#1599)

Marko Lahma 2 anos atrás
pai
commit
4bff490028

+ 1 - 1
Jint.Tests/Runtime/WeakSetMapTests.cs

@@ -52,7 +52,7 @@ public class WeakSetMapTests
     public void WeakMapSetShouldThrowForPrimitiveKey(JsValue key)
     public void WeakMapSetShouldThrowForPrimitiveKey(JsValue key)
     {
     {
         var engine = new Engine();
         var engine = new Engine();
-        var weakMap = new WeakMapInstance(engine);
+        var weakMap = new JsWeakMap(engine);
 
 
         var e = Assert.Throws<JavaScriptException>(() => weakMap.WeakMapSet(key, new JsObject(engine)));
         var e = Assert.Throws<JavaScriptException>(() => weakMap.WeakMapSet(key, new JsObject(engine)));
         Assert.StartsWith("WeakMap key must be an object, got ", e.Message);
         Assert.StartsWith("WeakMap key must be an object, got ", e.Message);

+ 2 - 2
Jint/Native/WeakMap/WeakMapInstance.cs → Jint/Native/WeakMap/JsWeakMap.cs

@@ -5,11 +5,11 @@ using Jint.Runtime;
 
 
 namespace Jint.Native.WeakMap;
 namespace Jint.Native.WeakMap;
 
 
-internal sealed class WeakMapInstance : ObjectInstance
+internal sealed class JsWeakMap : ObjectInstance
 {
 {
     private readonly ConditionalWeakTable<JsValue, JsValue> _table;
     private readonly ConditionalWeakTable<JsValue, JsValue> _table;
 
 
-    public WeakMapInstance(Engine engine) : base(engine)
+    public JsWeakMap(Engine engine) : base(engine)
     {
     {
         _table = new ConditionalWeakTable<JsValue, JsValue>();
         _table = new ConditionalWeakTable<JsValue, JsValue>();
     }
     }

+ 1 - 1
Jint/Native/WeakMap/WeakMapConstructor.cs

@@ -35,7 +35,7 @@ namespace Jint.Native.WeakMap
             var map = OrdinaryCreateFromConstructor(
             var map = OrdinaryCreateFromConstructor(
                 newTarget,
                 newTarget,
                 static intrinsics =>  intrinsics.WeakMap.PrototypeObject,
                 static intrinsics =>  intrinsics.WeakMap.PrototypeObject,
-                static (Engine engine, Realm _, object? _) => new WeakMapInstance(engine));
+                static (Engine engine, Realm _, object? _) => new JsWeakMap(engine));
             if (arguments.Length > 0 && !arguments[0].IsNullOrUndefined())
             if (arguments.Length > 0 && !arguments[0].IsNullOrUndefined())
             {
             {
                 var adder = map.Get("set");
                 var adder = map.Get("set");

+ 2 - 2
Jint/Native/WeakMap/WeakMapPrototype.cs

@@ -70,9 +70,9 @@ internal sealed class WeakMapPrototype : Prototype
         return map.WeakMapHas(arguments.At(0)) ? JsBoolean.True : JsBoolean.False;
         return map.WeakMapHas(arguments.At(0)) ? JsBoolean.True : JsBoolean.False;
     }
     }
 
 
-    private WeakMapInstance AssertWeakMapInstance(JsValue thisObject)
+    private JsWeakMap AssertWeakMapInstance(JsValue thisObject)
     {
     {
-        if (thisObject is WeakMapInstance map)
+        if (thisObject is JsWeakMap map)
         {
         {
             return map;
             return map;
         }
         }